From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD12E42A3F; Tue, 2 May 2023 17:02:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE9BB40ED8; Tue, 2 May 2023 17:02:56 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2088.outbound.protection.outlook.com [40.107.96.88]) by mails.dpdk.org (Postfix) with ESMTP id 3CFBD40E2D for ; Tue, 2 May 2023 17:02:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d9SgnMKjfpWgd0rEfUPa+Uz5DK3kiOuuJX3vmAl6dwJqHmZEEFdi7NxMPRVM6YEBjhOoUHM7CUuO9A8w6KjDY9dpxt9aeKslJYaK68kBBKIOoPQ4rWgsl9XW/DWSHHlZH0NKcalLLvEhlTRXPyV070GjvbIqRBniKHpcSJGsxHmwK0VuUO6+HJpByIYCfbWvVvByHhd5whr3Bgf2GvxCiNbpP+22mLfD8Vvoz0hwuZP+HLk3jgq8ZuyysajD/ZGXpGHKjE/7MYPFrFRGhe8Pfz4fG4722/COtVgXp3xwihxqVtKw1GKn2BP+wqIimDbsHjNH/H8v3v4fLmEdJY8qFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IcaLt1wEJMocBWkStB80X8fv9VH9tZzxbyDCvW94Mmw=; b=kfT1MRcunnybKI/zqsDritih7sWiu0IExvIPz014J6GZYeVTpxFJFD80wGBNwqTqXHsF63Jm6rJ11+874hP7IDLQr3h9eQoxUg594luIzoHlZc2p8KNsETUKDjQeRp05cZ+T1EL+pkqFeSgrZV9EOFKUWvV/Q8RJpeJsnX6edDAD3zmLywJuAuELo7ZasGGrf2Djxduky2HOdTPBmHuZtq8glHjhVOS3Fs2ayDz2+TMSuxz7YbODlcUu2g0/gU4zQvJRJxMVx7sVTTgrpAZpcA7cFDaRtV11o3pK80TJS5vTUZAn+4pfc6Zu7C8Bl8G9nV4JbJk61OSKTIe+7n0apg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IcaLt1wEJMocBWkStB80X8fv9VH9tZzxbyDCvW94Mmw=; b=Pc5stmtrrKn5pbvWmdHy6aUtmRsgC/+EusYQodqOEhQd1qzwsODBjSx8DwkcN3jRSwxpY8BurM1DOEjGcNDa437T2TFMdUA+QTUSqxgUU6cdriRJ9n8QOsw4tx0GcOGnO5AyJtN74p1gVSUA2oEpGEMzTTW+vEKMKLFt+Luf0j0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB7104.namprd12.prod.outlook.com (2603:10b6:806:29e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.23; Tue, 2 May 2023 15:02:53 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc%5]) with mapi id 15.20.6340.031; Tue, 2 May 2023 15:02:52 +0000 Message-ID: Date: Tue, 2 May 2023 16:02:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC Content-Language: en-US To: Denis Pryazhennikov , dev@dpdk.org Cc: Ivan Malov , Viacheslav Galaktionov , Thomas Monjalon , Andrew Rybchenko References: <20230428102728.51956-1-denis.pryazhennikov@arknetworks.am> <20230428102728.51956-4-denis.pryazhennikov@arknetworks.am> From: Ferruh Yigit In-Reply-To: <20230428102728.51956-4-denis.pryazhennikov@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0198.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB7104:EE_ X-MS-Office365-Filtering-Correlation-Id: d44adbb2-7bd1-4707-e0f8-08db4b1e4d8d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PfOWb59tsDMJvCsLaTrcx2Hclxn/SJSOvDihbQHWiTATXZRD7elWOJ3FQJ9ho+iMyDs9yYUgitsuTk4dwwBVNs5ZszRX85LXfM3wKuX2w7OTUJXmKktlH3BXMGix9aX8/zr5Vzxqclp+TybZ0Ujv7Sy4gXt+CPhmomL+9XRq0VJtUjeua5TsWkxStrIwXFk/xRaa/ROgVG8TPKwSyjrZhbjVyNV+MD/6h+Zvjn9FoGm7B6bq+KKk444MJvZpB6KTZ1yyZ50DGRgz00qK/1RrCLg9x2YXgAoCQCR0aXTV59+onJz5KE6qFUPSYl2FGehYfhL3FRVsJ/zPvd2u9PqGuEzR8pED8vqkA80YZRXn0r2pIv+8zOXFf8+RZNkPC5aonKd9D4bB4RRU1pgxNDcyHL2Gxw6ce915BrMoZcuNrCN6ktAyrmyY1OUb1dP88rf85G0Vt3iNFvcfEx/Had+AfYuPilEmtOiyIgzI7mQZ2gVhStvqCe6sDuv3tsXYq8bIoRJ9GyrimNIFkud/q31ZrRSYfTeIzwb4NKartTFhwwwQztkucqtSCKjxrWJNo6C95eFyJsyUkXry7eX2/0+8OJIS75JvhsZW8CcFfms6AdGyHN0CnvmZcDfoE5KXN78WvUnxj0gFv4mx9un1o6gbdg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(451199021)(54906003)(2616005)(8676002)(38100700002)(86362001)(8936002)(83380400001)(36756003)(5660300002)(44832011)(31696002)(478600001)(31686004)(316002)(6486002)(66946007)(6666004)(66476007)(66556008)(41300700001)(4326008)(186003)(26005)(2906002)(4744005)(53546011)(6506007)(6512007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1FDbE5nK1ZXaWg0dFl1UUQyUkxmcTAxeTQyTnVkbUtYekdhVkpZelBiaW9M?= =?utf-8?B?WWZaQ1hrVDNoQm8yeUc1S1FaUEhadHNhYlVsbG91R2FpUXg2UGNXbEpmS1Jz?= =?utf-8?B?U2ppbEdvMGE1TzlqNkM3R24xemxNR3FVSjRmQ1FjRjRVOXVXNjc1MVVlcVpx?= =?utf-8?B?YmFDUWZHbzZRZTFiWHVyWG90K3diYXpSTytycjR4ZXgrN2ZzMlF2V005Zyt4?= =?utf-8?B?ckNtVk1ndm9kVWRQY1lVYmF2dUQwSDV4YjJMRDUvMzNhYWU0b0xsN0Urb3c2?= =?utf-8?B?My8yYnY4ZTJvVmtCazJIa2FXQlVlSXN0VGluODNLdmtxaXZaUDNTVnlWVjhF?= =?utf-8?B?NmkxbDVwSTlDVFNuLzlvU2grdzNETTZmdUlRUGRxRkZmNk5jWWFVUEdCcGcy?= =?utf-8?B?NXRaZ09MTkVOdkxZSzFZOEM4amY1SDdkM0taSk9rSWxIU2UxZjlkZEJyS2d6?= =?utf-8?B?am9VdE5CNGlJbjN3c0RpWUtrSjJnYmQzQ0I4ek0yUzFhL2JSME1QSWViNGxu?= =?utf-8?B?NCtZWEoxUzA4SjJqTXdWUGVqTlBBMCs2aGJvQ0Fxbk9uY2RZcG1Mem83cHVm?= =?utf-8?B?T3EyZ2FrQmdKRUJjdEt2eFVCNEZOeUJaSU5KejJUem9xVm9RZjRlQXV5ZnZO?= =?utf-8?B?enFQaFk3am9FdXlITmY3OVFWWkV4QVFLRUZSYnl2UXNzVFR5NTBmVTdSaysv?= =?utf-8?B?QnlyU2QwTEYvTGJDME8ybWFwUlgyWVpVQ1hEWUhuek5OMmVuT3MxVjdLaUFK?= =?utf-8?B?YWZhbEo0VFdxNWFYaEkzZkRZakRQSFJwZjZybHptaWFpWnRWVFYyZGMwdkdW?= =?utf-8?B?cmlWMkpkek15clp4K0hUSjhLczNLaSsyMHMvYWlRL2Y1UmJRT0QzQ2xXeGlZ?= =?utf-8?B?RXc2WjdSMVhVOFJzRU9QMThVRERkWGt3a3NWQzZucGlNWmZlcGxaYjdBUy9I?= =?utf-8?B?dHhtc0tKM3BibHY2bGdFMjdJNlh2UWZ2OHVwbzBCSmczdXB0R3JqVFFrc28x?= =?utf-8?B?eU1xL1VyZXU1TGRsVmRKOTZySisycjVya3NFcnlPQ3VaS2hMY09Rc2dseHVH?= =?utf-8?B?NFdzdHliazZrTnVBZDJxZkNlTG0rbkEwa29lYnAxN3Z6ZTdkYjg0R01CY08z?= =?utf-8?B?YmtGUTVVQ1N3S3pVZ2lpekdqelY0R3dQbmJPUzN6cUJFSWp4NEtoR214LzFT?= =?utf-8?B?Y3JWUmVMOU9HMzBaV2l5dnllY3JXZGZLUmViUTdiNmRxbmxpdXlYVTh5dlBD?= =?utf-8?B?TXI0eXJzY2FlU0xNL3ZBdzFTNE1PZUkrc1JUTEdnWCtoS1NNTG15U3NHWHNp?= =?utf-8?B?NWJ3NFI1cVZ6VHNCaGd3UGliRGZRVmR2cjV3T0l0ZDdiYVR4QUcxWkhydmNJ?= =?utf-8?B?RnhPM1hEWVkwOSs2SlBIUzUyS1ZmVy90M1ZIWVVraUlhYUhOQmpqenhOVms1?= =?utf-8?B?b0o4N0NOcjBieDdENzJNQ202ZGlxMnZXMDF3TnI0UVhHWkYxaHRTR292Sk5y?= =?utf-8?B?dmhHTHRLWHI0eUorNzdiaStONEtzQXNrdUxpdmFUcGxTckxsZjBtSS9neS8r?= =?utf-8?B?Vzg0L1dWeFBHUU90U1d3VE95VGtIbWRUZC9CQlA2b05mWkJ4djhtdnk2SSt5?= =?utf-8?B?SHR6VmdweTI5RHFFeGJIcjA0cS9NZDg3c0xVZEZOb2tYRnZSU3FEajlDd0VN?= =?utf-8?B?TUVFd1dRUFc0MWtibWtWWXZoSnh6bHpYZG5WMUFCajc0aU5UaDlEY1dYVktm?= =?utf-8?B?YjkvY1hQdGhaZUtWYzhOK3pTYmc5MGRhNHZWTlNSQy90WDhFVXdpVy9sMmNk?= =?utf-8?B?OFpNUHltMVl0ZEhjVlgxRWZSdjRrZksrWnNKTTBES2FKb1h2T2FoZktSTllO?= =?utf-8?B?TEZGNFJnT0plYVZyb2U4OW5YSmdOalExMHY3WjQ1R1BZU1EzYmxhMnVEWktr?= =?utf-8?B?bTIrUEl1U2l5V0Q1MWhOSzIyam11a3k4WDlQQ1FhRDR0SlU0alpZc29kOGIr?= =?utf-8?B?azhtbDNIVTBaU0l4T2ovZFp1Q01paXA1TEQzZ3kzWHA1NDJKODFsTUNJVmN6?= =?utf-8?B?d3g5aGszbllDTUZIa21sRitWUkdua3UweSttVXdTTDVpN3gyWDM1ZWdSL09B?= =?utf-8?Q?EdQuIiZ+wzam/zDZ8uKzD8NPz?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d44adbb2-7bd1-4707-e0f8-08db4b1e4d8d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 15:02:52.7377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eTPcIdoktjezh2so6HvlMsbewmW0DMWSuZp5xIY1TEq+LuvCvUt7Ayogga878W4L X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7104 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/28/2023 11:27 AM, Denis Pryazhennikov wrote: > Only one valid FEC mode can be get by rte_eth_fec_get(). > The previous name implied that more than one FEC mode > can be obtained. +1 and patch looks good. But isn't this valid for 'rte_eth_fec_set()', it gets 'fec_mode'. FEC capability has its own type "struct rte_eth_fec_capa". Independent from being single FEC mode or not, I think both 'rte_eth_fec_get()' & 'rte_eth_fec_set()' should get 'fec_mode' as param, what do you think? > Documentation was updated accordingly. > > Signed-off-by: Denis Pryazhennikov > Acked-by: Ivan Malov > Acked-by: Viacheslav Galaktionov <...>