From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7D68A00BE; Fri, 11 Feb 2022 02:28:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 395FA40683; Fri, 11 Feb 2022 02:28:28 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id ADCFB4013F for ; Fri, 11 Feb 2022 02:28:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644542906; x=1676078906; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=w2CHc/0uC1W2B893ALvzMM2Ujf3A7neTF8Vg4Ae0IN8=; b=DrOAu07OId+GqpF6sIlSP89eb7bEzbkK7S9uhyj6oP/9hp8MAqKp1CDr fuI1ORpH3xIzoFem/WsqZSCVIwr7fbQVBLYyUAfgLk2A8Pu4IBf4Pf3Z/ LMwz7pDSVlLjm0QcDsjlxjFkOFaeIEPe0/fpKs7BNR6HcaUJI1e3q+jLE WK0QTMKFVDhoDA6Bh5LLlwcXe1W2cvDh+eiTIFErMSzac08m71Iv39VvO qakfP0TmKTattHbsoh0e/5nsMRqLDV4hivyINLypibhMnnMgwrVYJUIi2 BM+i1ud23mDUJfjjnAjfOcANed5zMej7vfuLb7uIzXKKcuHy90MpJKVAQ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="249843479" X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="249843479" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 17:28:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="541887667" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 10 Feb 2022 17:28:25 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 17:28:24 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 09:28:22 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2308.020; Fri, 11 Feb 2022 09:28:22 +0800 From: "Zhang, Qi Z" To: "Xu, Ting" , Ghalem Boudour , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , Thibaut Collet , Olivier Matz Subject: RE: [PATCH v2] net/iavf: initialize large VF setting at startup Thread-Topic: [PATCH v2] net/iavf: initialize large VF setting at startup Thread-Index: AQHYHmwXcdH0bEflUE2jm7kKZthTNKyMTteAgAFBkYA= Date: Fri, 11 Feb 2022 01:28:22 +0000 Message-ID: References: <20220203090359.29270-1-ghalem.boudour@6wind.com> <20220210104914.5444-1-ghalem.boudour@6wind.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xu, Ting > Sent: Thursday, February 10, 2022 10:17 PM > To: Ghalem Boudour ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Thibaut Collet ; Olivier Matz > > Subject: RE: [PATCH v2] net/iavf: initialize large VF setting at startup >=20 > > -----Original Message----- > > From: Ghalem Boudour > > Sent: Thursday, February 10, 2022 6:49 PM > > To: Wu, Jingjing ; Xing, Beilei > > > > Cc: dev@dpdk.org; Xu, Ting ; Ghalem Boudour > > ; Thibaut Collet > ; > > Olivier Matz > > Subject: [PATCH v2] net/iavf: initialize large VF setting at startup > > > > lv_enabled is used to remember if large VF setting is configured, but > > its value is not initialized at startup. This can lead to a different > > configuration regarding the initial configuration of the PF. > > For example, a first start is done with 8 rx and 8 tx queues. Large VF > > is not needed and reta size is 64. > > A second start is done with 20 rx and tx queues. Large VF is required > > and reta size is 256. > > A third start is done with 2 rx and tx queues. Large VF is not needed > > but reta size is 256 as the PF has been configured during the second st= art. > > > > In order to have a consistent behavior regarding reta size whatever > > the configuration of the PF (may be changed by a previous boot) the > > lv_enabled must be set properly at the init phase. > > > > Signed-off-by: Ghalem Boudour > > Signed-off-by: Thibaut Collet > > Reviewed-by: Olivier Matz > > --- > > v2: > > * Enable large VF at initialization independently of rss configuration > > --- > > drivers/net/iavf/iavf_ethdev.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/net/iavf/iavf_ethdev.c > > b/drivers/net/iavf/iavf_ethdev.c index 79397f15e54f..d6190ac24ac6 > > 100644 > > --- a/drivers/net/iavf/iavf_ethdev.c > > +++ b/drivers/net/iavf/iavf_ethdev.c > > @@ -2278,6 +2278,9 @@ iavf_init_vf(struct rte_eth_dev *dev) > > } > > } > > > > + if (vf->vsi_res->num_queue_pairs > > IAVF_MAX_NUM_QUEUES_DFLT) > > + vf->lv_enabled =3D true; > > + > > if (vf->vf_res->vf_cap_flags & > > VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC) { > > if (iavf_get_supported_rxdid(adapter) !=3D 0) { > > PMD_INIT_LOG(ERR, "failed to do get supported > rxdid"); > > -- > > 2.30.2 >=20 > Acked-by: Ting Xu Applied to dpdk-next-net-intel. Thanks Qi