* [dpdk-dev] [PATCH] build: add note about make system deprecation
@ 2020-04-09 10:57 Bruce Richardson
2020-04-09 11:09 ` Ferruh Yigit
2020-04-27 14:25 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
0 siblings, 2 replies; 6+ messages in thread
From: Bruce Richardson @ 2020-04-09 10:57 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
When anyone uses the make build system, they are to be informed
about upcoming plans to deprecate and subsequently remove that
system and to use meson and ninja instead.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
mk/rte.sdkbuild.mk | 4 ++++
mk/rte.sdkconfig.mk | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
index b512de1ec..67d07a7ed 100644
--- a/mk/rte.sdkbuild.mk
+++ b/mk/rte.sdkbuild.mk
@@ -28,6 +28,10 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
.PHONY: build
build: $(ROOTDIRS-y)
@echo "Build complete [$(RTE_TARGET)]"
+ @echo "==== NOTE ===="
+ @echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+ @echo "Building DPDK with 'make' will be deprecated in a future release"
+ @echo "=============="
.PHONY: clean
clean: $(CLEANDIRS)
diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
index f538649f2..9a7ffbe9a 100644
--- a/mk/rte.sdkconfig.mk
+++ b/mk/rte.sdkconfig.mk
@@ -62,6 +62,10 @@ else
config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
@echo "Configuration done using" \
$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
+ @echo "==== NOTE ===="
+ @echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+ @echo "Building DPDK with 'make' will be deprecated in a future release"
+ @echo "=============="
endif
$(RTE_OUTPUT):
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] build: add note about make system deprecation
2020-04-09 10:57 [dpdk-dev] [PATCH] build: add note about make system deprecation Bruce Richardson
@ 2020-04-09 11:09 ` Ferruh Yigit
2020-04-09 11:16 ` Bruce Richardson
2020-04-27 14:25 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2020-04-09 11:09 UTC (permalink / raw)
To: Bruce Richardson, dev
On 4/9/2020 11:57 AM, Bruce Richardson wrote:
> When anyone uses the make build system, they are to be informed
> about upcoming plans to deprecate and subsequently remove that
> system and to use meson and ninja instead.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> mk/rte.sdkbuild.mk | 4 ++++
> mk/rte.sdkconfig.mk | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
> index b512de1ec..67d07a7ed 100644
> --- a/mk/rte.sdkbuild.mk
> +++ b/mk/rte.sdkbuild.mk
> @@ -28,6 +28,10 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
> .PHONY: build
> build: $(ROOTDIRS-y)
> @echo "Build complete [$(RTE_TARGET)]"
> + @echo "==== NOTE ===="
> + @echo "It is recommended to build DPDK using 'meson' and 'ninja'"
> + @echo "Building DPDK with 'make' will be deprecated in a future release"
> + @echo "=============="
>
> .PHONY: clean
> clean: $(CLEANDIRS)
> diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
> index f538649f2..9a7ffbe9a 100644
> --- a/mk/rte.sdkconfig.mk
> +++ b/mk/rte.sdkconfig.mk
> @@ -62,6 +62,10 @@ else
> config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
> @echo "Configuration done using" \
> $(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
> + @echo "==== NOTE ===="
> + @echo "It is recommended to build DPDK using 'meson' and 'ninja'"
> + @echo "Building DPDK with 'make' will be deprecated in a future release"
> + @echo "=============="
What do you think providing a link to meson documentation too?
> endif
>
> $(RTE_OUTPUT):
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] build: add note about make system deprecation
2020-04-09 11:09 ` Ferruh Yigit
@ 2020-04-09 11:16 ` Bruce Richardson
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2020-04-09 11:16 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev
On Thu, Apr 09, 2020 at 12:09:57PM +0100, Ferruh Yigit wrote:
> On 4/9/2020 11:57 AM, Bruce Richardson wrote:
> > When anyone uses the make build system, they are to be informed
> > about upcoming plans to deprecate and subsequently remove that
> > system and to use meson and ninja instead.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > mk/rte.sdkbuild.mk | 4 ++++
> > mk/rte.sdkconfig.mk | 4 ++++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
> > index b512de1ec..67d07a7ed 100644
> > --- a/mk/rte.sdkbuild.mk
> > +++ b/mk/rte.sdkbuild.mk
> > @@ -28,6 +28,10 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
> > .PHONY: build
> > build: $(ROOTDIRS-y)
> > @echo "Build complete [$(RTE_TARGET)]"
> > + @echo "==== NOTE ===="
> > + @echo "It is recommended to build DPDK using 'meson' and 'ninja'"
> > + @echo "Building DPDK with 'make' will be deprecated in a future release"
> > + @echo "=============="
> >
> > .PHONY: clean
> > clean: $(CLEANDIRS)
> > diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
> > index f538649f2..9a7ffbe9a 100644
> > --- a/mk/rte.sdkconfig.mk
> > +++ b/mk/rte.sdkconfig.mk
> > @@ -62,6 +62,10 @@ else
> > config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
> > @echo "Configuration done using" \
> > $(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
> > + @echo "==== NOTE ===="
> > + @echo "It is recommended to build DPDK using 'meson' and 'ninja'"
> > + @echo "Building DPDK with 'make' will be deprecated in a future release"
> > + @echo "=============="
>
> What do you think providing a link to meson documentation too?
>
Not a bad idea - though it may need to wait until the instructions on the
website itself get updated. Currently the best link is probably,
http://doc.dpdk.org/guides/linux_gsg/build_dpdk.html#compiling-and-installing-dpdk-system-wide
but it's rather long and unwieldy.
/Bruce
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] build: add note about make system deprecation
2020-04-09 10:57 [dpdk-dev] [PATCH] build: add note about make system deprecation Bruce Richardson
2020-04-09 11:09 ` Ferruh Yigit
@ 2020-04-27 14:25 ` Bruce Richardson
2020-04-27 15:04 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Bruce Richardson @ 2020-04-27 14:25 UTC (permalink / raw)
To: thomas; +Cc: ferruh.yigit, dev, techboard, Bruce Richardson
When anyone uses the make build system, they are to be informed
about upcoming plans to deprecate and subsequently remove that
system and to use meson and ninja instead.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: added link to the docs on building DPDK
---
mk/rte.sdkbuild.mk | 5 +++++
mk/rte.sdkconfig.mk | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
index b512de1ec..d1d57b669 100644
--- a/mk/rte.sdkbuild.mk
+++ b/mk/rte.sdkbuild.mk
@@ -28,6 +28,11 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
.PHONY: build
build: $(ROOTDIRS-y)
@echo "Build complete [$(RTE_TARGET)]"
+ @echo "==== NOTE ===="
+ @echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+ @echo "See https://doc.dpdk.org/guides/linux_gsg/build_dpdk.html for instructions"
+ @echo "Building DPDK with 'make' will be deprecated in a future release"
+ @echo "=============="
.PHONY: clean
clean: $(CLEANDIRS)
diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
index f538649f2..2ea85e464 100644
--- a/mk/rte.sdkconfig.mk
+++ b/mk/rte.sdkconfig.mk
@@ -62,6 +62,11 @@ else
config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
@echo "Configuration done using" \
$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
+ @echo "==== NOTE ===="
+ @echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+ @echo "See https://doc.dpdk.org/guides/linux_gsg/build_dpdk.html for instructions"
+ @echo "Building DPDK with 'make' will be deprecated in a future release"
+ @echo "=============="
endif
$(RTE_OUTPUT):
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] build: add note about make system deprecation
2020-04-27 14:25 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
@ 2020-04-27 15:04 ` Ferruh Yigit
2020-05-19 16:05 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2020-04-27 15:04 UTC (permalink / raw)
To: Bruce Richardson, thomas; +Cc: dev, techboard
On 4/27/2020 3:25 PM, Bruce Richardson wrote:
> When anyone uses the make build system, they are to be informed
> about upcoming plans to deprecate and subsequently remove that
> system and to use meson and ninja instead.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] build: add note about make system deprecation
2020-04-27 15:04 ` Ferruh Yigit
@ 2020-05-19 16:05 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-05-19 16:05 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, techboard, Ferruh Yigit
27/04/2020 17:04, Ferruh Yigit:
> On 4/27/2020 3:25 PM, Bruce Richardson wrote:
> > When anyone uses the make build system, they are to be informed
> > about upcoming plans to deprecate and subsequently remove that
> > system and to use meson and ninja instead.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-19 16:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-09 10:57 [dpdk-dev] [PATCH] build: add note about make system deprecation Bruce Richardson
2020-04-09 11:09 ` Ferruh Yigit
2020-04-09 11:16 ` Bruce Richardson
2020-04-27 14:25 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2020-04-27 15:04 ` Ferruh Yigit
2020-05-19 16:05 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).