From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 261497D4B for ; Mon, 4 Sep 2017 18:29:24 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 09:29:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,475,1498546800"; d="scan'208";a="125450801" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 04 Sep 2017 09:29:18 -0700 To: Jan Blunck , dev@dpdk.org References: <20170711232512.54641-1-jblunck@infradead.org> <20170714211213.34436-1-jblunck@infradead.org> <20170714211213.34436-15-jblunck@infradead.org> From: Ferruh Yigit Message-ID: Date: Mon, 4 Sep 2017 17:29:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170714211213.34436-15-jblunck@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 14/15] devargs: remove type field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 16:29:25 -0000 On 7/14/2017 10:12 PM, Jan Blunck wrote: > This removes the enum rte_devtype field ``type`` from struct rte_devargs. > > Signed-off-by: Jan Blunck <...> > --- a/lib/librte_eal/common/include/rte_devargs.h > +++ b/lib/librte_eal/common/include/rte_devargs.h > @@ -75,8 +75,6 @@ enum rte_devtype { > struct rte_devargs { > /** Next in list. */ > TAILQ_ENTRY(rte_devargs) next; > - /** Type of device. */ > - enum rte_devtype type; I am not sure if type can be removed, please check the comment on patch 5/15. > /** Bus handle for the device. */ > struct rte_bus *bus; > /** Name of the bus the device belongs to. */ >