From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4BCE0AACB for ; Thu, 29 Mar 2018 20:43:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2018 11:43:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,378,1517904000"; d="scan'208";a="215892701" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.18.75]) ([10.252.18.75]) by fmsmga006.fm.intel.com with ESMTP; 29 Mar 2018 11:43:05 -0700 From: Ferruh Yigit To: Thomas Monjalon Cc: hemant.agrawal@nxp.com, dev@dpdk.org References: <20180329153931.26351-1-thomas@monjalon.net> <2419180.MvykWTCLKm@xps> <0a59c197-0331-a122-f997-b8a77b39e01b@intel.com> <1680117.05lWP9jXLg@xps> <79a33084-a6fc-d04a-a503-3c8cc15a58b2@intel.com> Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR1xgUJB33UawAKCRD5M+tD3xNhH3TID/wNjq1doFXg49WaM7ZXez/1 qwj7U6FQ2eUhlEPX8dXc52cu+iQk8/mssXQtANEx+jndxfvlkikBNgI+mr3m/ho54uQWFZd7 Bv0DVVkLHNkLWK6tT6iISdCgXrQuOv8y5rucEGkJ8dDPsp8Mqr4sBjavRBpczphoa3miKusA HzUEo0SYuHUPmBlbmvKv4PkA5quWtXpkgV2HZ1bW9X0dQkAqEVioAPm5Q6pXJODfV8kaZUtJ z4swEtBnK9XAWm2HccF7KmFh0vv+Zh9lEMnEFt7UPXngY6+xCTo6xV1IVc8EZfDjOip8I4h2 ALMaLgrZwA9VVmHCVOrnO3UZqfGehrwz4O3sUrcmIzxjk3gfBmVRCBfuWGchSpWtZ99U6V1a OEuG+ymyjBDtyymW+KSvmCBl2gIxZHvZFvSRRdDObkkUIskSJ95f/6HBOESRZBOiV9GEAhC5 gI9OAKKF8HQaN/r5KJrkzscjQcjIdV1jXhTkfQ4wH3GJiVM5JxsKsEjjRw7yfSJo2GBEGqMe KMwMLWg4f1DgVtjOuGf10isu+29MvapW2IxKYaHcVc2vHfWbDi2AvBj/VAzKILWbTEgI1VL5 zKpo5p6X2O55oEyeflDiAzrUfvLqB4vmTyqXtW6PdLyZC7kXIzmNu6EBVx9oSgy3CADw5saN 0La9OoCAc7Tn+s7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKA== Message-ID: Date: Thu, 29 Mar 2018 19:43:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <79a33084-a6fc-d04a-a503-3c8cc15a58b2@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mk: fix kernel modules build dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 18:43:08 -0000 On 3/29/2018 7:21 PM, Ferruh Yigit wrote: > On 3/29/2018 6:01 PM, Thomas Monjalon wrote: >> 29/03/2018 18:50, Ferruh Yigit: >>> On 3/29/2018 5:43 PM, Thomas Monjalon wrote: >>>> 29/03/2018 18:38, Ferruh Yigit: >>>>> On 3/29/2018 5:32 PM, Thomas Monjalon wrote: >>>>>> 29/03/2018 17:48, Ferruh Yigit: >>>>>>> On 3/29/2018 4:39 PM, Thomas Monjalon wrote: >>>>>>>> Some kernel modules may need some header files to be "installed" >>>>>>>> in the build directory. >>>>>>>> >>>>>>>> When running multiple threads of make, kernel modules can try to >>>>>>>> be compiled before the lib headers are ready: >>>>>>>> make -j3 >>>>>>>> kernel/linux/kni/kni_misc.c:19:37: fatal error: >>>>>>>> exec-env/rte_kni_common.h: No such file or directory >>>>>>> >>>>>>> Is there a reason to keep header in eal when module itself moved into kernel? >>>>>> >>>>>> It seems you missed my comment below: >>>>>> >>>>>> On a related note, this header file >>>>>> lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h >>>>>> could be moved to lib/librte_kni/ >>>>>> Opinion? >>>>> >>>>> Ahh, yes we are saying same thing. >>>>> But not sure if it should go under lib/librte_kni/ or kernel/linux/kni/? >>>>> I lean to kernel/linux/kni/. >>>> >>>> Why in kernel/? >>>> >>>> Logically, kernel/ depends on lib/ but not the reverse. >>>> >>>> And regarding the licensing, we avoid BSD files in Linux modules. >>> >>> From functionality point of view, module provides the functionality and it >>> should provide the header, this can be all subjective tough :) >>> >>> Or in other words, if you have the kernel module, you can write another piece of >>> userspace application (without using librte_kni) and it will be functional. >>> But if you have the librte_kni only, it won't be functional on its own. >>> >>> Providing header with kernel enables other userspace app to user KNI. >> >> So you are saying we should reverse the dependency? >> It would mean moving all headers used by kernel modules in kernel/ directory: > > No, not talking about moving headers to kernel/ folder. But we can "liberate" J > the kernel modules. > > For KNI, rte_kni_common.h is shared between kernel and userspace, can't escape > from it. But why this common header needs to depend other dpdk headers at all? > Indeed commenting out rte_common and rte_config worked fine, it seem there is > already no dependency. Hemant is right, putting rte_kni_common makes build dependent to module build, and module is more fragile. I agree to move header to userspace library. > > Same thing for igb_uio, why in needs to depend other dpdk headers? > Following seems fixing the issue, yes it is duplication but I think that is OK: > -#include > +/*#include */ > +enum rte_intr_mode { > + RTE_INTR_MODE_NONE = 0, > + RTE_INTR_MODE_LEGACY, > + RTE_INTR_MODE_MSI, > + RTE_INTR_MODE_MSIX > +}; > +#define RTE_INTR_MODE_NONE_NAME "none" > +#define RTE_INTR_MODE_LEGACY_NAME "legacy" > +#define RTE_INTR_MODE_MSI_NAME "msi" > +#define RTE_INTR_MODE_MSIX_NAME "msix" > >> - rte_pci_dev_features.h >> \- rte_pci_dev_feature_defs.h >> - rte_kni_common.h >> \- rte_common.h >> >> Are you sure? >> >> >