From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7488345EEE; Thu, 19 Dec 2024 17:34:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3ABB940265; Thu, 19 Dec 2024 17:34:39 +0100 (CET) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 7E7A44025F; Thu, 19 Dec 2024 17:34:37 +0100 (CET) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id E6FC511197; Thu, 19 Dec 2024 17:34:36 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id DB3E111196; Thu, 19 Dec 2024 17:34:36 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.2 Received: from [192.168.1.85] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id E11AB1120E; Thu, 19 Dec 2024 17:34:34 +0100 (CET) Message-ID: Date: Thu, 19 Dec 2024 17:34:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] cryptodev: fix C++ include To: Thomas Monjalon , dev@dpdk.org Cc: stable@dpdk.org, Zhigang Hu , Akhil Goyal , Fan Zhang , =?UTF-8?Q?Morten_Br=C3=B8rup?= , David Marchand , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= References: <20241219133139.420001-1-thomas@monjalon.net> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <20241219133139.420001-1-thomas@monjalon.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-12-19 14:30, Thomas Monjalon wrote: > Some cryptodev functions were not included in an extern "C" block. > > There are 2 blocks, the second one being fast path inline functions, > preceded with an include of the required rte_cryptodev_core.h file. > > Fixes: 719834a6849e ("use C linkage where appropriate in headers") > Cc: stable@dpdk.org > > Reported-by: Zhigang Hu > Signed-off-by: Thomas Monjalon > --- > v2: keep rte_cryptodev_core.h include at the same place > --- > .mailmap | 1 + > lib/cryptodev/rte_cryptodev.h | 12 ++++++++++-- > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/.mailmap b/.mailmap > index 2bf38f9e8c..1e4bb06d6e 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -1794,6 +1794,7 @@ Zhenghua Zhou > Zhenning Xiao > Zhe Tao > Zhichao Zeng > +Zhigang Hu > Zhigang Lu > Zhiguang He > Zhihong Peng > diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h > index c64d2f83a0..071ff3dbdf 100644 > --- a/lib/cryptodev/rte_cryptodev.h > +++ b/lib/cryptodev/rte_cryptodev.h > @@ -22,6 +22,10 @@ > > #include "rte_cryptodev_trace_fp.h" > > +#ifdef __cplusplus > +extern "C" { > +#endif > + > /** > * @internal Logtype used for cryptodev related messages. > */ > @@ -1928,11 +1932,16 @@ int rte_cryptodev_remove_deq_callback(uint8_t dev_id, > uint16_t qp_id, > struct rte_cryptodev_cb *cb); > > -#include > +#ifdef __cplusplus > +} > +#endif > + > +#include "rte_cryptodev_core.h" > > #ifdef __cplusplus > extern "C" { > #endif > + > /** > * > * Dequeue a burst of processed crypto operations from a queue on the crypto > @@ -2125,7 +2134,6 @@ rte_cryptodev_qp_depth_used(uint8_t dev_id, uint16_t qp_id) > return rc; > } > > - > #ifdef __cplusplus > } > #endif Reviewed-by: Mattias Rönnblom