From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80050.outbound.protection.outlook.com [40.107.8.50]) by dpdk.org (Postfix) with ESMTP id B55C258F6 for ; Mon, 8 Oct 2018 14:19:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UVNguA1DqPvzBKH8SJwTC1FagOJ/HCI2HiHOS1gqKg8=; b=AwgTdFrL8fG1xwHtZvs4/X23a1BRYQ6YFv7VmQcru5Mi4+AdXmweFISCXY/BERwAAV/CatfjjwHUf1D9Yzg7rbhqlj8j6x33yBjwH9N+8VfWEZt+UXECEKd+yDLV+TPkSxp8HIOISQlVwq6ItO71tbkBa7vGyCBY3ranluCdDZI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by AM6PR04MB4678.eurprd04.prod.outlook.com (2603:10a6:20b:1b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.21; Mon, 8 Oct 2018 12:19:18 +0000 To: Ferruh Yigit Cc: Reshma Pattan , Hemant Agrawal , Ashish Gupta , Fiona Trahe , Pablo de Lara , Akhil Goyal , Declan Doherty , Fan Zhang , Rahul Lakkireddy , Gaetan Rivet , Qi Zhang , Xiao Wang , Beilei Xing , Wenzhuo Lu , Konstantin Ananyev , Rasesh Mody , Harish Patil , Shahed Shaikh , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Nipun Gupta , Anatoly Burakov , Thomas Monjalon , Jerin Jacob , Olivier Matz , Chas Williams , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Rosen Xu , Tianfei zhang , dev@dpdk.org References: <20181004034047.26824-1-ferruh.yigit@intel.com> <20181005162612.31906-1-ferruh.yigit@intel.com> <20181005162612.31906-2-ferruh.yigit@intel.com> From: Shreyansh Jain Message-ID: Date: Mon, 8 Oct 2018 17:48:52 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181005162612.31906-2-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR0101CA0008.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::18) To AM6PR04MB4678.eurprd04.prod.outlook.com (2603:10a6:20b:1b::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa03f324-bea3-49b1-2955-08d62d184857 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4678; X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4678; 3:KwVxmKc610SzfAIdMiOGevQJV/6O4b3wJTx/wP59lIZgNvR2H+IG4M+2aB1pWgxTgAkXraIUtPZ+5NQy3FZwVHcRQx8iVqp+8VV6yYHKmMt6mwh7EUDw/UPUhw0UeKLYxD92Akk/qvlQG0q1l1A/5OGxi4wF5h4at52J4QPyOueyGYmG2cu8lSBuYXM2PnlSWyeUAUwnDdSpCrHlwkwJBlZe/UXr3nPrIx/nkyJy9sI4TgTlMlJ2/4ipSbic8iDu; 25:1L4jUGNpMVHt0IIeqJABPKK6aVkn0QkXssGrHG4nqdxyhI0NHtERycg8nUQyPCdEgj7xHHxv/SVQb0bMwW30LFplXpTnNcm5YvVnstsRSojsG5KRB4Ysu2AVHyvsucAcdgCxAf6qsJugdZWled9yL+uCps2tYVcWdl7UotmhO0UX6fosZYR0qwJOCLCxF8vgfUx12D7Qg626TQW1uW375qb5nUz31LM4MJJkPlx3SDLmMxvgLPaJm2kDzB4+yyMOGUOD8UBazAWevEix8Sr0veGNgmkVjw7PcITtmEHqmAUqoKq2ew6nmWlfaDOOOhS3gzzKZhkFvHGA89UWPnbRYw==; 31:uo6QHfdFNG1rH+kWLCaxZRRQKAVLeeBiyoIxBfyBCqoYHrNweOXb/98dSH6SSoJCQEQWvcPXfyJisWKlsVas11F5izglM0YoMj6g9EliCYNCQXwIK9a2nfm400lVoW3uUckg2uWBvlUSxrQkA3ovHOY8ZqnNJyyKEcur7VL6sSPb6reyeczBfudhfDhhGX1wzBvBJNqooBPY6zxmNZlIgbTiQbiBw9pKIM988E179OQ= X-MS-TrafficTypeDiagnostic: AM6PR04MB4678: X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4678; 20:hk9/8OrAagGOUi8zM7pTRY+OJLLASX2H9ATk9pXa+/y7o7rPfmzTLFplnslhlJFYMhzYf9hWvuyrb6b/VYmkpC6lSfPORoa7ip+VQboAcyYvUm9tE8et12hBHr+kp+A0NymmGRTEsf0UXitLEco8zNAwtVq1lI9pyfHfZr0HmHUdh6Zb6tIu+/Bx1NqKHIjExPZGpa8IHmeZGTbmqudkXIgRKkp5AVfHmfDMVAyeVXlSfCs1XM1w9EzNKO61VGVSdN5t36/dastjfQEGHbcP01UAXtpd/NXPm0oYL7jFcMAaG/ONGbLaW/mVXWIhg/umGhMgnL1QTiv/qz0u6PF4bqyaQeUmudbnawoaPXPeBZs5sl8ntwLg17J+tdeW7ye/I3dY2Xh5lGKP0Z1fRSjDv5mErdUlHREpMoPbni5ARhuHDGFAv8BgfPIfVLKzTOidQUCtA/AYCB1v/MtTlGLNCW9/IE/No7pyT06uuF1y0fEhhmQxFpvcgB5iiui1IvEJ; 4:FMHGukjMHqfspsIFtfRnVcht39LU9lBA7MIl7+hrAMd1oLukwpHexvmHfTDfLlwaVLpI/lY7qx6XHhzz93q7fhGLqUtExz2UKIDAOQbcTj75s5TwonDmKKG+BNuobLTrFjqQCHeVHKASQ8o0N/HEvO3aEuWExUDEWD7YT9OoMS9vX9iBNeRWpRe3ebGiB1ScFXkPORdKbJlotpsvTX3ZY3mUT3O/GK0VJweM8OtC3mdZ1SBSzWDhnNJGWlN5Usn5rmk3PsB3sfZh7xqBya+I2o0epdK9GpE0FphigjEM7tdWPB4v4EJm99/rW0iUS1/YuGvqHKIzPcW+LfVeuv+GtAIj1QzReJ/zWSveneZLJxg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699)(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(3002001)(6055026)(149066)(150057)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123560045)(201708071742011)(7699051); SRVR:AM6PR04MB4678; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4678; X-Forefront-PRVS: 081904387B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(136003)(346002)(396003)(39860400002)(376002)(366004)(189003)(199004)(81166006)(446003)(6666003)(81156014)(8936002)(7406005)(7416002)(229853002)(66066001)(65956001)(65806001)(68736007)(6916009)(36756003)(53936002)(956004)(6486002)(486006)(47776003)(14444005)(2616005)(31686004)(476003)(8676002)(76176011)(11346002)(55236004)(52116002)(106356001)(105586002)(44832011)(23676004)(52146003)(2486003)(386003)(6116002)(16576012)(2906002)(316002)(478600001)(97736004)(67846002)(58126008)(186003)(16526019)(7736002)(305945005)(65826007)(5009440100003)(54906003)(6246003)(5660300001)(25786009)(77096007)(4326008)(26005)(50466002)(3846002)(64126003)(230700001)(86362001)(31696002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR04MB4678; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTZQUjA0TUI0Njc4OzIzOmQ3cURzd2ZSekV3a3BXR1FXbkswb0xLRzl2?= =?utf-8?B?bUVxY3cwT21kMHQ1d1NPTHRHWHQweUxvZjQxUzNlRHIvdFY2Z2dkbnhOTzNv?= =?utf-8?B?U1puRjQxeHM5Wm8rd01GQldsRWZkTEJ5VzcrL21ydE1KYU5pc1RRaTQrU3pu?= =?utf-8?B?TmE2YmlPWlFVNzI1V1ZiaXpqTTNTVkswVTE2ZTNGRUk2Sy9QVm52MVZEKzhk?= =?utf-8?B?SFN0dHBDbmF6bzk3ZmptZVhrYUxUT1FTdU5yM3BtRmt4a1E2Y1VTeUFhTTV5?= =?utf-8?B?ZVZjTlVVcnFKVDkwM3pDdngyV1hNSStlSjR3Zm1hZytUUjZOZFArVG5JZUNy?= =?utf-8?B?Yk5mMkkyeWdNN0xyazRrelkvUUw2QXdZOURYYlRFTmNqTWdWK0I5RytjSHNK?= =?utf-8?B?WWdWSXo5WDNaSXE5MTI0ZkFQVWRWTGY0QisyVi9nL1dibVkzWEhlVU1GSzBI?= =?utf-8?B?aVU4aGdraVo5YjBHTmlxNUVNbllRdjlmMDBxaHFrQ3lRWGlmbWZmaWkxcHNy?= =?utf-8?B?TVRlOUtEa0QvdFpzU2pBc3dPYWQrbityaTE5enVLbGpRRVRiQXBPRXVEMEto?= =?utf-8?B?WFJYcTRaRXZPTmtLdE5wV0syUHhReC9lRUxzb2Vrb0MvUFNMVHlVSXVHNU5K?= =?utf-8?B?R1U4VnVMQ2EwanNVVkhNamxsc3I5NUlJYnhja0tMMjd1dE9nV1VFYVVoMkM2?= =?utf-8?B?dWFoZTg0anVnc2FVbGJsYjRHVWRBZTNMU1VkTkNVUWNseUkzTStzMXV5YXZn?= =?utf-8?B?dTBMU0I5dFFxclB5T25aMUtSZ3JVa3NRZzUzQ0VLRktxcHRZczZmSE1NaGN0?= =?utf-8?B?bTUwZXJJa2w3NWhEYkNDeVdVY2U5cWw0ZTJoall3L3UyN0xEb3AxUHloWTJV?= =?utf-8?B?YnpDTTQ0M2hBeVp1cGwwU29zZ3JPSWxYUDZIWTVISWppMlBzajJybm04ZDhY?= =?utf-8?B?OEpmRnVwK0hPSDNWd2lKc1dvK3Z1TjJaUzAwVmhGK21HNzFGVHJzdkRPelR3?= =?utf-8?B?RHNiTlN0Sk42N01DZmwzd1QvOGpLNlc1dmpwWnVvY3RBME41dTBiN3dkZ1VX?= =?utf-8?B?N2pVK3BxZkxZUDVqSHo0ZE14dHYrSFhSZS92NlFTZzZUWlpTNnVyQkdjMmRO?= =?utf-8?B?UU5Wb09lbjFqenVqVnNsS2J3bFNlUklDaFJNWkxkTFp1SHdjWjFOWnI3ZVpn?= =?utf-8?B?ZkQ2UXE2azhKK0xuenhqZWlGcndPcStzTnhvMXhwbDJpYXV6bEpMaEYvWW0v?= =?utf-8?B?QTZDSWpnOVYraXU4SFRBdGpobFhxT0VyYitQbmxxaFBaY2JDR1plTmNmODlP?= =?utf-8?B?anJNQkdaUFhsUER6QWE2WVJCUGRzK1hPTXk2L2Z6bDN2SjJGMHBIdzRNd1pP?= =?utf-8?B?SzM0UzBGNmVDbGxEUDNnT3VpcXNSY1JSOWtVM2tlS0JwcXplSHRRWFd5OGNH?= =?utf-8?B?NHNUYm9zUUFKY1p1TnV4b2ZvQlFCUGpXT1ViK0lpM0paTEtNbkdEVkY4NGVO?= =?utf-8?B?N2FyQm0vV3kxSm05S0x4Uk9oaURkY09CbWIxcXlQUWkrWlBwOW5zbXI1UUg2?= =?utf-8?B?N0ptY0dZZkNLWlhSUnZ1RkJXYmpFaEhOK04xUmxJSDJUalJPUzk0M1Z6cU5W?= =?utf-8?B?Z1ZKQis5R2ZzVmk2djZZV2tzTmswd3VKRVV6UlFFVHRUeitPcmk1akgydmtv?= =?utf-8?B?UUtRajdTNk9mR1FTVUpxM3VubzB6dkVnZFlneVQzZHMxaWtISE9ycVIzODJx?= =?utf-8?B?RXg2cVhQV1V6cHBRaFFIM0NXbzNFNWZESGhaYkdod0FWRFdyZy8remV3VlY0?= =?utf-8?B?Vkw0MlFCUTVVeXE5VkE4MnpxZXpBbFZEb0NUNmsrRUZic000dTBmdFNmSWt0?= =?utf-8?B?SlEycUJvQURrQlBGc3lhdFU0SUJCK2g1SFVGYmg1MWJIZFJBbUZ5aGNSR3c3?= =?utf-8?B?aG9ZZTFDS0ZKL2N1UW50N0t6SWcvTEozV0FsaHdMbVVxZWZyZmN5UDJwdk9W?= =?utf-8?B?Ym43NDAzN3RoTjc3YjF2K3k2WUplZnZpUFZJREdndGh3cUZMSmY3TGYyRVcr?= =?utf-8?B?UEhjZ0NBN2VxN2NTaGFqeW5OZ2tacHQ2Z29JcE5jUmFCdW1MM3AxQ3UwZm9u?= =?utf-8?Q?0l1/iVZfsF1knX5P1VC+fXE=3D?= X-Microsoft-Antispam-Message-Info: VJ32FqwcNbtuHlcR30BRhzj1wIDK7HYCs5+P4mbdE/W5xaunO8FTLh2nhOUYq1E7Em0y5zyNJD87/eR/bWOx9+VSEebISlka9IrycJ1AhpvvRo4CGDIVCG3tSibS7grTHphadYnj0fFUJfBALzoMF6mpT8wXs2pqi3+onyOOkFzyqu888njddYvhcHucWqzr2aFCg9f1DYyCwwYXnqi9qh8eX0YmfcFYZu7ChsH9saNXBh8J5Hyw+wXtB+b1UJZGUdaNfE2l1yI0ugFWtSH5TgapUBWfrgVf5jOKD12jtwlGroGcfnk94aLRcOEQ3iQecwfALEtvmNc//O/9BKHmkenyrWjyVfgNKScywcnG6go= X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4678; 6:v91NRVpkBoilc2BqYxkStGI2W8SZQkpl/9CcXuAlluqI0vvNeJWyB2cORuL3bfvNNnp2u46s8v5scZ/Mhwhwfht4xPqihWyOjYT9pey5LqVdjUJSXYcV1XNlBiFWWPhfH+pjGb19o3nw6t5wvd0DUmUpwBpfSeSO601lKnKWgZJ8cZCSTAixMLD6uKus00PyUyo3rhF/e7KfG/v8UDN+KfzVpQtoRVwZW6hRhGNvhE6JIKPytxM1d6RCJJr9SYGtZawALO+AbzPpHlzvpkbIoIIMlca8ZMIcsEW9V8FmsgjYa8pVAyOnT1Kd//jj748IYWKCaf7qPVlc9tCt6ElG1QS5LEDszxO9chgFv+KMcgM8Dohedclmwhb3zdt/2zOpIIC3yQv/6Jxv+5UIHsHgAkmqj9anvmKjmsU/IpskCvSPCIgOqZzBikiWm39gkosHWapLsPJykXc36wLTmNURPA==; 5:lsihlxD3EZ2DmxqMH7KTkOCnTEhE731a1EpeJYgYKDkj1wbLIt7jKeW84HDpEsHT9gEuUc0E4p0o5jAaLYFaxx6jdU9vCvftoKXMnTAtkLx8Y4/DgQN+RWhK5+i5ZP5f2rzP6kS9EXPCzu6Ilq564M37Czd1/qM96Wv18U+p3V0=; 7:fXy/lt6EkNszgcCpOSgqdKXgmEhMwljYVf2KQEWs/GO/bsC6dVYw2hJiy0sOi4pgi8ZbKWpst3m0rBF0m4F/QSHhZLR6gg3gOU1KOXs5nnYKKVDgy10e0AY1bPvOdr35gsQqPj/djMkioF6FN6qiDcTvQVGeg1lcdwAG7MOUL5G9AZuMdaySzmMv0Ar4W5ABQ/JkbOagNmVY6Hp1u6eBa/uoLFY2Mc2zUGISrfftjnRuP0WJ1uPF+zJqQyxLGGbi SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2018 12:19:18.0171 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa03f324-bea3-49b1-2955-08d62d184857 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4678 Subject: Re: [dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 12:19:26 -0000 On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote: > Some global variables are defined with generic names, add component name > as prefix to variables to prevent collusion with application variables. > > Signed-off-by: Ferruh Yigit > --- > drivers/bus/dpaa/include/fsl_fman_crc64.h | 8 ++-- [...] > > diff --git a/drivers/bus/dpaa/include/fsl_fman_crc64.h b/drivers/bus/dpaa/include/fsl_fman_crc64.h > index bf162f3ac..08ad63042 100644 > --- a/drivers/bus/dpaa/include/fsl_fman_crc64.h > +++ b/drivers/bus/dpaa/include/fsl_fman_crc64.h > @@ -42,9 +42,9 @@ struct fman_crc64_t { > uint64_t initial; > uint64_t table[1 << 8]; > }; > -extern struct fman_crc64_t FMAN_CRC64_ECMA_182; > +extern struct fman_crc64_t fman_crc64_ecma_182; > #define DECLARE_FMAN_CRC64_TABLE() \ > -struct fman_crc64_t FMAN_CRC64_ECMA_182 = { \ > +struct fman_crc64_t fman_crc64_ecma_182 = { \ > 0xFFFFFFFFFFFFFFFFULL, \ > { \ > 0x0000000000000000ULL, 0xb32e4cbe03a75f6fULL, \ > @@ -183,7 +183,7 @@ struct fman_crc64_t FMAN_CRC64_ECMA_182 = { \ > */ > static inline uint64_t fman_crc64_init(void) > { > - return FMAN_CRC64_ECMA_182.initial; > + return fman_crc64_ecma_182.initial; > } > > /* Updates the CRC with arbitrary data */ > @@ -192,7 +192,7 @@ static inline uint64_t fman_crc64_update(uint64_t crc, > { > uint8_t *p = data; > while (len--) > - crc = FMAN_CRC64_ECMA_182.table[(crc ^ *(p++)) & 0xff] ^ > + crc = fman_crc64_ecma_182.table[(crc ^ *(p++)) & 0xff] ^ > (crc >> 8); > return crc; > } [...] For the change above: Acked-by: Shreyansh Jain