From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E559A0597; Wed, 8 Apr 2020 18:15:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8E0F1C0DA; Wed, 8 Apr 2020 18:15:34 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 3734D1C0D7 for ; Wed, 8 Apr 2020 18:15:33 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200408161532euoutp01bc49d2d79f4498432653c015e6c5387d~D5FF0v58i0300103001euoutp01y for ; Wed, 8 Apr 2020 16:15:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200408161532euoutp01bc49d2d79f4498432653c015e6c5387d~D5FF0v58i0300103001euoutp01y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1586362532; bh=lPoZrjhagdAGnWFiDz23g2rYkaGeH8rTlfEg6MSzUNg=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=XGyxYU8VIJOLWVff3hQNpek70XjCgzqoOuw1BD2QbpEMCnSFUEaYgTZz8sXL0AYF6 Vv2/ecmOIeH4VG927NC1nMg/JPl2c14psYbojaNrrDWjwx2T/TvdCBr6/pLtDS1lX7 fKCbXGfOgrvjVJXv4mUTS85omDgDL36Pz1wYZkbY= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200408161532eucas1p23ae6b513665411815dd51e185921fa36~D5FFsxtTN3064230642eucas1p22; Wed, 8 Apr 2020 16:15:32 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 7D.A7.60698.4A8FD8E5; Wed, 8 Apr 2020 17:15:32 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200408161531eucas1p2596617e116809aa892f588dd1c9f427e~D5FFUqzj53064230642eucas1p2z; Wed, 8 Apr 2020 16:15:31 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200408161531eusmtrp10348f80ad3c496a10a37acee1528ea4b~D5FFUFsVa2179521795eusmtrp1D; Wed, 8 Apr 2020 16:15:31 +0000 (GMT) X-AuditID: cbfec7f5-a29ff7000001ed1a-9e-5e8df8a47091 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 82.D5.08375.3A8FD8E5; Wed, 8 Apr 2020 17:15:31 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200408161531eusmtip234bcbe83f68b7da23399a2ebad45b753~D5FE2R-st1138011380eusmtip2R; Wed, 8 Apr 2020 16:15:31 +0000 (GMT) To: Thomas Monjalon , Pavan Nikhilesh , Jerin Jacob Cc: dev@dpdk.org, stable@dpdk.org From: Lukasz Wojciechowski Message-ID: Date: Wed, 8 Apr 2020 18:15:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <9733532.nUPlyArG6x@thomas> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsWy7djP87pLfvTGGXxez2zx7tN2JouJk0ws Lq6zsPjX8Yfd4tODEywOrB4bTvSzevxasJTV49jNaewBzFFcNimpOZllqUX6dglcGdPWLGYs aOapmDrNsIHxKmcXIyeHhICJxJZ3T1m6GLk4hARWMEos/NrMDOF8YZT4sO84lPOZUaJ33wkm mJbZ97ZDJZYzSjx++pMVwnnLKHF7wzJ2kCphARuJzVu6GEFsEYE+Ron5+4VBbGYBRYm7K7+y gdhsArYSR2Z+ZQWxeQXcJPZ2d4H1sgioSKw4PAWsRlQgVuLcoxtQNYISJ2c+YQGxOQU0JE41 7mKDmCkv0bx1NjOELS5x68l8JpCDJAQms0ucWjiHDeJsF4k1e46yQ9jCEq+Ob4GyZSROT+5h gWjYxihx9fdPRghnP6PE9d4VUFXWEof//QaaxAG0QlNi/S59iLCjxJ/5x8HCEgJ8EjfeCkIc wScxadt0Zogwr0RHmxBEtZ7E056pjDBr/6x9wjKBUWkWktdmIXlnFpJ3ZiHsXcDIsopRPLW0 ODc9tdg4L7Vcrzgxt7g0L10vOT93EyMwtZz+d/zrDsZ9f5IOMQpwMCrx8B7Y0xsnxJpYVlyZ e4hRgoNZSYTXuwkoxJuSWFmVWpQfX1Sak1p8iFGag0VJnNd40ctYIYH0xJLU7NTUgtQimCwT B6dUA+O+rNmqMkdck1Vff+4LU1qjHfnO/068wMWn/OEvPOQ2CTz50KH8dK3Sn4SmJZbl9ezf 37gXyXKmGKVM7trAeJTbmMm8pePCSd93WpHOCln1r/NDs0SXbF6scrtYVfLXj4v5nhw7t9at uPiwvfSjppT3UeG4+gcLNnqFRX/W17SOuVnAvDH+mBJLcUaioRZzUXEiANFIYwEpAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsVy+t/xe7qLf/TGGbzdpWXx7tN2JouJk0ws Lq6zsPjX8Yfd4tODEywOrB4bTvSzevxasJTV49jNaewBzFF6NkX5pSWpChn5xSW2StGGFkZ6 hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6GdPWLGYsaOapmDrNsIHxKmcXIyeHhICJ xOx725m7GLk4hASWMkrc+7KWtYuRAyghI/HhkgBEjbDEn2tdbBA1rxkldi6+ygiSEBawkdi8 pYsRJCEi0Mco0Tl5OTNIgllAUeLuyq9sILaQwEdGiZdr1UBsNgFbiSMzv7KC2LwCbhJ7u7vY QWwWARWJFYengNWLCsRK9DfvZoSoEZQ4OfMJC4jNKaAhcapxFxvEfDOJeZsfQu2Sl2jeOhvK Fpe49WQ+0wRGoVlI2mchaZmFpGUWkpYFjCyrGEVSS4tz03OLDfWKE3OLS/PS9ZLzczcxAiNp 27Gfm3cwXtoYfIhRgINRiYf3wJ7eOCHWxLLiytxDjBIczEoivN5NQCHelMTKqtSi/Pii0pzU 4kOMpkDPTWSWEk3OB0Z5Xkm8oamhuYWlobmxubGZhZI4b4fAwRghgfTEktTs1NSC1CKYPiYO TqkGxrzPKwNTbs7rfP3ZxpPz/ekbf6ucFx7xKmbuSVGbmOb7KkR+SdPcaSZ/lEUebdli1pj5 TuW7p7AYf02x3NPg+RJbxbwN5MV0RaelvGB2W7PyRvD340ln/vaKliUwtZ6Q53m84PDc/pnp k+u69uvcODLvEN/sqWGyKutlIpuCWut3FKl+nxvyWomlOCPRUIu5qDgRAIDmWtu6AgAA X-CMS-MailID: 20200408161531eucas1p2596617e116809aa892f588dd1c9f427e X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200408031449eucas1p1ca89719463cbaf29e9f7c81beaec88c2 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200408031449eucas1p1ca89719463cbaf29e9f7c81beaec88c2 References: <20200312151654.7218-1-l.wojciechow@partner.samsung.com> <20200408031351.4288-5-l.wojciechow@partner.samsung.com> <9733532.nUPlyArG6x@thomas> Subject: Re: [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, Before my patch there was just a definition: #define RTE_TEST_TRACE_FAILURE TEST_TRACE_FAILURE without #ifndef condition. It caused a build problem to me when working on security test, which uses both rte_test.h and test.h As libraries should go first on the include list before local files I used: #include #include "test.h" sequence, which cause obvious build error as RTE_TEST_TRACE_FAILURE was first defined as an empty macro inside rte_test.h, and redefinition in test.h caused a problem. So I had two ways to solve the issue: 1) to wrap it with #ifndef condition and leave the definition there 2) to remove the redefinition from test.h I've chosen the 1) solution because: * Author of the former patch had placed the definition there for some purpose * In my opinion it is better to have the definition present and pointing to the same macro for both RTE_TEST_TRACE_FAILURE and TEST_TRACE_FAILURE as it would make logs look more consistent when printing information the same way. Best regards Lukasz W dniu 08.04.2020 o 14:53, Thomas Monjalon pisze: > 08/04/2020 05:13, Lukasz Wojciechowski: >> Wrap RTE_TEST_TRACE_FAILURE macro definition into #ifndef clause >> as it might be already defined. > I think it should not be defined at all. > Why not including rte_test.h? > > > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com