From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D022745697; Tue, 23 Jul 2024 18:04:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B860F427B7; Tue, 23 Jul 2024 18:04:42 +0200 (CEST) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id 2CFF442670 for ; Tue, 23 Jul 2024 18:04:40 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WT24775FBz6HJP4; Wed, 24 Jul 2024 00:03:03 +0800 (CST) Received: from frapeml100005.china.huawei.com (unknown [7.182.85.132]) by mail.maildlp.com (Postfix) with ESMTPS id D7678140B18; Wed, 24 Jul 2024 00:04:39 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100005.china.huawei.com (7.182.85.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 23 Jul 2024 18:04:39 +0200 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Tue, 23 Jul 2024 18:04:39 +0200 From: Konstantin Ananyev To: Aakash Sasidharan CC: "gakhil@marvell.com" , "jerinj@marvell.com" , "anoobj@marvell.com" , "vvelumuri@marvell.com" , "dev@dpdk.org" , "konstantin.v.ananyev@yandex.ru" , "vladimir.medvedkin@intel.com" Subject: RE: [PATCH v2] doc: announce rte_ipsec API changes Thread-Topic: [PATCH v2] doc: announce rte_ipsec API changes Thread-Index: AQHa3QWCQfapjcxCd02Y70ZuvvBjv7IEeVHA Date: Tue, 23 Jul 2024 16:04:39 +0000 Message-ID: References: <20240723130254.2128028-1-asasidharan@marvell.com> <20240723133706.2150828-1-asasidharan@marvell.com> In-Reply-To: <20240723133706.2150828-1-asasidharan@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.170.120] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > In case of event mode operations where event device can help in atomic > sequence number increment across cores, sequence number need to be > provided by the application instead of being updated in rte_ipsec or the > PMD. To support this, a new flag ``RTE_IPSEC_SAFLAG_SQN_ASSIGN_DISABLE`` > will be added to disable sequence number update inside IPsec library and > the API rte_ipsec_pkt_crypto_prepare will be extended to include ``sqn`` > as an additional parameter to specify sequence number to be used for > IPsec from the application. Could you probably elaborate a bit more: Why such change is necessary for event-dev mode, what exactly will be affected in librte_ipsec (would it be for outbound mode, or both), etc. =20 >=20 > Signed-off-by: Aakash Sasidharan > --- > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/= deprecation.rst > index 6948641ff6..bc1d93cca7 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -133,6 +133,13 @@ Deprecation Notices > Since these functions are not called directly by the application, > the API remains unaffected. >=20 > +* ipsec: The rte_ipsec library is updated to support sequence number pro= vided > + by application. A new flag ``RTE_IPSEC_SAFLAG_SQN_ASSIGN_DISABLE`` is = introduced > + to disable sequence number assignment in lib IPsec. > + The API rte_ipsec_pkt_crypto_prepare is extended to include ``sqn`` as= an > + additional parameter allowing application to specify the sequence numb= er to be > + used for the IPsec operation. > + > * pipeline: The pipeline library legacy API (functions rte_pipeline_*) > will be deprecated and subsequently removed in DPDK 24.11 release. > Before this, the new pipeline library API (functions rte_swx_pipeline_= *) > -- > 2.25.1