* [dpdk-dev] [PATCH] app/testpmd: enhance GTP support @ 2020-03-16 8:14 Dekel Peled 2020-03-24 9:58 ` Ori Kam 2020-03-25 8:12 ` [dpdk-dev] [PATCH v2] " Dekel Peled 0 siblings, 2 replies; 9+ messages in thread From: Dekel Peled @ 2020-03-16 8:14 UTC (permalink / raw) To: orika, wenzhuo.lu, jingjing.wu, bernard.iremonger; +Cc: matan, dev This patch adds CLI option to enter the v_pt_rsv_flags value for GTP flow pattern item. It also adds GTP as valid item in raw_encap nad raw_decap setting. Signed-off-by: Dekel Peled <dekelp@mellanox.com> --- app/test-pmd/cmdline_flow.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index a781545..cc1bd19 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -170,6 +170,7 @@ enum index { ITEM_FUZZY, ITEM_FUZZY_THRESH, ITEM_GTP, + ITEM_GTP_FLAGS, ITEM_GTP_MSG_TYPE, ITEM_GTP_TEID, ITEM_GTPC, @@ -938,6 +939,7 @@ struct parse_action_priv { }; static const enum index item_gtp[] = { + ITEM_GTP_FLAGS, ITEM_GTP_MSG_TYPE, ITEM_GTP_TEID, ITEM_NEXT, @@ -2347,6 +2349,13 @@ static int comp_set_raw_index(struct context *, const struct token *, .next = NEXT(item_gtp), .call = parse_vc, }, + [ITEM_GTP_FLAGS] = { + .name = "v_pt_rsv_flags", + .help = "GTP flags", + .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), item_param), + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, + v_pt_rsv_flags)), + }, [ITEM_GTP_MSG_TYPE] = { .name = "msg_type", .help = "GTP message type", @@ -6604,6 +6613,9 @@ static int comp_set_raw_index(struct context *, const struct token *, size = sizeof(struct rte_flow_item_ah); proto = 0x33; break; + case RTE_FLOW_ITEM_TYPE_GTP: + size = sizeof(struct rte_flow_item_gtp); + break; case RTE_FLOW_ITEM_TYPE_PFCP: size = sizeof(struct rte_flow_item_pfcp); break; -- 1.8.3.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support 2020-03-16 8:14 [dpdk-dev] [PATCH] app/testpmd: enhance GTP support Dekel Peled @ 2020-03-24 9:58 ` Ori Kam 2020-03-24 12:39 ` Dekel Peled 2020-03-25 8:12 ` [dpdk-dev] [PATCH v2] " Dekel Peled 1 sibling, 1 reply; 9+ messages in thread From: Ori Kam @ 2020-03-24 9:58 UTC (permalink / raw) To: Dekel Peled, wenzhuo.lu, jingjing.wu, bernard.iremonger; +Cc: Matan Azrad, dev Hi Dekel, > -----Original Message----- > Subject: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support > > This patch adds CLI option to enter the v_pt_rsv_flags value for GTP > flow pattern item. > It also adds GTP as valid item in raw_encap nad raw_decap setting. > > Signed-off-by: Dekel Peled <dekelp@mellanox.com> > --- > app/test-pmd/cmdline_flow.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index a781545..cc1bd19 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -170,6 +170,7 @@ enum index { > ITEM_FUZZY, > ITEM_FUZZY_THRESH, > ITEM_GTP, > + ITEM_GTP_FLAGS, > ITEM_GTP_MSG_TYPE, > ITEM_GTP_TEID, > ITEM_GTPC, > @@ -938,6 +939,7 @@ struct parse_action_priv { > }; > > static const enum index item_gtp[] = { > + ITEM_GTP_FLAGS, > ITEM_GTP_MSG_TYPE, > ITEM_GTP_TEID, > ITEM_NEXT, > @@ -2347,6 +2349,13 @@ static int comp_set_raw_index(struct context *, > const struct token *, > .next = NEXT(item_gtp), > .call = parse_vc, > }, > + [ITEM_GTP_FLAGS] = { > + .name = "v_pt_rsv_flags", > + .help = "GTP flags", > + .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > item_param), > + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, > + v_pt_rsv_flags)), V_pt_rsv_flags is 8 bits right? So why HTON? > + }, > [ITEM_GTP_MSG_TYPE] = { > .name = "msg_type", > .help = "GTP message type", > @@ -6604,6 +6613,9 @@ static int comp_set_raw_index(struct context *, > const struct token *, > size = sizeof(struct rte_flow_item_ah); > proto = 0x33; > break; > + case RTE_FLOW_ITEM_TYPE_GTP: > + size = sizeof(struct rte_flow_item_gtp); > + break; > case RTE_FLOW_ITEM_TYPE_PFCP: > size = sizeof(struct rte_flow_item_pfcp); > break; > -- > 1.8.3.1 Best, Ori ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support 2020-03-24 9:58 ` Ori Kam @ 2020-03-24 12:39 ` Dekel Peled 0 siblings, 0 replies; 9+ messages in thread From: Dekel Peled @ 2020-03-24 12:39 UTC (permalink / raw) To: Ori Kam, wenzhuo.lu, jingjing.wu, bernard.iremonger; +Cc: Matan Azrad, dev Hi, PSB. > -----Original Message----- > From: Ori Kam <orika@mellanox.com> > Sent: Tuesday, March 24, 2020 11:59 AM > To: Dekel Peled <dekelp@mellanox.com>; wenzhuo.lu@intel.com; > jingjing.wu@intel.com; bernard.iremonger@intel.com > Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support > > Hi Dekel, > > > -----Original Message----- > > Subject: [dpdk-dev] [PATCH] app/testpmd: enhance GTP support > > > > This patch adds CLI option to enter the v_pt_rsv_flags value for GTP > > flow pattern item. > > It also adds GTP as valid item in raw_encap nad raw_decap setting. > > > > Signed-off-by: Dekel Peled <dekelp@mellanox.com> > > --- > > app/test-pmd/cmdline_flow.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index a781545..cc1bd19 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -170,6 +170,7 @@ enum index { > > ITEM_FUZZY, > > ITEM_FUZZY_THRESH, > > ITEM_GTP, > > + ITEM_GTP_FLAGS, > > ITEM_GTP_MSG_TYPE, > > ITEM_GTP_TEID, > > ITEM_GTPC, > > @@ -938,6 +939,7 @@ struct parse_action_priv { }; > > > > static const enum index item_gtp[] = { > > + ITEM_GTP_FLAGS, > > ITEM_GTP_MSG_TYPE, > > ITEM_GTP_TEID, > > ITEM_NEXT, > > @@ -2347,6 +2349,13 @@ static int comp_set_raw_index(struct context *, > > const struct token *, > > .next = NEXT(item_gtp), > > .call = parse_vc, > > }, > > + [ITEM_GTP_FLAGS] = { > > + .name = "v_pt_rsv_flags", > > + .help = "GTP flags", > > + .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > > item_param), > > + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, > > + v_pt_rsv_flags)), > > V_pt_rsv_flags is 8 bits right? So why HTON? This is the common practice in this array, done for other uint8_t fields. > > > + }, > > [ITEM_GTP_MSG_TYPE] = { > > .name = "msg_type", > > .help = "GTP message type", > > @@ -6604,6 +6613,9 @@ static int comp_set_raw_index(struct context *, > > const struct token *, > > size = sizeof(struct rte_flow_item_ah); > > proto = 0x33; > > break; > > + case RTE_FLOW_ITEM_TYPE_GTP: > > + size = sizeof(struct rte_flow_item_gtp); > > + break; > > case RTE_FLOW_ITEM_TYPE_PFCP: > > size = sizeof(struct rte_flow_item_pfcp); > > break; > > -- > > 1.8.3.1 > > Best, > Ori ^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support 2020-03-16 8:14 [dpdk-dev] [PATCH] app/testpmd: enhance GTP support Dekel Peled 2020-03-24 9:58 ` Ori Kam @ 2020-03-25 8:12 ` Dekel Peled 2020-03-25 8:27 ` Ori Kam 1 sibling, 1 reply; 9+ messages in thread From: Dekel Peled @ 2020-03-25 8:12 UTC (permalink / raw) To: orika, wenzhuo.lu, jingjing.wu, bernard.iremonger; +Cc: matan, dev This patch adds CLI option to enter the v_pt_rsv_flags value for GTP flow pattern item. It also adds GTP as valid item in raw_encap and raw_decap setting. Signed-off-by: Dekel Peled <dekelp@mellanox.com> --- v2: remove redundant hton flag. --- app/test-pmd/cmdline_flow.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index a781545..4877ac6 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -170,6 +170,7 @@ enum index { ITEM_FUZZY, ITEM_FUZZY_THRESH, ITEM_GTP, + ITEM_GTP_FLAGS, ITEM_GTP_MSG_TYPE, ITEM_GTP_TEID, ITEM_GTPC, @@ -938,6 +939,7 @@ struct parse_action_priv { }; static const enum index item_gtp[] = { + ITEM_GTP_FLAGS, ITEM_GTP_MSG_TYPE, ITEM_GTP_TEID, ITEM_NEXT, @@ -2347,12 +2349,18 @@ static int comp_set_raw_index(struct context *, const struct token *, .next = NEXT(item_gtp), .call = parse_vc, }, + [ITEM_GTP_FLAGS] = { + .name = "v_pt_rsv_flags", + .help = "GTP flags", + .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), item_param), + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, + v_pt_rsv_flags)), + }, [ITEM_GTP_MSG_TYPE] = { .name = "msg_type", .help = "GTP message type", .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), item_param), - .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, - msg_type)), + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, msg_type)), }, [ITEM_GTP_TEID] = { .name = "teid", @@ -6604,6 +6612,9 @@ static int comp_set_raw_index(struct context *, const struct token *, size = sizeof(struct rte_flow_item_ah); proto = 0x33; break; + case RTE_FLOW_ITEM_TYPE_GTP: + size = sizeof(struct rte_flow_item_gtp); + break; case RTE_FLOW_ITEM_TYPE_PFCP: size = sizeof(struct rte_flow_item_pfcp); break; -- 1.8.3.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support 2020-03-25 8:12 ` [dpdk-dev] [PATCH v2] " Dekel Peled @ 2020-03-25 8:27 ` Ori Kam 2020-03-29 9:20 ` Dekel Peled 2020-04-06 15:41 ` Ferruh Yigit 0 siblings, 2 replies; 9+ messages in thread From: Ori Kam @ 2020-03-25 8:27 UTC (permalink / raw) To: Dekel Peled, wenzhuo.lu, jingjing.wu, bernard.iremonger; +Cc: Matan Azrad, dev > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled > Sent: Wednesday, March 25, 2020 10:13 AM > To: Ori Kam <orika@mellanox.com>; wenzhuo.lu@intel.com; > jingjing.wu@intel.com; bernard.iremonger@intel.com > Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support > > This patch adds CLI option to enter the v_pt_rsv_flags value for GTP > flow pattern item. > It also adds GTP as valid item in raw_encap and raw_decap setting. > > Signed-off-by: Dekel Peled <dekelp@mellanox.com> > --- > v2: remove redundant hton flag. > --- > app/test-pmd/cmdline_flow.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index a781545..4877ac6 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -170,6 +170,7 @@ enum index { > ITEM_FUZZY, > ITEM_FUZZY_THRESH, > ITEM_GTP, > + ITEM_GTP_FLAGS, > ITEM_GTP_MSG_TYPE, > ITEM_GTP_TEID, > ITEM_GTPC, > @@ -938,6 +939,7 @@ struct parse_action_priv { > }; > > static const enum index item_gtp[] = { > + ITEM_GTP_FLAGS, > ITEM_GTP_MSG_TYPE, > ITEM_GTP_TEID, > ITEM_NEXT, > @@ -2347,12 +2349,18 @@ static int comp_set_raw_index(struct context *, > const struct token *, > .next = NEXT(item_gtp), > .call = parse_vc, > }, > + [ITEM_GTP_FLAGS] = { > + .name = "v_pt_rsv_flags", > + .help = "GTP flags", > + .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > item_param), > + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, > + v_pt_rsv_flags)), > + }, > [ITEM_GTP_MSG_TYPE] = { > .name = "msg_type", > .help = "GTP message type", > .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > item_param), > - .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, > - msg_type)), > + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, > msg_type)), > }, > [ITEM_GTP_TEID] = { > .name = "teid", > @@ -6604,6 +6612,9 @@ static int comp_set_raw_index(struct context *, > const struct token *, > size = sizeof(struct rte_flow_item_ah); > proto = 0x33; > break; > + case RTE_FLOW_ITEM_TYPE_GTP: > + size = sizeof(struct rte_flow_item_gtp); > + break; > case RTE_FLOW_ITEM_TYPE_PFCP: > size = sizeof(struct rte_flow_item_pfcp); > break; > -- > 1.8.3.1 Acked-by: Ori Kam <orika@mellanox.com> Thanks, Ori ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support 2020-03-25 8:27 ` Ori Kam @ 2020-03-29 9:20 ` Dekel Peled 2020-04-06 11:05 ` Dekel Peled 2020-04-06 15:41 ` Ferruh Yigit 1 sibling, 1 reply; 9+ messages in thread From: Dekel Peled @ 2020-03-29 9:20 UTC (permalink / raw) To: wenzhuo.lu, jingjing.wu, bernard.iremonger; +Cc: Matan Azrad, dev, Ori Kam Hi, Can this patch be applied? Regards, Dekel > -----Original Message----- > From: Ori Kam <orika@mellanox.com> > Sent: Wednesday, March 25, 2020 10:28 AM > To: Dekel Peled <dekelp@mellanox.com>; wenzhuo.lu@intel.com; > jingjing.wu@intel.com; bernard.iremonger@intel.com > Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support > > > > > -----Original Message----- > > From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled > > Sent: Wednesday, March 25, 2020 10:13 AM > > To: Ori Kam <orika@mellanox.com>; wenzhuo.lu@intel.com; > > jingjing.wu@intel.com; bernard.iremonger@intel.com > > Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support > > > > This patch adds CLI option to enter the v_pt_rsv_flags value for GTP > > flow pattern item. > > It also adds GTP as valid item in raw_encap and raw_decap setting. > > > > Signed-off-by: Dekel Peled <dekelp@mellanox.com> > > --- > > v2: remove redundant hton flag. > > --- > > app/test-pmd/cmdline_flow.c | 15 +++++++++++++-- > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index a781545..4877ac6 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -170,6 +170,7 @@ enum index { > > ITEM_FUZZY, > > ITEM_FUZZY_THRESH, > > ITEM_GTP, > > + ITEM_GTP_FLAGS, > > ITEM_GTP_MSG_TYPE, > > ITEM_GTP_TEID, > > ITEM_GTPC, > > @@ -938,6 +939,7 @@ struct parse_action_priv { }; > > > > static const enum index item_gtp[] = { > > + ITEM_GTP_FLAGS, > > ITEM_GTP_MSG_TYPE, > > ITEM_GTP_TEID, > > ITEM_NEXT, > > @@ -2347,12 +2349,18 @@ static int comp_set_raw_index(struct context > > *, const struct token *, > > .next = NEXT(item_gtp), > > .call = parse_vc, > > }, > > + [ITEM_GTP_FLAGS] = { > > + .name = "v_pt_rsv_flags", > > + .help = "GTP flags", > > + .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > > item_param), > > + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, > > + v_pt_rsv_flags)), > > + }, > > [ITEM_GTP_MSG_TYPE] = { > > .name = "msg_type", > > .help = "GTP message type", > > .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > item_param), > > - .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, > > - msg_type)), > > + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, > > msg_type)), > > }, > > [ITEM_GTP_TEID] = { > > .name = "teid", > > @@ -6604,6 +6612,9 @@ static int comp_set_raw_index(struct context *, > > const struct token *, > > size = sizeof(struct rte_flow_item_ah); > > proto = 0x33; > > break; > > + case RTE_FLOW_ITEM_TYPE_GTP: > > + size = sizeof(struct rte_flow_item_gtp); > > + break; > > case RTE_FLOW_ITEM_TYPE_PFCP: > > size = sizeof(struct rte_flow_item_pfcp); > > break; > > -- > > 1.8.3.1 > > Acked-by: Ori Kam <orika@mellanox.com> > Thanks, > Ori ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support 2020-03-29 9:20 ` Dekel Peled @ 2020-04-06 11:05 ` Dekel Peled 2020-04-06 11:16 ` Ferruh Yigit 0 siblings, 1 reply; 9+ messages in thread From: Dekel Peled @ 2020-04-06 11:05 UTC (permalink / raw) To: wenzhuo.lu, jingjing.wu, bernard.iremonger, ferruh.yigit Cc: Matan Azrad, dev, Ori Kam Hi Ferruh, Is this patch ready to be applied in next-net? Regards, Dekel > -----Original Message----- > From: Dekel Peled <dekelp@mellanox.com> > Sent: Sunday, March 29, 2020 12:21 PM > To: wenzhuo.lu@intel.com; jingjing.wu@intel.com; > bernard.iremonger@intel.com > Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org; Ori Kam > <orika@mellanox.com> > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support > > Hi, > > Can this patch be applied? > > Regards, > Dekel > > > -----Original Message----- > > From: Ori Kam <orika@mellanox.com> > > Sent: Wednesday, March 25, 2020 10:28 AM > > To: Dekel Peled <dekelp@mellanox.com>; wenzhuo.lu@intel.com; > > jingjing.wu@intel.com; bernard.iremonger@intel.com > > Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support > > > > > > > > > -----Original Message----- > > > From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled > > > Sent: Wednesday, March 25, 2020 10:13 AM > > > To: Ori Kam <orika@mellanox.com>; wenzhuo.lu@intel.com; > > > jingjing.wu@intel.com; bernard.iremonger@intel.com > > > Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support > > > > > > This patch adds CLI option to enter the v_pt_rsv_flags value for GTP > > > flow pattern item. > > > It also adds GTP as valid item in raw_encap and raw_decap setting. > > > > > > Signed-off-by: Dekel Peled <dekelp@mellanox.com> > > > --- > > > v2: remove redundant hton flag. > > > --- > > > app/test-pmd/cmdline_flow.c | 15 +++++++++++++-- > > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > > > diff --git a/app/test-pmd/cmdline_flow.c > > > b/app/test-pmd/cmdline_flow.c index a781545..4877ac6 100644 > > > --- a/app/test-pmd/cmdline_flow.c > > > +++ b/app/test-pmd/cmdline_flow.c > > > @@ -170,6 +170,7 @@ enum index { > > > ITEM_FUZZY, > > > ITEM_FUZZY_THRESH, > > > ITEM_GTP, > > > + ITEM_GTP_FLAGS, > > > ITEM_GTP_MSG_TYPE, > > > ITEM_GTP_TEID, > > > ITEM_GTPC, > > > @@ -938,6 +939,7 @@ struct parse_action_priv { }; > > > > > > static const enum index item_gtp[] = { > > > + ITEM_GTP_FLAGS, > > > ITEM_GTP_MSG_TYPE, > > > ITEM_GTP_TEID, > > > ITEM_NEXT, > > > @@ -2347,12 +2349,18 @@ static int comp_set_raw_index(struct context > > > *, const struct token *, > > > .next = NEXT(item_gtp), > > > .call = parse_vc, > > > }, > > > + [ITEM_GTP_FLAGS] = { > > > + .name = "v_pt_rsv_flags", > > > + .help = "GTP flags", > > > + .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > > > item_param), > > > + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, > > > + v_pt_rsv_flags)), > > > + }, > > > [ITEM_GTP_MSG_TYPE] = { > > > .name = "msg_type", > > > .help = "GTP message type", > > > .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), > > item_param), > > > - .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, > > > - msg_type)), > > > + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, > > > msg_type)), > > > }, > > > [ITEM_GTP_TEID] = { > > > .name = "teid", > > > @@ -6604,6 +6612,9 @@ static int comp_set_raw_index(struct context > > > *, const struct token *, > > > size = sizeof(struct rte_flow_item_ah); > > > proto = 0x33; > > > break; > > > + case RTE_FLOW_ITEM_TYPE_GTP: > > > + size = sizeof(struct rte_flow_item_gtp); > > > + break; > > > case RTE_FLOW_ITEM_TYPE_PFCP: > > > size = sizeof(struct rte_flow_item_pfcp); > > > break; > > > -- > > > 1.8.3.1 > > > > Acked-by: Ori Kam <orika@mellanox.com> Thanks, Ori ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support 2020-04-06 11:05 ` Dekel Peled @ 2020-04-06 11:16 ` Ferruh Yigit 0 siblings, 0 replies; 9+ messages in thread From: Ferruh Yigit @ 2020-04-06 11:16 UTC (permalink / raw) To: Dekel Peled, wenzhuo.lu, jingjing.wu, bernard.iremonger Cc: Matan Azrad, dev, Ori Kam On 4/6/2020 12:05 PM, Dekel Peled wrote: > Hi Ferruh, > > Is this patch ready to be applied in next-net? Hi Dekel, Most probably I can check it today.. > > Regards, > Dekel > >> -----Original Message----- >> From: Dekel Peled <dekelp@mellanox.com> >> Sent: Sunday, March 29, 2020 12:21 PM >> To: wenzhuo.lu@intel.com; jingjing.wu@intel.com; >> bernard.iremonger@intel.com >> Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org; Ori Kam >> <orika@mellanox.com> >> Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support >> >> Hi, >> >> Can this patch be applied? >> >> Regards, >> Dekel >> >>> -----Original Message----- >>> From: Ori Kam <orika@mellanox.com> >>> Sent: Wednesday, March 25, 2020 10:28 AM >>> To: Dekel Peled <dekelp@mellanox.com>; wenzhuo.lu@intel.com; >>> jingjing.wu@intel.com; bernard.iremonger@intel.com >>> Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org >>> Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support >>> >>> >>> >>>> -----Original Message----- >>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled >>>> Sent: Wednesday, March 25, 2020 10:13 AM >>>> To: Ori Kam <orika@mellanox.com>; wenzhuo.lu@intel.com; >>>> jingjing.wu@intel.com; bernard.iremonger@intel.com >>>> Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org >>>> Subject: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support >>>> >>>> This patch adds CLI option to enter the v_pt_rsv_flags value for GTP >>>> flow pattern item. >>>> It also adds GTP as valid item in raw_encap and raw_decap setting. >>>> >>>> Signed-off-by: Dekel Peled <dekelp@mellanox.com> >>>> --- >>>> v2: remove redundant hton flag. >>>> --- >>>> app/test-pmd/cmdline_flow.c | 15 +++++++++++++-- >>>> 1 file changed, 13 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/app/test-pmd/cmdline_flow.c >>>> b/app/test-pmd/cmdline_flow.c index a781545..4877ac6 100644 >>>> --- a/app/test-pmd/cmdline_flow.c >>>> +++ b/app/test-pmd/cmdline_flow.c >>>> @@ -170,6 +170,7 @@ enum index { >>>> ITEM_FUZZY, >>>> ITEM_FUZZY_THRESH, >>>> ITEM_GTP, >>>> + ITEM_GTP_FLAGS, >>>> ITEM_GTP_MSG_TYPE, >>>> ITEM_GTP_TEID, >>>> ITEM_GTPC, >>>> @@ -938,6 +939,7 @@ struct parse_action_priv { }; >>>> >>>> static const enum index item_gtp[] = { >>>> + ITEM_GTP_FLAGS, >>>> ITEM_GTP_MSG_TYPE, >>>> ITEM_GTP_TEID, >>>> ITEM_NEXT, >>>> @@ -2347,12 +2349,18 @@ static int comp_set_raw_index(struct context >>>> *, const struct token *, >>>> .next = NEXT(item_gtp), >>>> .call = parse_vc, >>>> }, >>>> + [ITEM_GTP_FLAGS] = { >>>> + .name = "v_pt_rsv_flags", >>>> + .help = "GTP flags", >>>> + .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), >>>> item_param), >>>> + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, >>>> + v_pt_rsv_flags)), >>>> + }, >>>> [ITEM_GTP_MSG_TYPE] = { >>>> .name = "msg_type", >>>> .help = "GTP message type", >>>> .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), >>> item_param), >>>> - .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, >>>> - msg_type)), >>>> + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, >>>> msg_type)), >>>> }, >>>> [ITEM_GTP_TEID] = { >>>> .name = "teid", >>>> @@ -6604,6 +6612,9 @@ static int comp_set_raw_index(struct context >>>> *, const struct token *, >>>> size = sizeof(struct rte_flow_item_ah); >>>> proto = 0x33; >>>> break; >>>> + case RTE_FLOW_ITEM_TYPE_GTP: >>>> + size = sizeof(struct rte_flow_item_gtp); >>>> + break; >>>> case RTE_FLOW_ITEM_TYPE_PFCP: >>>> size = sizeof(struct rte_flow_item_pfcp); >>>> break; >>>> -- >>>> 1.8.3.1 >>> >>> Acked-by: Ori Kam <orika@mellanox.com> Thanks, Ori ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support 2020-03-25 8:27 ` Ori Kam 2020-03-29 9:20 ` Dekel Peled @ 2020-04-06 15:41 ` Ferruh Yigit 1 sibling, 0 replies; 9+ messages in thread From: Ferruh Yigit @ 2020-04-06 15:41 UTC (permalink / raw) To: Ori Kam, Dekel Peled, wenzhuo.lu, jingjing.wu, bernard.iremonger Cc: Matan Azrad, dev On 3/25/2020 8:27 AM, Ori Kam wrote: > > >> -----Original Message----- >> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled >> Sent: Wednesday, March 25, 2020 10:13 AM >> To: Ori Kam <orika@mellanox.com>; wenzhuo.lu@intel.com; >> jingjing.wu@intel.com; bernard.iremonger@intel.com >> Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support >> >> This patch adds CLI option to enter the v_pt_rsv_flags value for GTP >> flow pattern item. >> It also adds GTP as valid item in raw_encap and raw_decap setting. >> >> Signed-off-by: Dekel Peled <dekelp@mellanox.com> > > Acked-by: Ori Kam <orika@mellanox.com> Applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-04-06 15:42 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-16 8:14 [dpdk-dev] [PATCH] app/testpmd: enhance GTP support Dekel Peled 2020-03-24 9:58 ` Ori Kam 2020-03-24 12:39 ` Dekel Peled 2020-03-25 8:12 ` [dpdk-dev] [PATCH v2] " Dekel Peled 2020-03-25 8:27 ` Ori Kam 2020-03-29 9:20 ` Dekel Peled 2020-04-06 11:05 ` Dekel Peled 2020-04-06 11:16 ` Ferruh Yigit 2020-04-06 15:41 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).