From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DEC4A00C5; Mon, 14 Feb 2022 14:36:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CD514113F; Mon, 14 Feb 2022 14:36:59 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 38FA24067E for ; Mon, 14 Feb 2022 14:36:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644845817; x=1676381817; h=message-id:date:to:references:from:subject:in-reply-to: content-transfer-encoding:mime-version; bh=QJPLoGJ/PfSd4Wa2GyLjw6jR3mz0YPYeOYR/Qwjs+aU=; b=MfSdU0ngNHTKuofVeQEgF0Nnz0BB6Lz8Ee6wI8/zEm8oxqltvnCArccv bAGLWz95Aaa1KOQPH682kuiGpW+stoIg/4g/qQKniEl5GftcSU8p+Xj1r nJrgOkXSoXJ3QsiMuBrnRBrU78NwG3PMUiMMNZ7Xo3N6nnz8696G730kH C9Ne87iaC9qknnWW9ksoalfBF5O++96fvc3s1PM0RzwY9+ZM8+buPe2BM kV6xXkDgGRCiZcnCWT9ljIcpialLl4IEwB52fPEyICbWMBRl/B9O+d9Ju p9RMVZDRkCKjecN+oZE40/1wBzF1669dBqkzKt5T2pem6YNl2lLRda+FU A==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="249837360" X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="249837360" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 05:36:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="635197278" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 14 Feb 2022 05:36:56 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 05:36:55 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 05:36:55 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 14 Feb 2022 05:36:55 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 14 Feb 2022 05:36:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dUQsRu8JJWiIMwg7siYXFRbDlrspOzgWfyq8fcqBncR2KmCWPVYaw84Wx+SINl0znjUbtQtk5jiq7XI8KBloqgW3qZJppLdU3AnK0IHBUY9lvMejJb5eCcIyL2vQxLBj+ednz8YKlXwj56QwWVZkYjbMU7Ms3uFrVDs/3Ru+L3qBQ715SKiAYBSAEFBqKuPFwTrrwgAOHLK4kjM4CPpLxEMKYcOWIk0w3SCmzb7cgNLZV8C8yCQll0MbrRY0bqx77Zi6bXqmtb/wj78XoxyAc6tQJygv9zYVSraGAejqy1dDM2keE2NcPrbOs8LqTrKFr7FCSz4CCQ9fsxOYKinhRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2yPa0rntaoVQBrqFKYdyoBKAhkkVtt1Zav2wWm7dof8=; b=E7ia3kt1Ey14lBJNhVIiPdzshS2Uhj/3M19ft0Bj8GWd8Ba4/h2VLQaNZ6GmHz/WJmUF5QIR60KgtAXm4IQWLuniDE3ib61MUhr0JOV8BYFSNUKbPxHxOCQ3D/vkev3h60KPlOgb6wAlKIZlm5Qoc638eTSO2dKtk/B0zZm8VJvMobyuJZPTP673tnhyC5R9DYaByZ+tbcs7nKiXi4YFcj36yu8k39s/OyHP2Y4wRz/kJf+XHSo8AhFM/nimA38WB897DKY6o23ppkJeYIt3D0bDnfcTpWtOJkiipPGGDngkXyED+YrPxiGkJOJxTYcladPgv8/g8m8onrw0AVd6HQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN7PR11MB2820.namprd11.prod.outlook.com (2603:10b6:406:b5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb 2022 13:36:53 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Mon, 14 Feb 2022 13:36:53 +0000 Message-ID: Date: Mon, 14 Feb 2022 13:36:49 +0000 Content-Language: en-US To: , References: <20220214112541.29782-1-spinler@cesnet.cz> From: Ferruh Yigit Subject: Re: [PATCH 1/6] net/nfb: add missing libfdt dependency for build X-User: ferruhy In-Reply-To: <20220214112541.29782-1-spinler@cesnet.cz> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0288.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::36) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e491c15e-0dda-4c6c-8ff3-08d9efbf0ffe X-MS-TrafficTypeDiagnostic: BN7PR11MB2820:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2089; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kicg/Ji1vkjxCDD3xHzCu081i+7jev+FIsHdf3ffv/92aLvOpmrm11qMdKHYOy5YbvxL/3QcTbyGvaXYtd/bmBpA1PksYdRFlcZVQAdZlUtL016VUXU2k/yB0jW9EbqDrCeIejgXHXhX2ZnWn/p34ryNoWxb5UHR7CkLldUXYbe5uQ0krMF/paWGT5vs1riN4gttKA9lx18aYiYzq2qkhgg2zDxlo7NYfjOGM44r6+iKEdv6jbhqiB7PPVx20yD4ZqLa0z/lQhiqBO7KIdFGVLaWM+YsEtX5YKkFSHMrM00Wxj3JfzSl2n4Ga6xWmSnI0phwU+E906I4D5PMOGtjSqARZ3sIJAXQAKq726dDSQzS1VXkyou2eUqBRhPhp5FtAczxJKwxmnrZJ0W13GZ106O++o5lHhRO7gk+iSPDXFSs6Qh+b4v1832m/CAm7lOPbwWvhl9x5SKSasI2b5QIiNmgJ7ZXriK+BiDuVlB0vbVsQvZMvfFjNQT9+hpoNKkjvlY5aSXaHfDXftBhPReRD5cBkp0zJxAEupR5McSTQdifT8JqqApMXxYaC41iP5LFPneU91pxRvverEigzdA6Qw5EbheBOxlvKwKCXIshq3udnx9d7LTZeqtpOqqhqNI+wfFs6tKySY39vyUDAt3kY7pBus66raEnNrg8Zw8hrE4kCcp0VRNhLW56h2NFThzPoBkZImOo4iTbZL7sZm6vkQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(31696002)(82960400001)(38100700002)(316002)(5660300002)(8936002)(8676002)(6486002)(44832011)(66946007)(2906002)(66556008)(66476007)(2616005)(6512007)(26005)(186003)(36756003)(6666004)(53546011)(6506007)(31686004)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c05hQnJOSURPNG94WU1oU1dnZkI3R1RwYi85Z1AzenJ2Y3NQQ2M1SHNWdXFZ?= =?utf-8?B?N2Y1bHVlRlBaQkJLM2IvOVhkK1AzOFM4SW1kdFZEWUlzMnBKUGlBYVJ1TW5m?= =?utf-8?B?RHdmUno5VkVwc0d1dGZKUWljNWlpK0VnOFZibXBUaDlBMVNkV0dhU1NsUWdI?= =?utf-8?B?ajdCU1c1SWdIVnMxQmRIa0ZyRStaU3NpcXBpcWtwTU95L2tzT1h0YzVOOWI0?= =?utf-8?B?UUNkMUZoSms0bHptWGFkRWZtSHBNOW1lTEtTOTE4K0ZiV1BkNjRPVmZpRVJw?= =?utf-8?B?cGNRSUZlT3dUVlZqSjFtcmNHTnJac1NPQmFpMFFJc0ZsUURMUnIycXBBNWdB?= =?utf-8?B?dkV4K1Bzc0lYVGNKbmd4NzVMbnNaMzZaYVdwV0pWWVE2WERsS2Frc2sxdUxC?= =?utf-8?B?TTlSa2lYeHhZeUJXMnkwQkU0WkY2MnhybGxjMGQxZEVKd2pHSm5BKzBQN0dz?= =?utf-8?B?YnhDcW5jbkJGS3ppUUIyeGJIaEVmYk90RGU1WVY4N0w0N1NQN0lSSGNJeWpK?= =?utf-8?B?aTI5YWFJTkY1UEtPdG1hOVFKTWo1bE40TVcvSGhzUmJwNHpGb1FZYW0yemhT?= =?utf-8?B?Q1lFUnZ2MzMyMzlNK3FtZDJQb0NKQ2ZsZzMxcUNkaHYyUGJBRDF3SnNJMko4?= =?utf-8?B?cVNLTWNJTXA0NkhpVzlCM0ZPZFl0RThjdU5jc2ZYTWZvbVU1TzY1NVBoNE9V?= =?utf-8?B?YWFZTEI5dk41U3hvVFk5WjBJVWw3aEhtQVkvMkY5MTFTUnkybjY3dXp0TWZh?= =?utf-8?B?RlNUSUFYV3Y4VkU1TEw4U1NjR1NrYm03NmdieEgxNi8wRC96VWRkUUJDZE5q?= =?utf-8?B?WlJaMjIzaXF6cVhkL3NvUnFLU2JEemVuelJlMmVTNFQ5OTA3TUFjbms3c1hy?= =?utf-8?B?cWtYb2VGVmNpOFJwcU9ISTBiUUpCM3plOWJIM3B1b1NrNHhPeFpuMmJvK3Fy?= =?utf-8?B?bXhDN3NUOTMrUWloVHVRdXpSRVBMbDI0dWJVUTU3N3VSZGFDc2xyWUptWmZh?= =?utf-8?B?OVRQTG0yZjZiQlhWbmdMRTQ5ajczdjF2WERhWlZ1amhXRnBOdzVTY3J5MXdh?= =?utf-8?B?L2lkMjc5R09zWGtiZDJ3SzJUb3ZVakVMcW1kazZiQzRFTXFReDRVWWdTalRJ?= =?utf-8?B?MldwbEZYZUlDanRuUlR4V0RlUlZtZWwxT3ZlTnM4VytRc2VhcVUveW4wWHV0?= =?utf-8?B?RTBGd3QyenlUWWptUHRkQTY2bkI3M2RnMGd5NzVRVE0vRnNhc05IZDJvSlVZ?= =?utf-8?B?U3RKVHlzbnFvNGVxOC9RYnE2ZmZCSWtSWURNUmNYWm1HdTVxS2ZxMkZKTDVU?= =?utf-8?B?YjNXeUJtbDRyb1l0bE91ZE4vTDByNjFpSVhjVVk1NERkWVhrbHZiOUpmVlhh?= =?utf-8?B?TDNJa2x1Q1hxSlZvNWFETGhPeDNTdlJuOXZOdUZHQzk1RlZlTkNnUCsvcnRo?= =?utf-8?B?RmdyT3h3dXpGZzBpNXdWeDlkQVlrV1hmQWtBdlhOTnNnUExqdEJlNUg2c3pS?= =?utf-8?B?MFZRRCtkSkxpRTltdUhpeDBXaWYydU14TzNhOTZoSHg1UFpURERWUEJTMEZx?= =?utf-8?B?bWZiWlFyODRkOVFhZzlJczQ1blVIZWQ3WVZTamZMMHJxekR2Qkc3bmlGVksy?= =?utf-8?B?VVg5TVcycE1hZkRRS3NzTHNzdEE1WlpQTU03SWNTQWd1NGxkOG9IMUJZOExO?= =?utf-8?B?NFM1WjJCTXJnODlDdmxMVllZdjA3bmhGTEdoeTJRTXFKNjl3bDRoOWE0c01x?= =?utf-8?B?TjNZYkdPc0VtcGV1bTVDWlNnTW96cHdMWmxsTlRpZk5yK0VUUTZmbUNRVlBO?= =?utf-8?B?RzNvU1REamlwMWtQQldXWTdUZFpDbkpwYnpiVi9uQmVhWndiQkhpZkhuM0xM?= =?utf-8?B?a2I1bnd1TDNYcnJUanhjZ1B5NHFRRjBTamZIalMvR2t3VlJKNzF5NWRwQXNC?= =?utf-8?B?RjIzaWY3anNFL0FETnZkOXYxbkN2a2JGUnoraWRad0k1bUtiUDRhQW9hUGha?= =?utf-8?B?WnZyQ0pRYzlONURTSUxUYXVqOVJzMjNhK2F1TXZMVWZOWmhGdHJ6akx4SEpy?= =?utf-8?B?U3hGWmdHY3FjY09QNGZ4eWVWQk4yb0NLb2dOQ0h2OThqdW1GWDdDM29ZdHlm?= =?utf-8?B?WHhkcSthcUMvdmVlMERpa09YV0NyQlJOUFk0aXVuWW96VWZsUCtrUVJlRDBB?= =?utf-8?Q?Xsxt6Gw9yg48TQyZuQltDrg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e491c15e-0dda-4c6c-8ff3-08d9efbf0ffe X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:36:53.7968 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UgbXp9VsJAOdGbRN/+ML+/4vXwM49PlcUJgk9irBo9aiHnrbjyGOqTJEsEH4OmnbddUmi9poi7mo944or4WqIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2820 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/14/2022 11:25 AM, spinler@cesnet.cz wrote: > From: Martin Spinler > > The driver uses some FDT manipulation functions from libfdt. > Let the build system check for libfdt package. > I don't see 'libfdt.h' included by the driver, where/how libfdt is used? Also what do you think to document this external dependency and its usage in the driver documentation? > Signed-off-by: Martin Spinler > --- > drivers/net/nfb/meson.build | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/nfb/meson.build b/drivers/net/nfb/meson.build > index bb5f66a09a..c080c06bf9 100644 > --- a/drivers/net/nfb/meson.build > +++ b/drivers/net/nfb/meson.build > @@ -9,6 +9,12 @@ if is_windows > subdir_done() > endif > > +if has_libfdt == 0 > + build = false > + reason = 'missing dependency, "libfdt"' > + subdir_done() > +endif > + > dep = dependency('netcope-common', required: false, method: 'pkg-config') > reason = 'missing dependency, "libnfb"' > build = dep.found()