From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4CD1A0C4E; Tue, 2 Nov 2021 19:02:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C1774069F; Tue, 2 Nov 2021 19:02:55 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 012F040689 for <dev@dpdk.org>; Tue, 2 Nov 2021 19:02:53 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="317535149" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="317535149" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 11:02:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="497282757" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 02 Nov 2021 11:02:51 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 11:02:51 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 11:02:51 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 11:02:51 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 11:02:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VTqlSMqPat17aHTWr1FUCLeIm+nL+BVQ3DqsNndkWIpleT5Le1rwAGu028K7soco+0e/LDWziZtsIzQZXS7MawP16R0bWEHPgZl7eVLUaKI4+RbeiRHP/lv8ZATlvn+BySBm5BVwFS1+T27iLlzDAJlbMxMv/f++PgNVKAvWk271AVYr379H0EzJyXq2PCjasM0eooCo4cfLe3FYpSzSmODk1MvDSkFdTBZgeBW+1D+D3oQV0oRPU1n5ea34VGXDsV0cwW8+55TiGoZ5fhhekw2pFIfFERUnFeAQaQJGDIo6fMtDGuulZRpIaEZNK82yuMIrzW5Q1wyBnoRDUQbNIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mMBQUYEcTrcCzU5OrkNbNi4hte/rEpFM7z4m+1nZqeE=; b=GZl7BIIB5sCdnLsMYoWdlOIADSqt+6/a+sN8pBWv8olvALns1/I+pEBUR5rM7cxoi9amJK7Q+aHon0obD0n3LKzXXeyHnoBA4mXSdB0gPfh/jqJKjQbOxS9W4+EuBf6sA/5uHwnrHKbJRiW2p6SY4e1EUdlAv+lShho6wVSI7ZqKuz/apmar+Z5fuJD2UdRI2eOKQA3vToZsPXjy0X7fvp9xaBVKZDHDIBoHG4YrZhjMcURXIVv7NPafdwGIJbsxZkbldtT8fjwkoXGqhF46MFA3S7gbTc3vRQQ0h0qutmjKXR8ZlInOencGtR/hdbCZT3eDs1Ig0KxbK8W/xgKuAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mMBQUYEcTrcCzU5OrkNbNi4hte/rEpFM7z4m+1nZqeE=; b=uxZ2KWDYzoWYegbhcz1VALS9WbZ0c7LQ69PazURjSU7jJG7wrUbBd4XBcygmntMzzcxLjqnhLtD6xTGM0rd6OGP7TNlsUg7OXhpTUpkSKOQ8fN8KMFckMCyla76EjXgngPlbsY6DTPDN00nT3utpUHEovLMQQlKvhmubCF58DTI= Authentication-Results: oss.nvidia.com; dkim=none (message not signed) header.d=none;oss.nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4920.namprd11.prod.outlook.com (2603:10b6:510:41::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov 2021 18:02:50 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.020; Tue, 2 Nov 2021 18:02:50 +0000 Message-ID: <fadda45b-04d8-8560-36c2-708e0f691f17@intel.com> Date: Tue, 2 Nov 2021 18:02:43 +0000 Content-Language: en-US To: Dmitry Kozlyuk <dkozlyuk@oss.nvidia.com>, <dev@dpdk.org> References: <20211102135415.944050-1-dkozlyuk@nvidia.com> <20211102170135.959380-1-dkozlyuk@nvidia.com> From: Ferruh Yigit <ferruh.yigit@intel.com> X-User: ferruhy In-Reply-To: <20211102170135.959380-1-dkozlyuk@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0201CA0007.eurprd02.prod.outlook.com (2603:10a6:4:3f::17) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0201CA0007.eurprd02.prod.outlook.com (2603:10a6:4:3f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Tue, 2 Nov 2021 18:02:48 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 61a4b4e6-3c6a-4c81-4e3f-08d99e2afb8e X-MS-TrafficTypeDiagnostic: PH0PR11MB4920: X-Microsoft-Antispam-PRVS: <PH0PR11MB492089C1BEE3170A19104768958B9@PH0PR11MB4920.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J1YkHpm1JiPFqhpx7F7svcaZvZo9S6p2YkwK4o4f2XfhKy0rQS4CWvV25YyVdgeSJ47ccn+869IdEomFgn42mbhPl9V1BIt7TTQLP38wKK2V6tdFPf9fGV9Yldtk6EMmLSCCeVm9zs5dfi4dtJnTNZhGD7ltMOkIWLZXdlQwcf+bbV9z/X1x3OWgDSteDQptO/dYi7HqCn69FIFZtixLGu5/h7bUgJ9m17CU67QTlRPaYHp3s8UIh+t9fqfbXsgjgjKVHr6dapb1iAzga2qHJbIPzsqPKwECPI7flzB09xb8/Gd29A4Gin6w+vuAgZRv6OPTyjzNQGvETCUXJQCfWkD0/1kLzhBcLdIA7aE/QpbhGmydx8JqOnoJq7433wCVzQHpAG5HnyX15Kwb3Cfb7xjPMOCrB33YHqzOLcHV97pThZaIiTRZB6WuBrVqOhgjRUFhcOl+XduNtiekonoXsBEne33tB9oncVJZoj9NTLuazLZNbAuj869Fm6k+gIvDPf5YJk8Hj7Xh0ZQvl7JdtXzfgRAQl0WS27wzfGQEy+HpG1EqX5e3OKHxUDisWIH9ADba0h0j/t+wNYXZ/0htD2KK2iT3QqtmooDWgVIWjeqxfdlJgdx/axeXHTlCDvNiDhjq5yH+NJeFlXJUrMzQX0gtHuEYH62+NVwpE7DVYM1GUW9znHTLzkSdJt95HxiJBCU3yghKr+duZVZbuakbmRTYyveD3+vtJ9m58Ym+gi5l1aTPG4yGPYWApo0YbgAcr3AWk1ahliea/BUyWJinu5KbBpBF4RxJMhOkjQjHJ++S1S/kBqjE7QGbjnEpLlw6UJCbpCkAkuRcF0GZBVCsUw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(44832011)(86362001)(2906002)(186003)(26005)(956004)(2616005)(31686004)(82960400001)(66946007)(5660300002)(316002)(966005)(66556008)(508600001)(8936002)(31696002)(83380400001)(36756003)(6486002)(8676002)(53546011)(6666004)(16576012)(66476007)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUQ3bVhYYkZSMUFzWTdVMDlZSm0wWktKRGtZRmtiOWgwZEZTY3o3ZTRPZGZT?= =?utf-8?B?UTRIVE1XYnV4K0N2bEFFcUJLbXg2TVJYLytLc0tSNmJnT1NiK3JZanRmTUwz?= =?utf-8?B?ZlFKV3JaM2ZMYlFXWklveGxkV3B4VDRFQTZEY0FmUEFJVkJZS3NXU0hJOVd6?= =?utf-8?B?VDRPSUJWSTRrN1hISnFpcnAzRG5vU0VEbmZ1cmIwVCthS0EySlUrZjVSRWRN?= =?utf-8?B?QWlqSUQvOFpGZERPaWQ3ZVRiUE9uYzRESjRGVUpkekY0YWFVZFZnMTRVVVNC?= =?utf-8?B?MkpSSGRwL2QwbkVpN0hGcGlTTjFWa1ptZ3lCa250Z2FyN29Ib0JOWHl4RFpl?= =?utf-8?B?K24rbkgxQmsrVkJpc0RsTTVoTW5aT0t6UlFCMmpMc2ZvWEg2QjdaODliWTBy?= =?utf-8?B?ZkJ4UUVKcFk3dzFNZlY4ZE1hbHVKNFVRc2NseXdBK2hvTzRNbEdVamQwcWFE?= =?utf-8?B?WkpmTW1zV3VKZmpEZkhSRVRBbVVsalhUQndPUW8wTW5VZlBJOTdDTXIwQXYw?= =?utf-8?B?OWl4RUdML29EemxJRDZ2M0JmSSt0OFEwak9RVnV3ZmwvYmdnK0RROVZlOTQ2?= =?utf-8?B?S2t6aEw0UElXempoZlNWaGN2c1E0dEVNVDh6aWRXOWtpbHkzWXQyR2l6T2Ri?= =?utf-8?B?RWhncUpjZW5FeDVGaUg3cm9kWHJLK1YxdjhyZzYwS0pQVUR4NUI0ckRSR0Fo?= =?utf-8?B?VlMzL1NLMUFDODNuQnROckRiKzkvaml4QTdnc1JyWElVTitLRGFzWXp2ZHNq?= =?utf-8?B?QWx5bEd6TGhOaThmUmZRSEp1RHN1OERRM3hDSmRTUjJMMklzMjQwQzZVaGtZ?= =?utf-8?B?S1dxd0tueWRzeHJqeXA2QS9aNm1nK1h6SHlmTHpQUHhqUTQrYXAycHkrYURK?= =?utf-8?B?RCtRSWJralp0Z2tUVVcwSlNiQ0tlZnBIelZGU2JpR2E5VW1YaFZKOW84NXlE?= =?utf-8?B?TTI0cXFWdlovRklsaFdTZFUwa20vU3VsaXM2K2lqMVgyWVlxZ3doQ1hyV0h2?= =?utf-8?B?R0xNWlRRNjI1Vzh1Y1g4M0lrNU1mK29NdWJSVVRMa1FpT0F6NGhVTWt3ZGpl?= =?utf-8?B?eVBIbU5hM29LYWdNbTI2M1dMOEVWWlF1WmFQeVE2Zm9aL0ExOHVCOXB0ZFMx?= =?utf-8?B?ZHNpbkJFVGxjV3M1aWxGSy9QZGtIY3pHcWJqTmlJTm8zaThMaXpJVU1aM3Ru?= =?utf-8?B?TnlVeitDeVo0Wi96WEtZTm1sK3J3RldNTWMvb3ZiU0xLS0grRTUrTFFTWUp5?= =?utf-8?B?MmRjN29HczBYNkNXNjRTdzluZkhSYnBwSTNmNkxiQTc1RktaNEpCVlpGUnVV?= =?utf-8?B?U2hlYkc4UStvdTRiSEtlYnpOTGNPK0JLeTFmWnJ5eXRzREhJNWNha3Qwb0dr?= =?utf-8?B?cURFcFRvK09ObkdLYzVNVVlQeHZKUEwzOE1Yd3RDZzBKdUNVTVNEbkFQRlhT?= =?utf-8?B?SS9Pa3QwQ3BhaEdFM3dhdUZoWVNsb1hjNTM3Q2xNR1YzYUN0aXpzQTZOeVh2?= =?utf-8?B?b3dhQ0dJUjBwTHBaMlNmRTkvN0oySFJ3RHBnUCtXZDYzbElNS2xQeDhnRmpD?= =?utf-8?B?d3hRaklYRHhTaVlYTGp0Q0F0ZS9Pb3JCbzVCUVlUYlYvRU04RnhWcng5TFdy?= =?utf-8?B?WjNJN1ZiMDdUbmpweFowRGV3V0dhSTQ1ek84dHdEeEhJaVU4MTA2eUNzcHRN?= =?utf-8?B?UUxNdmMyM2RqS3B4eERvc2laUkI4Z1pTR0c2emxqWHpFdUpMTmxxcWk0d2sr?= =?utf-8?B?bU02UEVrc1VwM1M1U1EvSkt3T3I3S2ZRRTg0Qy9aM0VkY0NPVmpaTzZFM0d1?= =?utf-8?B?NTA0RnR6VGVpamM2RFVTMzdsTFBkMnNvRmEzOE8yenpQMVJzNlltL1h1OGp5?= =?utf-8?B?eWJPM0kxd0IraG1udFZydVhoQnFIYjRhaWdvMERDYW5xRmd3QmJ3VFZjRXFI?= =?utf-8?B?a1BNczRtK0EwdTllb1lTU3J2dVZONG1BdWVvaHpNZFBXVVBvSW5GMm5JRXpt?= =?utf-8?B?TnpUVzVNcHJBMjZENk95eTRpQm1BZENvaHNHdERhVHQ2QmJnUHBRUUczT1VH?= =?utf-8?B?Qnl0Z1dNMHJrZGwvTkNYREZuMmZGbGxyL2JhZDlPcU1od01YNklIdFl4MGtB?= =?utf-8?B?ekRpYUw0MXJaams4dnhkVWZwdDFtSGF5NVJjYU1UT3g4YnIraDgxZGtqZXpq?= =?utf-8?Q?ifUUDvbbsYfczVM+0S85SO8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 61a4b4e6-3c6a-4c81-4e3f-08d99e2afb8e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 18:02:49.9810 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8sQvf5lkDBCdi7/T6cPruHPuImbNkpLjdX4lCL9BCiDYN7eNEehE3UDFgTqY/vtzbTmDHLLyvj7eslUH+zyZBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4920 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 0/6] Flow entites behavior on port restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 11/2/2021 5:01 PM, Dmitry Kozlyuk wrote: > It is unspecified whether flow rules and indirect actions are kept > when a port is stopped, possibly reconfigured, and started again. > Vendors approach the topic differently, e.g. mlx5 and i40e PMD > disagree in whether flow rules can be kept, and mlx5 PMD would keep > indirect actions. In the end, applications are greatly affected > by whatever contract there is and need to know it. > > Applications may wish to restart the port to reconfigure it, > e.g. switch offloads or even modify queues. > Keeping rte_flow entities enables application improvements: > 1. Since keeping the rules across restart comes with the ability > to create rules before the device is started. This allows > to have all the rules created at the moment of start, > so that there is no time frame when traffic is coming already, > but the rules are not yet created (restored). > 2. When a rule or an indirect action has some associated state, > such as a counter, application saves the need to keep > additional state in order to cope with information loss > if such an entity would be destroyed. > > It is proposed to advertise capabilities of keeping flow rules > and indirect actions (as a special case of shared object) > using a combination of ethdev info and rte_flow calls. > Then a bug is fixed in mlx5 PMD that prevented indirect RSS action > from being kept, and the driver starts advertising the new capability. > > Prior discussions: > 1) http://inbox.dpdk.org/dev/20210727073121.895620-1-dkozlyuk@nvidia.com/ > 2) http://inbox.dpdk.org/dev/20210901085516.3647814-1-dkozlyuk@nvidia.com/ > > v6: > Rebase on next-net commit 87f4496c74e6 and fix conflicts. > v5: > 1. Fix rebase conflicts. > 2. Add warnings about experimental status (Andrew). > v4: 1. Fix rebase conflicts (CI). > 2. State rule behavior when a port is not started or stopped (Ori). > 3. Improve wording on rule features, add examples (Andrew). > 4. State that rules/actions that cannot be kept while other can be > must be destroyed by the application (Andrew/Ori). > 5. Add rationale to the cover letter (Andrew). > > > Dmitry Kozlyuk (6): > ethdev: add capability to keep flow rules on restart > ethdev: add capability to keep shared objects on restart > net: advertise no support for keeping flow rules > net/mlx5: discover max flow priority using DevX > net/mlx5: create drop queue using DevX > net/mlx5: preserve indirect actions on restart > Series applied to dpdk-next-net/main, thanks.