From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53793A09E0; Fri, 13 Nov 2020 18:23:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3DBE6C868; Fri, 13 Nov 2020 18:23:47 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7A70C323E for ; Fri, 13 Nov 2020 18:23:45 +0100 (CET) IronPort-SDR: +yfsx54ikywuyZLoyVhhgo2/+tatKAYAxcnU6abuJoK4eN2n5LYkwjMvv5nnMqg/gMa+8qNGKW 529l76LoqO4Q== X-IronPort-AV: E=McAfee;i="6000,8403,9804"; a="255214183" X-IronPort-AV: E=Sophos;i="5.77,476,1596524400"; d="scan'208";a="255214183" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2020 09:23:42 -0800 IronPort-SDR: bIvtUx9xuOF9ICYzrw/yhfaE0XZiS8s8cFq+0e1P41pyeD/qzqavZ6EeEUHzI4bXyqpnQJD3FB pgt0KEEc0klw== X-IronPort-AV: E=Sophos;i="5.77,476,1596524400"; d="scan'208";a="474739028" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.3.208]) ([10.252.3.208]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2020 09:23:41 -0800 From: Ferruh Yigit To: Olivier Matz , dev@dpdk.org Cc: David Marchand , Thomas Monjalon References: <20201113103957.19068-1-olivier.matz@6wind.com> <20201113131319.GR1898@platinum> Message-ID: Date: Fri, 13 Nov 2020 17:23:37 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/pcap: fix registration of timestamp dynamic field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/13/2020 2:02 PM, Ferruh Yigit wrote: > On 11/13/2020 1:13 PM, Olivier Matz wrote: >> On Fri, Nov 13, 2020 at 11:39:57AM +0100, Olivier Matz wrote: >>> In pcap pmd, the timestamp mbuf dynamic field is mandatory. When the >>> pcap pmd is created in a secondary process (this is the case for pdump), >>> it cannot be registered because this is not allowed from a secondary >>> process. >>> >>> To ensure that the field is properly registered, do it from probe() >>> instead of configure(). Indeed, probe() is invoked on the primary >>> process when a device is created in a secondary. >>> > > probe() invoked first in the primary, later in the secondary, both process calls > the driver probe(). But for this case probe(), and dynfield register, being > called first in primary seems solving the problem. > Would you be OK to change last sentences as: > "Indeed, probe() is first invoked on the primary process when a device is > created in a secondary, this enables registering dynfield from secondary process." > >>> Bugzilla ID: 571 >>> Fixes: d23d73d088c1 ("net/pcap: switch Rx timestamp to dynamic mbuf field") >>> >>> Signed-off-by: Olivier Matz > > Reviewed-by: Ferruh Yigit > Applied to dpdk-next-net/main, thanks. With above suggested change in the commit log.