From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01FE3A0613 for ; Mon, 23 Sep 2019 13:04:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA6511BEA4; Mon, 23 Sep 2019 13:04:23 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B2F341BE9D; Mon, 23 Sep 2019 13:04:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 04:04:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,539,1559545200"; d="scan'208";a="363595887" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by orsmga005.jf.intel.com with ESMTP; 23 Sep 2019 04:04:18 -0700 To: "Wang, ShougangX" , "dev@dpdk.org" Cc: "Lu, Wenzhuo" , "Yang, Qiming" , "stable@dpdk.org" References: <20190906012838.64088-1-shougangx.wang@intel.com> <00A8E5A1740DFA49A87AFFAC34B8EDEA3857EB@SHSMSX101.ccr.corp.intel.com> <00A8E5A1740DFA49A87AFFAC34B8EDEA385D4D@SHSMSX101.ccr.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Mon, 23 Sep 2019 12:04:18 +0100 MIME-Version: 1.0 In-Reply-To: <00A8E5A1740DFA49A87AFFAC34B8EDEA385D4D@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/17/2019 10:22 AM, Wang, ShougangX wrote: >> Let's assume port already stopped before calling the reset, reset will cause port >> to be started. > > Indeed, automatically start looks strange in this case. User explicitly do the > "port start" command should be better. > >> I am for user explicitly do the stop, reset and start commands, instead of reset >> automatically stop and start later. > > There are two reasons that it is necessary to stop automatically in "port reset" command: > 1) Even without this patch, user does not need to manually execute "port stop" command > before "port reset" too, because port will be stopped in rte_eth_dev_reset() function. > But this function does not update the port status flag of testpmd. It makes the port state > recorded by testpmd inconsistent with the actual port state. So I add stop processing in > reset_port() function to stop port as same as running "port stop" command. I see 'rte_eth_dev_reset()' API calls the 'rte_eth_dev_stop()' but it isn't enough as you said and a testpmd stop is required, instead of doing in the function it is easy to detect port is not stopped and return an error in the 'reset', it is up to user to stop and do the reset. > > 2) If let user to stop port manually when he wants to reset port, it is not easy to use than before. I still prefer 'Explicit is better than implicit.' [1], yes it is two commands now to reset the port if it is already started but I don't see this is a problem. Anyway this is not a big deal, if testpmd maintainers are OK for it we can continue with this... [1] see: The Zen of Python :) > > Thanks. > Shougang > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Monday, September 16, 2019 11:28 PM >> To: Wang, ShougangX ; dev@dpdk.org >> Cc: Lu, Wenzhuo ; Yang, Qiming >> ; stable@dpdk.org >> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start >> fwd >> >> On 9/16/2019 7:37 AM, Wang, ShougangX wrote: >>> Hi Ferruh >>> >>> Thanks for your reply. >>> >>>> Not sure if 'reset' command should do more than it says, if there is >>>> a requirement that port should be stopped, why not add this condition >>>> with an error message so that user can stop the port in advance if she wants. >>> >>> Firstly, port must be stopped before reset. Usually, port is stopped >>> by rte_eth_dev_reset(), so testpmd does not prompt user to stop port. >>> Although it can stop port, but testpmd does not change its own port status >> flag to "RTE_PORT_STOPPED" and it will cause "port start" to fail. >>> So I add this patch to stop port as same as running "port stop" command. >> >> Let's assume port already stopped before calling the reset, reset will cause port >> to be started. >> I am for user explicitly do the stop, reset and start commands, instead of reset >> automatically stop and start later. >> >>> >>>> - 'reset_port()' function has a loop inside, 'RTE_ETH_FOREACH_DEV()' >>>> but it works on single port, the loop looked unnecessary to me, can >>>> you please check and remove the loop if required? >>> >>> "port reset" supports reset all ports (testpmd > port reset all), so this loop is >> necessary. >> >> Got it. >> >>> >>>> - I am not able to see 'reset' has been documented in >>>> 'doc/guides/testpmd_app_ug/testpmd_funcs.rst', it may be missing, can >>>> you please check and add it if required? >>> >>> OK. I will add it in the next patch. >>> >>> Thanks. >>> Shougang >>> >>> >>>> -----Original Message----- >>>> From: Yigit, Ferruh >>>> Sent: Saturday, September 14, 2019 1:35 AM >>>> To: Wang, ShougangX ; dev@dpdk.org >>>> Cc: Lu, Wenzhuo ; Yang, Qiming >>>> ; stable@dpdk.org >>>> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix Segment fault >>>> when start fwd >>>> >>>> On 9/6/2019 2:28 AM, Wang ShougangX wrote: >>>>> This patch fixed the reset function to avoid crash when user don't >>>>> call port reset , port stop and port start functions as sequence. >>>>> >>>>> Fixes: 97f1e19679 ("app/testpmd: add port reset command") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Wang ShougangX >>>>> --- >>>>> app/test-pmd/testpmd.c | 6 ++++++ >>>>> 1 file changed, 6 insertions(+) >>>>> >>>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index >>>>> e8e2a39b6..273a7aa02 100644 >>>>> --- a/app/test-pmd/testpmd.c >>>>> +++ b/app/test-pmd/testpmd.c >>>>> @@ -2344,6 +2344,9 @@ reset_port(portid_t pid) >>>>> if (port_id_is_invalid(pid, ENABLED_WARN)) >>>>> return; >>>>> >>>>> + printf("Stopping ports...\n"); >>>>> + stop_port(pid); >>>>> + >>>>> printf("Resetting ports...\n"); >>>>> >>>>> RTE_ETH_FOREACH_DEV(pi) { >>>>> @@ -2372,6 +2375,9 @@ reset_port(portid_t pid) >>>>> } >>>>> } >>>>> >>>>> + printf("Starting ports...\n"); >>>>> + start_port(pid); >>>>> + >>>>> printf("Done\n"); >>>>> } >>>> >>>> Hi Shougang, >>>> >>>> Not sure if 'reset' command should do more than it says, if there is >>>> a requirement that port should be stopped, why not add this condition >>>> with an error message so that user can stop the port in advance if she wants. >>>> >>>> >>>> Btw, a few things related, >>>> - 'reset_port()' function has a loop inside, 'RTE_ETH_FOREACH_DEV()' >>>> but it works on single port, the loop looked unnecessary to me, can >>>> you please check and remove the loop if required? >>>> >>>> - I am not able to see 'reset' has been documented in >>>> 'doc/guides/testpmd_app_ug/testpmd_funcs.rst', it may be missing, can >>>> you please check and add it if required? >>>> >>>> Thanks, >>>> ferruh >