[PATCH] doc: update ark guide

[PATCH] doc: update ark guide

[Shepard Siegel]

Include introduced FX2 PCIe ID and description.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
index ba00f14e80..39cd75064d 100644
--- a/doc/guides/nics/ark.rst
+++ b/doc/guides/nics/ark.rst
@@ -52,6 +52,10 @@ board. While specific capabilities such as number of physical
 hardware queue-pairs are negotiated; the driver is designed to
 remain constant over a broad and extendable feature set.
 
+* FPGA Vendors Supported: AMD/Xilinx and Intel
+* Number of RX/TX Queue-Pairs: up to 128
+* PCIe Endpoint Technology: Gen3, Gen4, Gen5
+
 Intentionally, Arkville by itself DOES NOT provide common NIC
 capabilities such as offload or receive-side scaling (RSS).
 These capabilities would be viewed as a gate-level "tax" on
@@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
 * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
 * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
 * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
+* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]
+
+Arkville RTL Core Configurations
+-------------------------------------
+
+Arkville's RTL core may be configured by the user for three different
+datapath widths to balance throughput against FPGA logic area. The ARK PMD
+has introspection on the RTL core configuration and acts accordingly.
+All three configurations present identical RTL user-facing AXI stream
+interfaces for both AMD/Xilinx and Intel FPGAs.
+
+* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
+* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
+* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
 
 DPDK and Arkville Firmware Versioning
 -------------------------------------
@@ -334,6 +352,8 @@ Supported Features
 ------------------
 
 * Dynamic ARK PMD extensions
+* Dynamic per-queue MBUF (re)sizing up to 32KB
+* SR-IOV, VF-based queue-segregation
 * Multiple receive and transmit queues
 * Jumbo frames up to 9K
 * Hardware Statistics
-- 
2.25.1

Re: [PATCH] doc: update ark guide

[Ferruh Yigit]

On 2/10/2023 7:38 PM, Shepard Siegel wrote:
> Include introduced FX2 PCIe ID and description.
> 
> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> ---
>  doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> index ba00f14e80..39cd75064d 100644
> --- a/doc/guides/nics/ark.rst
> +++ b/doc/guides/nics/ark.rst
> @@ -52,6 +52,10 @@ board. While specific capabilities such as number of physical
>  hardware queue-pairs are negotiated; the driver is designed to
>  remain constant over a broad and extendable feature set.
>  
> +* FPGA Vendors Supported: AMD/Xilinx and Intel
> +* Number of RX/TX Queue-Pairs: up to 128
> +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> +
>  Intentionally, Arkville by itself DOES NOT provide common NIC
>  capabilities such as offload or receive-side scaling (RSS).
>  These capabilities would be viewed as a gate-level "tax" on
> @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
>  * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
>  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
>  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
> +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]

Hi Shepard, Ed,	

This device is not supported by ark driver, am I missing something?

> +
> +Arkville RTL Core Configurations
> +-------------------------------------
> +
> +Arkville's RTL core may be configured by the user for three different
> +datapath widths to balance throughput against FPGA logic area. The ARK PMD
> +has introspection on the RTL core configuration and acts accordingly.
> +All three configurations present identical RTL user-facing AXI stream
> +interfaces for both AMD/Xilinx and Intel FPGAs.
> +
> +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
>  
>  DPDK and Arkville Firmware Versioning
>  -------------------------------------
> @@ -334,6 +352,8 @@ Supported Features
>  ------------------
>  
>  * Dynamic ARK PMD extensions
> +* Dynamic per-queue MBUF (re)sizing up to 32KB
> +* SR-IOV, VF-based queue-segregation
>  * Multiple receive and transmit queues
>  * Jumbo frames up to 9K
>  * Hardware Statistics

Re: [PATCH] doc: update ark guide

[Shepard Siegel]

[-- Attachment #1: Type: text/plain, Size: 2772 bytes --]

Hi Ferruh,
The new FX2 device *is* supported by the ark driver as of DPDK 23.03.
These changes bring the ark doc up to date for the upcoming release.
-Shep


On Fri, Feb 10, 2023 at 3:34 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 2/10/2023 7:38 PM, Shepard Siegel wrote:
> > Include introduced FX2 PCIe ID and description.
> >
> > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> > ---
> >  doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> > index ba00f14e80..39cd75064d 100644
> > --- a/doc/guides/nics/ark.rst
> > +++ b/doc/guides/nics/ark.rst
> > @@ -52,6 +52,10 @@ board. While specific capabilities such as number of
> physical
> >  hardware queue-pairs are negotiated; the driver is designed to
> >  remain constant over a broad and extendable feature set.
> >
> > +* FPGA Vendors Supported: AMD/Xilinx and Intel
> > +* Number of RX/TX Queue-Pairs: up to 128
> > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> > +
> >  Intentionally, Arkville by itself DOES NOT provide common NIC
> >  capabilities such as offload or receive-side scaling (RSS).
> >  These capabilities would be viewed as a gate-level "tax" on
> > @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe
> instances including:
> >  * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
> >  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex
> R-Tile]
> >  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
> > +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]
>
> Hi Shepard, Ed,
>
> This device is not supported by ark driver, am I missing something?
>
> > +
> > +Arkville RTL Core Configurations
> > +-------------------------------------
> > +
> > +Arkville's RTL core may be configured by the user for three different
> > +datapath widths to balance throughput against FPGA logic area. The ARK
> PMD
> > +has introspection on the RTL core configuration and acts accordingly.
> > +All three configurations present identical RTL user-facing AXI stream
> > +interfaces for both AMD/Xilinx and Intel FPGAs.
> > +
> > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> > +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
> >
> >  DPDK and Arkville Firmware Versioning
> >  -------------------------------------
> > @@ -334,6 +352,8 @@ Supported Features
> >  ------------------
> >
> >  * Dynamic ARK PMD extensions
> > +* Dynamic per-queue MBUF (re)sizing up to 32KB
> > +* SR-IOV, VF-based queue-segregation
> >  * Multiple receive and transmit queues
> >  * Jumbo frames up to 9K
> >  * Hardware Statistics
>
>

[-- Attachment #2: Type: text/html, Size: 3542 bytes --]

Re: [PATCH] doc: update ark guide

[Ferruh Yigit]

On 2/10/2023 9:03 PM, Shepard Siegel wrote:
> Hi Ferruh,
> The new FX2 device *is* supported by the ark driver as of DPDK 23.03.
> These changes bring the ark doc up to date for the upcoming release.

I don't know what exactly 'FX2' device is, but I was referring to
'1d6c:1022' device id.
Following is the device table from latest code [1], is '1d6c:1022'
supported?

static const struct rte_pci_id pci_id_ark_map[] = {
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100d)},
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100e)},
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100f)},
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1010)},
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1017)},
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1018)},
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1019)},
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101a)},
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101b)},
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
        {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
        {.vendor_id = 0, /* sentinel */ },
};

[1]
https://elixir.bootlin.com/dpdk/v22.11.1/source/drivers/net/ark/ark_ethdev.c#L89

> -Shep
> 
> 
> On Fri, Feb 10, 2023 at 3:34 PM Ferruh Yigit <ferruh.yigit@amd.com
> <mailto:ferruh.yigit@amd.com>> wrote:
> 
>     On 2/10/2023 7:38 PM, Shepard Siegel wrote:
>     > Include introduced FX2 PCIe ID and description.
>     >
>     > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com
>     <mailto:shepard.siegel@atomicrules.com>>
>     > ---
>     >  doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
>     >  1 file changed, 20 insertions(+)
>     >
>     > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
>     > index ba00f14e80..39cd75064d 100644
>     > --- a/doc/guides/nics/ark.rst
>     > +++ b/doc/guides/nics/ark.rst
>     > @@ -52,6 +52,10 @@ board. While specific capabilities such as
>     number of physical
>     >  hardware queue-pairs are negotiated; the driver is designed to
>     >  remain constant over a broad and extendable feature set.
>     > 
>     > +* FPGA Vendors Supported: AMD/Xilinx and Intel
>     > +* Number of RX/TX Queue-Pairs: up to 128
>     > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
>     > +
>     >  Intentionally, Arkville by itself DOES NOT provide common NIC
>     >  capabilities such as offload or receive-side scaling (RSS).
>     >  These capabilities would be viewed as a gate-level "tax" on
>     > @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL
>     PCIe instances including:
>     >  * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
>     >  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for
>     Agilex R-Tile]
>     >  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
>     > +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for
>     Agilex]
> 
>     Hi Shepard, Ed,
> 
>     This device is not supported by ark driver, am I missing something?
> 
>     > +
>     > +Arkville RTL Core Configurations
>     > +-------------------------------------
>     > +
>     > +Arkville's RTL core may be configured by the user for three different
>     > +datapath widths to balance throughput against FPGA logic area.
>     The ARK PMD
>     > +has introspection on the RTL core configuration and acts accordingly.
>     > +All three configurations present identical RTL user-facing AXI stream
>     > +interfaces for both AMD/Xilinx and Intel FPGAs.
>     > +
>     > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
>     > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
>     > +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
>     > 
>     >  DPDK and Arkville Firmware Versioning
>     >  -------------------------------------
>     > @@ -334,6 +352,8 @@ Supported Features
>     >  ------------------
>     > 
>     >  * Dynamic ARK PMD extensions
>     > +* Dynamic per-queue MBUF (re)sizing up to 32KB
>     > +* SR-IOV, VF-based queue-segregation
>     >  * Multiple receive and transmit queues
>     >  * Jumbo frames up to 9K
>     >  * Hardware Statistics
> 

Re: [PATCH] doc: update ark guide

[Shepard Siegel]

[-- Attachment #1: Type: text/plain, Size: 4473 bytes --]

Yes, exactly, the 1d6c:1022 device is the new FX2 device that will be
supported in the 22.03 release.

-Shep



On Fri, Feb 10, 2023 at 4:11 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 2/10/2023 9:03 PM, Shepard Siegel wrote:
> > Hi Ferruh,
> > The new FX2 device *is* supported by the ark driver as of DPDK 23.03.
> > These changes bring the ark doc up to date for the upcoming release.
>
> I don't know what exactly 'FX2' device is, but I was referring to
> '1d6c:1022' device id.
> Following is the device table from latest code [1], is '1d6c:1022'
> supported?
>
> static const struct rte_pci_id pci_id_ark_map[] = {
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100d)},
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100e)},
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100f)},
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1010)},
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1017)},
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1018)},
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1019)},
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101a)},
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101b)},
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
>         {.vendor_id = 0, /* sentinel */ },
> };
>
> [1]
>
> https://elixir.bootlin.com/dpdk/v22.11.1/source/drivers/net/ark/ark_ethdev.c#L89
>
> > -Shep
> >
> >
> > On Fri, Feb 10, 2023 at 3:34 PM Ferruh Yigit <ferruh.yigit@amd.com
> > <mailto:ferruh.yigit@amd.com>> wrote:
> >
> >     On 2/10/2023 7:38 PM, Shepard Siegel wrote:
> >     > Include introduced FX2 PCIe ID and description.
> >     >
> >     > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com
> >     <mailto:shepard.siegel@atomicrules.com>>
> >     > ---
> >     >  doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
> >     >  1 file changed, 20 insertions(+)
> >     >
> >     > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> >     > index ba00f14e80..39cd75064d 100644
> >     > --- a/doc/guides/nics/ark.rst
> >     > +++ b/doc/guides/nics/ark.rst
> >     > @@ -52,6 +52,10 @@ board. While specific capabilities such as
> >     number of physical
> >     >  hardware queue-pairs are negotiated; the driver is designed to
> >     >  remain constant over a broad and extendable feature set.
> >     >
> >     > +* FPGA Vendors Supported: AMD/Xilinx and Intel
> >     > +* Number of RX/TX Queue-Pairs: up to 128
> >     > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> >     > +
> >     >  Intentionally, Arkville by itself DOES NOT provide common NIC
> >     >  capabilities such as offload or receive-side scaling (RSS).
> >     >  These capabilities would be viewed as a gate-level "tax" on
> >     > @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL
> >     PCIe instances including:
> >     >  * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
> >     >  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for
> >     Agilex R-Tile]
> >     >  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
> >     > +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for
> >     Agilex]
> >
> >     Hi Shepard, Ed,
> >
> >     This device is not supported by ark driver, am I missing something?
> >
> >     > +
> >     > +Arkville RTL Core Configurations
> >     > +-------------------------------------
> >     > +
> >     > +Arkville's RTL core may be configured by the user for three
> different
> >     > +datapath widths to balance throughput against FPGA logic area.
> >     The ARK PMD
> >     > +has introspection on the RTL core configuration and acts
> accordingly.
> >     > +All three configurations present identical RTL user-facing AXI
> stream
> >     > +interfaces for both AMD/Xilinx and Intel FPGAs.
> >     > +
> >     > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> >     > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> >     > +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
> >     >
> >     >  DPDK and Arkville Firmware Versioning
> >     >  -------------------------------------
> >     > @@ -334,6 +352,8 @@ Supported Features
> >     >  ------------------
> >     >
> >     >  * Dynamic ARK PMD extensions
> >     > +* Dynamic per-queue MBUF (re)sizing up to 32KB
> >     > +* SR-IOV, VF-based queue-segregation
> >     >  * Multiple receive and transmit queues
> >     >  * Jumbo frames up to 9K
> >     >  * Hardware Statistics
> >
>
>

[-- Attachment #2: Type: text/html, Size: 6195 bytes --]

Re: [PATCH] doc: update ark guide

[Shepard Siegel]

[-- Attachment #1: Type: text/plain, Size: 4774 bytes --]

I meant to say "supported in the 23.03 release." just now in my email.
sorry for the typo!


On Fri, Feb 10, 2023 at 4:43 PM Shepard Siegel <
shepard.siegel@atomicrules.com> wrote:

> Yes, exactly, the 1d6c:1022 device is the new FX2 device that will be
> supported in the 22.03 release.
>
> -Shep
>
>
>
> On Fri, Feb 10, 2023 at 4:11 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
>> On 2/10/2023 9:03 PM, Shepard Siegel wrote:
>> > Hi Ferruh,
>> > The new FX2 device *is* supported by the ark driver as of DPDK 23.03.
>> > These changes bring the ark doc up to date for the upcoming release.
>>
>> I don't know what exactly 'FX2' device is, but I was referring to
>> '1d6c:1022' device id.
>> Following is the device table from latest code [1], is '1d6c:1022'
>> supported?
>>
>> static const struct rte_pci_id pci_id_ark_map[] = {
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100d)},
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100e)},
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100f)},
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1010)},
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1017)},
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1018)},
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1019)},
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101a)},
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101b)},
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
>>         {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
>>         {.vendor_id = 0, /* sentinel */ },
>> };
>>
>> [1]
>>
>> https://elixir.bootlin.com/dpdk/v22.11.1/source/drivers/net/ark/ark_ethdev.c#L89
>>
>> > -Shep
>> >
>> >
>> > On Fri, Feb 10, 2023 at 3:34 PM Ferruh Yigit <ferruh.yigit@amd.com
>> > <mailto:ferruh.yigit@amd.com>> wrote:
>> >
>> >     On 2/10/2023 7:38 PM, Shepard Siegel wrote:
>> >     > Include introduced FX2 PCIe ID and description.
>> >     >
>> >     > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com
>> >     <mailto:shepard.siegel@atomicrules.com>>
>> >     > ---
>> >     >  doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
>> >     >  1 file changed, 20 insertions(+)
>> >     >
>> >     > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
>> >     > index ba00f14e80..39cd75064d 100644
>> >     > --- a/doc/guides/nics/ark.rst
>> >     > +++ b/doc/guides/nics/ark.rst
>> >     > @@ -52,6 +52,10 @@ board. While specific capabilities such as
>> >     number of physical
>> >     >  hardware queue-pairs are negotiated; the driver is designed to
>> >     >  remain constant over a broad and extendable feature set.
>> >     >
>> >     > +* FPGA Vendors Supported: AMD/Xilinx and Intel
>> >     > +* Number of RX/TX Queue-Pairs: up to 128
>> >     > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
>> >     > +
>> >     >  Intentionally, Arkville by itself DOES NOT provide common NIC
>> >     >  capabilities such as offload or receive-side scaling (RSS).
>> >     >  These capabilities would be viewed as a gate-level "tax" on
>> >     > @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL
>> >     PCIe instances including:
>> >     >  * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
>> >     >  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for
>> >     Agilex R-Tile]
>> >     >  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
>> >     > +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for
>> >     Agilex]
>> >
>> >     Hi Shepard, Ed,
>> >
>> >     This device is not supported by ark driver, am I missing something?
>> >
>> >     > +
>> >     > +Arkville RTL Core Configurations
>> >     > +-------------------------------------
>> >     > +
>> >     > +Arkville's RTL core may be configured by the user for three
>> different
>> >     > +datapath widths to balance throughput against FPGA logic area.
>> >     The ARK PMD
>> >     > +has introspection on the RTL core configuration and acts
>> accordingly.
>> >     > +All three configurations present identical RTL user-facing AXI
>> stream
>> >     > +interfaces for both AMD/Xilinx and Intel FPGAs.
>> >     > +
>> >     > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
>> >     > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
>> >     > +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
>> >     >
>> >     >  DPDK and Arkville Firmware Versioning
>> >     >  -------------------------------------
>> >     > @@ -334,6 +352,8 @@ Supported Features
>> >     >  ------------------
>> >     >
>> >     >  * Dynamic ARK PMD extensions
>> >     > +* Dynamic per-queue MBUF (re)sizing up to 32KB
>> >     > +* SR-IOV, VF-based queue-segregation
>> >     >  * Multiple receive and transmit queues
>> >     >  * Jumbo frames up to 9K
>> >     >  * Hardware Statistics
>> >
>>
>>

[-- Attachment #2: Type: text/html, Size: 6718 bytes --]

[PATCH v2] doc: update ark guide

[Shepard Siegel]

Add ark PCIe device 1d6c:1022 FX2 to pci_id_ark_map.
Include introduced FX2 PCIe ID and description.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 doc/guides/nics/ark.rst      | 20 ++++++++++++++++++++
 drivers/net/ark/ark_ethdev.c |  1 +
 2 files changed, 21 insertions(+)

diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
index ba00f14e80..39cd75064d 100644
--- a/doc/guides/nics/ark.rst
+++ b/doc/guides/nics/ark.rst
@@ -52,6 +52,10 @@ board. While specific capabilities such as number of physical
 hardware queue-pairs are negotiated; the driver is designed to
 remain constant over a broad and extendable feature set.
 
+* FPGA Vendors Supported: AMD/Xilinx and Intel
+* Number of RX/TX Queue-Pairs: up to 128
+* PCIe Endpoint Technology: Gen3, Gen4, Gen5
+
 Intentionally, Arkville by itself DOES NOT provide common NIC
 capabilities such as offload or receive-side scaling (RSS).
 These capabilities would be viewed as a gate-level "tax" on
@@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
 * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
 * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
 * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
+* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]
+
+Arkville RTL Core Configurations
+-------------------------------------
+
+Arkville's RTL core may be configured by the user for three different
+datapath widths to balance throughput against FPGA logic area. The ARK PMD
+has introspection on the RTL core configuration and acts accordingly.
+All three configurations present identical RTL user-facing AXI stream
+interfaces for both AMD/Xilinx and Intel FPGAs.
+
+* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
+* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
+* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
 
 DPDK and Arkville Firmware Versioning
 -------------------------------------
@@ -334,6 +352,8 @@ Supported Features
 ------------------
 
 * Dynamic ARK PMD extensions
+* Dynamic per-queue MBUF (re)sizing up to 32KB
+* SR-IOV, VF-based queue-segregation
 * Multiple receive and transmit queues
 * Jumbo frames up to 9K
 * Hardware Statistics
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index c654a229f7..b2995427c8 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
+	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
 	{.vendor_id = 0, /* sentinel */ },
 };
 
-- 
2.25.1

Re: [PATCH v2] doc: update ark guide

[Ferruh Yigit]

On 2/10/2023 10:35 PM, Shepard Siegel wrote:
> Add ark PCIe device 1d6c:1022 FX2 to pci_id_ark_map.
> Include introduced FX2 PCIe ID and description.
> 

Thanks for v2, but this is no more just a documentation patch,
can you please split the patch into two,
first one adds new device support and update documentation related to
new device, with a 'net/ark:' title,
second one updates the document for extended information which is most
of this patch


> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> ---
>  doc/guides/nics/ark.rst      | 20 ++++++++++++++++++++
>  drivers/net/ark/ark_ethdev.c |  1 +
>  2 files changed, 21 insertions(+)
> 
> diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> index ba00f14e80..39cd75064d 100644
> --- a/doc/guides/nics/ark.rst
> +++ b/doc/guides/nics/ark.rst
> @@ -52,6 +52,10 @@ board. While specific capabilities such as number of physical
>  hardware queue-pairs are negotiated; the driver is designed to
>  remain constant over a broad and extendable feature set.
>  
> +* FPGA Vendors Supported: AMD/Xilinx and Intel
> +* Number of RX/TX Queue-Pairs: up to 128
> +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> +
>  Intentionally, Arkville by itself DOES NOT provide common NIC
>  capabilities such as offload or receive-side scaling (RSS).
>  These capabilities would be viewed as a gate-level "tax" on
> @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
>  * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
>  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
>  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
> +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]
> +
> +Arkville RTL Core Configurations
> +-------------------------------------
> +
> +Arkville's RTL core may be configured by the user for three different
> +datapath widths to balance throughput against FPGA logic area. The ARK PMD
> +has introspection on the RTL core configuration and acts accordingly.
> +All three configurations present identical RTL user-facing AXI stream
> +interfaces for both AMD/Xilinx and Intel FPGAs.
> +
> +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
>  
>  DPDK and Arkville Firmware Versioning
>  -------------------------------------
> @@ -334,6 +352,8 @@ Supported Features
>  ------------------
>  
>  * Dynamic ARK PMD extensions
> +* Dynamic per-queue MBUF (re)sizing up to 32KB
> +* SR-IOV, VF-based queue-segregation
>  * Multiple receive and transmit queues
>  * Jumbo frames up to 9K
>  * Hardware Statistics
> diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> index c654a229f7..b2995427c8 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/drivers/net/ark/ark_ethdev.c
> @@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
>  	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
>  	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
>  	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
> +	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
>  	{.vendor_id = 0, /* sentinel */ },
>  };
>  

Re: [PATCH v2] doc: update ark guide

[Shepard Siegel]

[-- Attachment #1: Type: text/plain, Size: 3657 bytes --]

Thank you Ferruh,
I understand now.
We will abandon this patch and do exactly as you suggest with two
separate patches.
Thanks for your guidance. Look for the two patches ETA tomorrow.
-Shep

On Fri, Feb 10, 2023 at 5:56 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 2/10/2023 10:35 PM, Shepard Siegel wrote:
> > Add ark PCIe device 1d6c:1022 FX2 to pci_id_ark_map.
> > Include introduced FX2 PCIe ID and description.
> >
>
> Thanks for v2, but this is no more just a documentation patch,
> can you please split the patch into two,
> first one adds new device support and update documentation related to
> new device, with a 'net/ark:' title,
> second one updates the document for extended information which is most
> of this patch
>
>
> > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> > ---
> >  doc/guides/nics/ark.rst      | 20 ++++++++++++++++++++
> >  drivers/net/ark/ark_ethdev.c |  1 +
> >  2 files changed, 21 insertions(+)
> >
> > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> > index ba00f14e80..39cd75064d 100644
> > --- a/doc/guides/nics/ark.rst
> > +++ b/doc/guides/nics/ark.rst
> > @@ -52,6 +52,10 @@ board. While specific capabilities such as number of
> physical
> >  hardware queue-pairs are negotiated; the driver is designed to
> >  remain constant over a broad and extendable feature set.
> >
> > +* FPGA Vendors Supported: AMD/Xilinx and Intel
> > +* Number of RX/TX Queue-Pairs: up to 128
> > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> > +
> >  Intentionally, Arkville by itself DOES NOT provide common NIC
> >  capabilities such as offload or receive-side scaling (RSS).
> >  These capabilities would be viewed as a gate-level "tax" on
> > @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe
> instances including:
> >  * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
> >  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex
> R-Tile]
> >  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
> > +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]
> > +
> > +Arkville RTL Core Configurations
> > +-------------------------------------
> > +
> > +Arkville's RTL core may be configured by the user for three different
> > +datapath widths to balance throughput against FPGA logic area. The ARK
> PMD
> > +has introspection on the RTL core configuration and acts accordingly.
> > +All three configurations present identical RTL user-facing AXI stream
> > +interfaces for both AMD/Xilinx and Intel FPGAs.
> > +
> > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> > +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
> >
> >  DPDK and Arkville Firmware Versioning
> >  -------------------------------------
> > @@ -334,6 +352,8 @@ Supported Features
> >  ------------------
> >
> >  * Dynamic ARK PMD extensions
> > +* Dynamic per-queue MBUF (re)sizing up to 32KB
> > +* SR-IOV, VF-based queue-segregation
> >  * Multiple receive and transmit queues
> >  * Jumbo frames up to 9K
> >  * Hardware Statistics
> > diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> > index c654a229f7..b2995427c8 100644
> > --- a/drivers/net/ark/ark_ethdev.c
> > +++ b/drivers/net/ark/ark_ethdev.c
> > @@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
> >       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
> >       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
> >       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
> > +     {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
> >       {.vendor_id = 0, /* sentinel */ },
> >  };
> >
>
>

[-- Attachment #2: Type: text/html, Size: 4554 bytes --]

[PATCH v3 1/2] net/ark: introduce Arkville FX2 PCIe device

[Shepard Siegel]

This commit introduces the Arkville FX2 PCIe device.
Arkville FX2 provides support for PCIe Gen5x16 endpoints.
FX2 is backwards-compatible with the net/ark PMD so that no
changes other than the whitelist addition in this patch are
needed for the basic operation of this device.
Additional details are in a doc: patch with this submission.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 drivers/net/ark/ark_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index c654a229f7..b2995427c8 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
+	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
 	{.vendor_id = 0, /* sentinel */ },
 };
 
-- 
2.25.1

[PATCH v3 2/2] doc: add Arkville FX2 PCIe device description

[Shepard Siegel]

Update net/ark guide for clarity.
Include list of FX0, FX1 and FX2 PCIe devices.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
index ba00f14e80..39cd75064d 100644
--- a/doc/guides/nics/ark.rst
+++ b/doc/guides/nics/ark.rst
@@ -52,6 +52,10 @@ board. While specific capabilities such as number of physical
 hardware queue-pairs are negotiated; the driver is designed to
 remain constant over a broad and extendable feature set.
 
+* FPGA Vendors Supported: AMD/Xilinx and Intel
+* Number of RX/TX Queue-Pairs: up to 128
+* PCIe Endpoint Technology: Gen3, Gen4, Gen5
+
 Intentionally, Arkville by itself DOES NOT provide common NIC
 capabilities such as offload or receive-side scaling (RSS).
 These capabilities would be viewed as a gate-level "tax" on
@@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
 * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
 * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
 * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
+* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]
+
+Arkville RTL Core Configurations
+-------------------------------------
+
+Arkville's RTL core may be configured by the user for three different
+datapath widths to balance throughput against FPGA logic area. The ARK PMD
+has introspection on the RTL core configuration and acts accordingly.
+All three configurations present identical RTL user-facing AXI stream
+interfaces for both AMD/Xilinx and Intel FPGAs.
+
+* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
+* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
+* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
 
 DPDK and Arkville Firmware Versioning
 -------------------------------------
@@ -334,6 +352,8 @@ Supported Features
 ------------------
 
 * Dynamic ARK PMD extensions
+* Dynamic per-queue MBUF (re)sizing up to 32KB
+* SR-IOV, VF-based queue-segregation
 * Multiple receive and transmit queues
 * Jumbo frames up to 9K
 * Hardware Statistics
-- 
2.25.1

Re: [PATCH v3 2/2] doc: add Arkville FX2 PCIe device description

[Ferruh Yigit]

On 2/11/2023 1:26 AM, Shepard Siegel wrote:
> Update net/ark guide for clarity.
> Include list of FX0, FX1 and FX2 PCIe devices.
> 
> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> ---
>  doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> index ba00f14e80..39cd75064d 100644
> --- a/doc/guides/nics/ark.rst
> +++ b/doc/guides/nics/ark.rst
> @@ -52,6 +52,10 @@ board. While specific capabilities such as number of physical
>  hardware queue-pairs are negotiated; the driver is designed to
>  remain constant over a broad and extendable feature set.
>  
> +* FPGA Vendors Supported: AMD/Xilinx and Intel
> +* Number of RX/TX Queue-Pairs: up to 128
> +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> +
>  Intentionally, Arkville by itself DOES NOT provide common NIC
>  capabilities such as offload or receive-side scaling (RSS).
>  These capabilities would be viewed as a gate-level "tax" on
> @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
>  * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
>  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
>  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
> +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]

Can you please add new device related documentation to patch that adds
new device?
At least above line is related to it, but if any other updates in this
document is related to this new device that part also can go to other patch.

Or if it make more sense you can first introduce the document update
patch for old devices, and later add new device and new device related
documentation, like:

First patch adds:
  +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
  +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)

Second patch adds new device and appends following:
  +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)


> +
> +Arkville RTL Core Configurations
> +-------------------------------------
> +
> +Arkville's RTL core may be configured by the user for three different
> +datapath widths to balance throughput against FPGA logic area. The ARK PMD
> +has introspection on the RTL core configuration and acts accordingly.
> +All three configurations present identical RTL user-facing AXI stream
> +interfaces for both AMD/Xilinx and Intel FPGAs.
> +
> +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
>  
>  DPDK and Arkville Firmware Versioning
>  -------------------------------------
> @@ -334,6 +352,8 @@ Supported Features
>  ------------------
>  
>  * Dynamic ARK PMD extensions
> +* Dynamic per-queue MBUF (re)sizing up to 32KB
> +* SR-IOV, VF-based queue-segregation
>  * Multiple receive and transmit queues
>  * Jumbo frames up to 9K
>  * Hardware Statistics

Re: [PATCH v3 2/2] doc: add Arkville FX2 PCIe device description

[Shepard Siegel]

[-- Attachment #1: Type: text/plain, Size: 4268 bytes --]

Hi Ferruh,

I don't think the submission system will allow your request of a single
patch with both a code change and document change since they are in
different directories. I must say I'm confused by your request. In the
current v3 which is not your preference, we split up the new device into
the 0001 and the doc on the new device in the 0002.

Your current ask of "Can you please add new device related documentation to
patch that adds new device?" was what we did back on v2. Guessing you don't
like the mention of any other devices in the FX2 addition?

It feels crazy to have to have three different patches to essentially add a
one-liner to our PCIe device alowlist! Am I making this way more
complicated than it needs to be?

We will produce the sequence of three patches in the morning.

Would a cover letter help explain when we are doing with this patch?
If there are elements that are not clear, let me know and we will work to
clarify it.

Thank you for your efforts in this and countless other DPDK pushes!

best, Shep




On Fri, Feb 10, 2023 at 9:13 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 2/11/2023 1:26 AM, Shepard Siegel wrote:
> > Update net/ark guide for clarity.
> > Include list of FX0, FX1 and FX2 PCIe devices.
> >
> > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> > ---
> >  doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> > index ba00f14e80..39cd75064d 100644
> > --- a/doc/guides/nics/ark.rst
> > +++ b/doc/guides/nics/ark.rst
> > @@ -52,6 +52,10 @@ board. While specific capabilities such as number of
> physical
> >  hardware queue-pairs are negotiated; the driver is designed to
> >  remain constant over a broad and extendable feature set.
> >
> > +* FPGA Vendors Supported: AMD/Xilinx and Intel
> > +* Number of RX/TX Queue-Pairs: up to 128
> > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> > +
> >  Intentionally, Arkville by itself DOES NOT provide common NIC
> >  capabilities such as offload or receive-side scaling (RSS).
> >  These capabilities would be viewed as a gate-level "tax" on
> > @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe
> instances including:
> >  * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
> >  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex
> R-Tile]
> >  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
> > +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]
>
> Can you please add new device related documentation to patch that adds
> new device?
> At least above line is related to it, but if any other updates in this
> document is related to this new device that part also can go to other
> patch.
>
> Or if it make more sense you can first introduce the document update
> patch for old devices, and later add new device and new device related
> documentation, like:
>
> First patch adds:
>   +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
>   +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
>
> Second patch adds new device and appends following:
>   +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
>
>
> > +
> > +Arkville RTL Core Configurations
> > +-------------------------------------
> > +
> > +Arkville's RTL core may be configured by the user for three different
> > +datapath widths to balance throughput against FPGA logic area. The ARK
> PMD
> > +has introspection on the RTL core configuration and acts accordingly.
> > +All three configurations present identical RTL user-facing AXI stream
> > +interfaces for both AMD/Xilinx and Intel FPGAs.
> > +
> > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> > +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
> >
> >  DPDK and Arkville Firmware Versioning
> >  -------------------------------------
> > @@ -334,6 +352,8 @@ Supported Features
> >  ------------------
> >
> >  * Dynamic ARK PMD extensions
> > +* Dynamic per-queue MBUF (re)sizing up to 32KB
> > +* SR-IOV, VF-based queue-segregation
> >  * Multiple receive and transmit queues
> >  * Jumbo frames up to 9K
> >  * Hardware Statistics
>
>

[-- Attachment #2: Type: text/html, Size: 5290 bytes --]

Re: [PATCH v3 2/2] doc: add Arkville FX2 PCIe device description

[Ferruh Yigit]

On 2/11/2023 3:07 AM, Shepard Siegel wrote:
> Hi Ferruh,
> 
> I don't think the submission system will allow your request of a single
> patch with both a code change and document change since they are in
> different directories. I must say I'm confused by your request. In the
> current v3 which is not your preference, we split up the new device into
> the 0001 and the doc on the new device in the 0002.
> 

Hi Shepard,

We are accepting doc and code changes in a single patch, indeed this is
preferred to have them together (although they are in different folders)

The logic is if someone looks the git history of specific document
update she can find relevant code change, or vice versa. If they are
separate and user finds a document that mentions a feature is enabled,
it can be challenging to find when/where that feature is added in the code.

> Your current ask of "Can you please add new device related documentation
> to patch that adds new device?" was what we did back on v2. Guessing you
> don't like the mention of any other devices in the FX2 addition?
> 
> It feels crazy to have to have three different patches to essentially
> add a one-liner to our PCIe device alowlist! Am I making this way more
> complicated than it needs to be?
> 

I have no intention to make more complicated, but that one line change
is adding a new device support, so it is important change to have its
own patch. It may even require a release notes update and web page
update later.

Your initial version was doing documentation update, and one of that
update was documenting a device as supported although it is not in the
code. You think it is not a bit deal to document unsupported devices as
supported, but I disagree.

My ask is simple, do the code update to support new device and relevant
doc update for new device in one patch, and rest of the documentation
updates in another.

Please reach out to me from slack/IRC if it is still confusing.

> We will produce the sequence of three patches in the morning. 
> 
> Would a cover letter help explain when we are doing with this patch?
> If there are elements that are not clear, let me know and we will work
> to clarify it.
> 
> Thank you for your efforts in this and countless other DPDK pushes!
> 
> best, Shep
> 
> 
> 
> 
> On Fri, Feb 10, 2023 at 9:13 PM Ferruh Yigit <ferruh.yigit@amd.com
> <mailto:ferruh.yigit@amd.com>> wrote:
> 
>     On 2/11/2023 1:26 AM, Shepard Siegel wrote:
>     > Update net/ark guide for clarity.
>     > Include list of FX0, FX1 and FX2 PCIe devices.
>     >
>     > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com
>     <mailto:shepard.siegel@atomicrules.com>>
>     > ---
>     >  doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
>     >  1 file changed, 20 insertions(+)
>     >
>     > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
>     > index ba00f14e80..39cd75064d 100644
>     > --- a/doc/guides/nics/ark.rst
>     > +++ b/doc/guides/nics/ark.rst
>     > @@ -52,6 +52,10 @@ board. While specific capabilities such as
>     number of physical
>     >  hardware queue-pairs are negotiated; the driver is designed to
>     >  remain constant over a broad and extendable feature set.
>     > 
>     > +* FPGA Vendors Supported: AMD/Xilinx and Intel
>     > +* Number of RX/TX Queue-Pairs: up to 128
>     > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
>     > +
>     >  Intentionally, Arkville by itself DOES NOT provide common NIC
>     >  capabilities such as offload or receive-side scaling (RSS).
>     >  These capabilities would be viewed as a gate-level "tax" on
>     > @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL
>     PCIe instances including:
>     >  * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
>     >  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for
>     Agilex R-Tile]
>     >  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
>     > +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for
>     Agilex]
> 
>     Can you please add new device related documentation to patch that adds
>     new device?
>     At least above line is related to it, but if any other updates in this
>     document is related to this new device that part also can go to
>     other patch.
> 
>     Or if it make more sense you can first introduce the document update
>     patch for old devices, and later add new device and new device related
>     documentation, like:
> 
>     First patch adds:
>       +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
>       +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> 
>     Second patch adds new device and appends following:
>       +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
> 
> 
>     > +
>     > +Arkville RTL Core Configurations
>     > +-------------------------------------
>     > +
>     > +Arkville's RTL core may be configured by the user for three different
>     > +datapath widths to balance throughput against FPGA logic area.
>     The ARK PMD
>     > +has introspection on the RTL core configuration and acts accordingly.
>     > +All three configurations present identical RTL user-facing AXI stream
>     > +interfaces for both AMD/Xilinx and Intel FPGAs.
>     > +
>     > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
>     > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
>     > +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
>     > 
>     >  DPDK and Arkville Firmware Versioning
>     >  -------------------------------------
>     > @@ -334,6 +352,8 @@ Supported Features
>     >  ------------------
>     > 
>     >  * Dynamic ARK PMD extensions
>     > +* Dynamic per-queue MBUF (re)sizing up to 32KB
>     > +* SR-IOV, VF-based queue-segregation
>     >  * Multiple receive and transmit queues
>     >  * Jumbo frames up to 9K
>     >  * Hardware Statistics
>