From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC00145BB8; Sat, 26 Oct 2024 01:10:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C6A840295; Sat, 26 Oct 2024 01:10:18 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2052.outbound.protection.outlook.com [40.107.237.52]) by mails.dpdk.org (Postfix) with ESMTP id 2248840273 for ; Sat, 26 Oct 2024 01:10:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PaaSR05k60isPaP5mKbPBNJsKEMRCsz2K9swTeskJPjc3BuDyKfA9ouFjhESIdwiVUJ6CGMzWMQFu+TJxz+4JkxYaJsycVN9V8yT+OFctMSqCgsHMYMPs/meI2BxfUmg4V8hl304Nb/bN4PIgRP9p/5/U9zdW2Fg6AvQpUI6pMFzUefPnGH/OJ88ROEXDzsyFc5eNi7yI92TWVI62NqSQh/6znxO90VKNwJGlUh84YK9YahEiGp2ClUAchToCOI27YHjmnFo/VCWKwW8X8zZgTCB6L2vlR6rPVJVqbGGU8knW7iYHY4uXKI0WGt5Elwl+RN4cKgHiW/AU4Qq9O9nJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lHYV/5yVh5wU72Y84QuLjTevtJt6RxyiXkLOuNGk85U=; b=oYKQTvIe3lyhnIg9jtkpqNeEUri1jCmj3margjfPqr0V0d4/zgPCgMaqpNZQ5EvtDL6f09lQSWB+IcZfQTSiEysld7S4yYRZAX1KMCGgoLc1tTt/koyc7eWAoweshIt+9Rul6rt9qXLHdj4gMTTgVq4dnyjeBJqm9zcAUC6pNiXIDN0V5wL6BiOX2gQi3V4vx+2dpvIE40WVyog7+souQvtJbZynKVXSNMn0qU1IUbEEhc13ThibgZYcodICGLJ1xgDQ/Zn9sk5qSZWIBbXIDcreJMy8zN9norBWfhQVZ3JYbOcqn8TdEqy2d2Bfhhufy49hOx2LXACQQucqtTxjnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lHYV/5yVh5wU72Y84QuLjTevtJt6RxyiXkLOuNGk85U=; b=g4VW64Ns+0BZQ7NORY+y1BWvPBVkrdepgexrulJMgyUsSL7WlvkJ52MmEbBK5fs1ISbaVdzoZODQKp3kMw8DNKtONd82YiMXhmZe9iTKz/5YYvTld7+Rv3W9BoyevbeltGEjdiYUfcHYXa7G3HZvkBRQujgL/ehcjdfHpVz0QQU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by IA0PR12MB7773.namprd12.prod.outlook.com (2603:10b6:208:431::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21; Fri, 25 Oct 2024 23:10:14 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8093.018; Fri, 25 Oct 2024 23:10:14 +0000 Message-ID: Date: Sat, 26 Oct 2024 00:10:09 +0100 User-Agent: Mozilla Thunderbird From: Ferruh Yigit Subject: Re: [PATCH v01] net/af_packet: don't specify protocol on socket create To: Stephen Hemminger , Gur Stavi Cc: dev@dpdk.org, "John W. Linville" References: <20241016183811.338dc230@hermes.local> Content-Language: en-US Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20241016183811.338dc230@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0431.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::35) To SN7PR12MB8818.namprd12.prod.outlook.com (2603:10b6:806:34b::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|IA0PR12MB7773:EE_ X-MS-Office365-Filtering-Correlation-Id: 744f3e7a-384d-47a8-c008-08dcf54a2ec6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Z1hWWXJmTjB2dWlpVUthenBQcUdpMGZaWDdDUENjTHpLN2ZOWmpyek5CZDY2?= =?utf-8?B?VVUwc2lkcFpxMW5pN01BT0xiVFp5dUJQUkJIZXJLQWxoaE5uVzVpTEhBS0xo?= =?utf-8?B?ZnRRZ0M3NkRER3Rpc1ZJK09NaEQ4RlgxWFhISmdRQ2dWRC9PMnUzbk9hbVFL?= =?utf-8?B?MTBhRmkwazdOUTA3UDVudjNWU0Q5WUFUVDBYelpucDlLSzhia3NQaG1ZNGdk?= =?utf-8?B?R3huS1VmLzJTMEs1cHZQL0syK25wdFZmZUZLSUhwZ2lSMFdYd2lyMW55b0tM?= =?utf-8?B?WTk2RjJIS0ZFSWplYk41K2pWa0lLWTRpZDNZb3lQK1FQQTVEV1o0amZ0ZXZ3?= =?utf-8?B?MVlmaDg3UTZ0U0loZXcrV21MeG81QkpGY1ZPYTN6SkZzMTZNdUxPYlpvSG1l?= =?utf-8?B?MmJRN2ZmVW9RZWdOdTlmUGtnTkl2c01mTTEyS3hzdnd6TWNDWmlzK292WldH?= =?utf-8?B?Nyt1aVNRUk4ya1Rrek1xazFiMnNoaThoK2dCR2duTStJUnltZnBIZW1ZZk5X?= =?utf-8?B?cHh6Wldlb3VZdVU1MzhVY1pyMmlrOTk3TFg4Q0ZrNlRPQ083RjdQdjdzUHBX?= =?utf-8?B?dzJUSWp5U0xoMjZvMW9tdGhZek9Rdys4RDhIZjQvVloxSFBrU3M2TTF4R0d4?= =?utf-8?B?TkorT3NVZVhVaS91SjJoNG1PV21NZ1lxNndDTXphakk0cmR4YzNmY2FzM25R?= =?utf-8?B?Vm1wV3BLSlJVbVZtVTVwWXdQVGdrUGtCKy81c0ZqRVc0N1RiK3VURnh5aCsx?= =?utf-8?B?VjZFUmZzZGhIaUhiSUFGV2NTSERSaTZhK1dNeHgvMWN4TDJVeHJNZE5YVWh0?= =?utf-8?B?ZFh5UE0wM1RxVFl5MTY4OTMvRVp4blZCY2ZrTHJyNTVjS3gxcHVRUGVLQlMz?= =?utf-8?B?eDNKaURUMDNKbTlUb1R1ZUVxRkhYZVBzSlpZeFUzQU9rSUtCTnQ5SHcxeUpE?= =?utf-8?B?ZHRKSlpNVUZUOEFqcHliM2M2SEJWK2Erb091S3RZY1Q2NzJMdjNVMi8wQlNh?= =?utf-8?B?SExaZkFOUC85akxaUUpKaEltSUdyTG5ZWGM3MGEvZHRxNmZ0REdyY2NVaHdm?= =?utf-8?B?a211SEx6WjhweHdQSndId25Yd0VCb2dPeERCblY3QmhUYUExdFlUTEZiaWNw?= =?utf-8?B?YlErQk9Kakl3d1YvdEl4bWpoZENjYU5odkJPMVFOVGpVbGErTk0xMk1SWkJD?= =?utf-8?B?OFAvbGpyV2R2SEtodXB4WXAvbGVoSlJNREExbHc4YlY0dFNtVlNYdFdWOGdZ?= =?utf-8?B?QUJZRXQySmdVYjE5amg5V1BiV2o2QlRKYkF0cVdTTEJuS1d5STFDeXZoVmpG?= =?utf-8?B?Nk5OR2tnQVQzQlZOdkswZkVDK0I5eEFjWTRQRFg3SndneFdZWitlc2dqR2JM?= =?utf-8?B?ejNSSnFjUWFvQTlSc01HcDZLNkdyQjR0NUdCWFcyUEQ0RGJXTklJd1RoSVFu?= =?utf-8?B?L3lpQVFiZlJVUHd4b2s2aEhqL3NyWk9iSVpSZkxFNlpTZU90Z3lXeGhlR3Zr?= =?utf-8?B?MW9DazAyczNNUDhWSi9vakhUMVNsVWc5RnFBTGRMR2h3eDd1c0paZEhZbXpE?= =?utf-8?B?NzQ0c1ZwM2ZEMGh6QTRUbFRXZllrZE9RZWFWUnlsOC9rT3orUElwRTlCc0hv?= =?utf-8?B?T21qeSs1VWVVVm82SlpTYm8zN1Evc0JJekVZdXo2eUFvc3hEZDl2MHBhaGF1?= =?utf-8?B?Q3ZWRlRFQ3kxRnFHY3czN09ITnhPa09FR3lXcGRVMkV2OVEwVTVhMlpmWGFo?= =?utf-8?Q?6NgykJlqa2Y4A61Knk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2VuNjluSXBOM3RiT0s4eko2NER1OXpmVEhSS3JHZ1gxS1ZzcG9zWmdGYVEz?= =?utf-8?B?bGN0R0xTMGxUTmNkOVl1cWZyNDIwR3JGZER1QXc2WEZ5R3kzbjB3SG5pZkNn?= =?utf-8?B?U1BLQXFTcDZMNzNtNmhwWitlVDlWcjNpWDNZZjBiOFo0QmlDK1VDdFlHL1pm?= =?utf-8?B?TXF0enJ3ZjBIcUhaTDBhc2NBbFFJaW5pUjJpZ3NWSE1JNkRWaERtQ0N0OXRz?= =?utf-8?B?bER1ajVjMmtmRDFZeHpPY09ka1E4NWhUbmpNTFBnN296bTJKOXNsaVBRTTdW?= =?utf-8?B?Rzd5ZCsrcDAwL3NhYlhjc2liV3dzdVE4Q2VVTUdrVU01NjdiaWt3TzNkZ1Np?= =?utf-8?B?VUVtYytjT1puTVh0Z3BUSThITlFDUUFvMjJYRE5EUjEzRlA3NXhkb3ZpQi9N?= =?utf-8?B?S0xxNm01OHU1ZE9nOXhiMy82U3cvMk1ML0NSQjBvaURURXFEQklXbjg1T0ZK?= =?utf-8?B?aFBwVXhhbzVTZWhlQ1ZDVGxLV2pvMHV2K0FnU01kMUdvWmhiRzNHamVtcFc4?= =?utf-8?B?WGVsSHRpNitpUWl1TExXLy9YcUQ0amU4NE9CeWJROXV0b3puMlpPYkFRay9J?= =?utf-8?B?MGd3ZEdIYVFIZGZpMVJmN25rbW56Q2xES29ua2w2eW9VbDNFVjBBNWpKRG9O?= =?utf-8?B?NDYyZ0VwMzZVZWppS2V2OXZZcEZzcWZ5dHhpenh2MHhCWlZIckdFTEVHN0JI?= =?utf-8?B?MDRzMTNJVk11OWxIWU5WM3VrZ2FQa1JFVHUrdEtJNXNaeGFKZUxXTzR3MnJY?= =?utf-8?B?K1lwajFyS2duMXhrZ1c3MDNNeHlmSjZWUnB3SGl6OXFRZ01lUHplZEw0ZU84?= =?utf-8?B?RHJaNlFUMXBUSGxPemtSTzByeVJnTnBoK3EzUVF1U0JXbGhaTVBOa1AwSDJh?= =?utf-8?B?VHB5OXhYdjVRaWpnRVd5elJLbENFL0xiM1NubThHcW1NT2IvalE3cUtJMmNK?= =?utf-8?B?MlFYdVdpSzhnYzdwanBvbGZDMjk3SDdjNE5PUkdwN1lremhVMXJtQkUyRmxa?= =?utf-8?B?cnN6TFJkdlpxTDZMYjNvYzFvdnhDVzU3MDQ2eUwyNCtseGRGM1JaZW95MW9Y?= =?utf-8?B?ZUppVHVlMGRURWV2N2c1UVdmQ1QycUd0QVBDVlpzaTJBNEREekJIMDRodmk5?= =?utf-8?B?SkNmZk50UnFXdE5Mc05VR2FxZHBEWEpkbjhuTllXczUvL0tGMEYwUk1mY0FX?= =?utf-8?B?Q3phYlJkM1p5MVpZRVdmcDBobmpzdWcrMVUyUksyWXJ0TzNjc3lZU2dmOW50?= =?utf-8?B?RHlVWU9jYTNUWHFKa2swM1VOa1dUSEVUaXpsQmtKOHNqUnM3L1NRd1YvRkJN?= =?utf-8?B?cFF4YVVMZ3hFYWVHWW83ZVY3UXorMFJtVE1XYzJ6RTE5K1hhY0tXNXB1WVZ5?= =?utf-8?B?TkhBZFltbDBvNHFNU2FvOXg3bE5vSURNM1RmRWJBWTBUYjFNNXgwTEF0T3ZJ?= =?utf-8?B?TmxqaUVyUGxFbkI5Q2ZrMGZQNDRTTEtrT1NsSm9SOWpVKzF5eFUvOGVodjJ0?= =?utf-8?B?YUJvZDN3TXlsSkJjSnNSdWpEREVWNU9VY21zbHpRZ1BMREo5NXVMUWYzUlp2?= =?utf-8?B?Mkk4aTluZkRqM0JxcTdiNmxRYUMzbjl5Qm52TzZOZ0h4VWwrWEIvRjdsSjdu?= =?utf-8?B?VEMvbSsvMGhFOTNBK2U2VHh0TUppMFowUHdtOW1sMDhMRytCZXl0RlY2Ni9R?= =?utf-8?B?V3hyaCtwQWZJNGNuSDd5U0V5YThpQXVOaXpNWEpaQTVUQUhlS3ZlMS8vY3J1?= =?utf-8?B?d3BEbytRZzN0N3lVRjQxVm9Xb0V6dkp1ZmNVYVl0dzFTMVVCQzJzVjQyZEpH?= =?utf-8?B?eDg0NGEwamxnamdtYktodmI1b0ZUQjFEd0YyWVRzbXZqaFJ3eUh4WGpqOTVy?= =?utf-8?B?KzkzRzBEZWUxZ1g5RDE4aHgrOXBoa0ZsQURhV21KNEdINXBJdUZJQW1tUUpz?= =?utf-8?B?OWN0TDJycTBtNS9UUGk2d3dlYUFlajFMdnVwbWJsci9pRC9kS1M3eVpHUWNj?= =?utf-8?B?MU90UkVQWUlZTW5rNVozOThKWVc0cWhVQUJLdFJsOG54eksraFgreEE0OEpJ?= =?utf-8?B?QzN2d3hrK0pMMlEveEI1d2lKemM3SWxoOXl6U3puS29aZzluWlp2MFA0NVlS?= =?utf-8?Q?QxRd7z72529OPFYVftKc+Ww2U?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 744f3e7a-384d-47a8-c008-08dcf54a2ec6 X-MS-Exchange-CrossTenant-AuthSource: SN7PR12MB8818.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 23:10:14.6905 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E4jYnJvb2rCrflxXX3kruKdh7pqzoIyeHfOS2ra3ag7F+gBqA+EUtopw8ROjzmFj X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7773 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/17/2024 2:38 AM, Stephen Hemminger wrote: > On Sun, 13 Oct 2024 16:59:47 +0300 > Gur Stavi wrote: > >> When creating AF_PACKET socket with specified protocol it is >> immediately implicitly bound to any existing interface and >> becomes RUNNING. Calling bind on such socket is affectively unbind >> from "any interface", then bind to the specific interface. >> >> When creating socket with 0 as protocol, it is created in non-RUNNING >> state, then it can be bound to interface and protocol in a single bind >> call and switch to RUNNING state. >> >> Especially with ETH_P_ALL, binding to any interface is not a good idea. >> It is safer and faster to use the 2nd approach. >> >> This patch replaces protocol in socket creation from ETH_P_ALL to 0. >> >> Signed-off-by: Gur Stavi > > This makes sense see packet(7) man page: > > By default, all packets of the specified protocol type are passed to a > packet socket. To get packets only from a specific interface use > bind(2) specifying an address in a struct sockaddr_ll to bind the packet > socket to an interface. Fields used for binding are sll_family (should > be AF_PACKET), sll_protocol, and sll_ifindex. > > So there is a small window where the packet socket could pick up junk before > the bind from other interfaces. > Thanks, this answers some of my questions in this thread, also I did some experiment and verified the same. I agree this change is more close the intention of the driver (driver is not to get packets from all interfaces), hence: Acked-by: Ferruh Yigit