Re: [PATCH v2] net/nfp: implement the device packet type set interface

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 9/26/2024 8:16 AM, Chaoyong He wrote:
> From: Long Wu <long.wu@corigine.com>
> 
> Using the Rx packet offload flag rather than the device
> capability to control the packet type offload configuration.
> Also implement the device packet type set interface to
> let application can set the Rx packet offload flag.
> 
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> 
> ---
> V2:
> * Following the advice from reviewer, abandon the modification of RTE
>   layer.
> ---
>  drivers/net/nfp/nfp_ethdev.c     |  1 +
>  drivers/net/nfp/nfp_net_common.c | 42 +++++++++++++++++++++++++++++++-
>  drivers/net/nfp/nfp_net_common.h |  1 +
>  3 files changed, 43 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
> index bd35df2dc9..09c15eedac 100644
> --- a/drivers/net/nfp/nfp_ethdev.c
> +++ b/drivers/net/nfp/nfp_ethdev.c
> @@ -932,6 +932,7 @@ static const struct eth_dev_ops nfp_net_eth_dev_ops = {
>  	.xstats_get_names_by_id = nfp_net_xstats_get_names_by_id,
>  	.dev_infos_get          = nfp_net_infos_get,
>  	.dev_supported_ptypes_get = nfp_net_supported_ptypes_get,
> +	.dev_ptypes_set         = nfp_net_ptypes_set,
>

Hi Chaoyong,

It looks like nfp support "Packet type parsing", can you please
advertise this feature in the nfp.ini?
I think it is OK to add it into this patch.