Re: [PATCH v2 2/2] ethdev: remove callback checks from fast path

[Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>]

On 5/12/25 18:07, skori@marvell.com wrote:
> From: Sunil Kumar Kori <skori@marvell.com>
> 
> rte_eth_fp_ops contains ops for fast path APIs. Each API
> validates availability of callback and then invoke it.
> These checks impact data path performace.
> 
> Hence removing these NULL checks instead using dummy
> callbacks.
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>

with few nits fixed (see below):
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

[snip]

> diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h
> index 2b4d2ae9c3..71085bddff 100644
> --- a/lib/ethdev/ethdev_driver.h
> +++ b/lib/ethdev/ethdev_driver.h
> @@ -1874,6 +1874,77 @@ rte_eth_pkt_burst_dummy(void *queue __rte_unused,
>   		struct rte_mbuf **pkts __rte_unused,
>   		uint16_t nb_pkts __rte_unused);
>   
> +/**
> + * @internal
> + * Dummy DPDK callback for Tx packet prepare.
> + *
> + * @param queue
> + *  Pointer to Tx queue
> + * @param pkts
> + *  Packet array
> + * @param nb_pkts
> + *  Number of packets in packet array

Such descriptions do not help. Please, document return value since it is
always the same.

Fix all descriptions in the patch.