From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB4E342C96; Mon, 12 Jun 2023 11:47:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7344E40689; Mon, 12 Jun 2023 11:47:48 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 55A854014F for ; Mon, 12 Jun 2023 11:47:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686563266; x=1718099266; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=8HNBXH3/+xy6l7c0YJ/nIJ0muWd54OaDGPJ382SgGEU=; b=X+zXrOvgyjitkzkpTy8rvgt2G8WJ28PpTCsrJHGkwK84AcfYJOid0+kU uZnGFtaFu1P8YFuojK+ihvHRyneDZ8PweYIJtQ1VgXnTJprhohaR1hG1F sZRxFjKyQRvHgTRJkjmguClGQ/kfhYWXT/qGPc2A+EoWAGafZ23k6Uyjy pyApyYV6lKv1sUs5lLD9KSNA1WwjfdqsUi9jcR3s7QluEJpTzOGbNy78z sD7L9s9JoZEb4apeA+4U06FcnR6z7kdtBsz0wmWb7TGRQU+ui7UpCRyCa zfMZ0VOazo5SzEjfr26x6EN74wvtgCFUOqLgsJGRJz0hdfT+MC/9hB8nX A==; X-IronPort-AV: E=McAfee;i="6600,9927,10738"; a="347643379" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="347643379" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 02:47:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10738"; a="781126442" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="781126442" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 12 Jun 2023 02:47:44 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 12 Jun 2023 02:47:44 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 12 Jun 2023 02:47:43 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 12 Jun 2023 02:47:43 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 12 Jun 2023 02:47:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M3bR5kGAlGsO0OiiX/x8dJEQwfFOhClPR2btGmDWOyndsUkIdYkJ8TA6D5tSylc4DWGkEa2BcKj5ROlD6EVG0v7Y7qDALJiygGxPyWEka8DG0GBwrFNb8Nw1D5AW8J0Jd42CRqq+WLahUNbooqiGHUsMKvGh9bqAJCnazqh/xOulSSzmcsTkoIiIeeAxnuH8rvatLboZkoyKm2KFCChQYFruK9MLLF7s1D9iYb7s2Jzs+hZpnFd/Jk0s8nnZGPq+zv+BU8ROszljpY6cdJH4WG09l+5CKgwFdvEWeoIBCWsrjnGA15tzywrWLQiPi+2rGRs12t/BbNj3TosBMXpXdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v5qUM6uxgWKRaMCaUVVPKRfFIN/LYT1X2GSDoYMqH1M=; b=L8K2oTjdbgTre6pWW/g0EkiLuvYdNKT6etxRorJwoeyKp5TQGXBLpSZu8UDYprOmtOs3ONdEbdrN7ESay/iuSiWs2+fS2OY2pU6MgIunNQLXTZgRE5a1Uq8h5+p996KHZSYNKBWt5fDbkZhrtOd8uJE/BxDUOXmgp9kMk5mflONNnCbTNKYPybEMxGJHZc2p/76ua29Twb0D+bKrwIfDXDw+pGgyylAK7tOGzfQH+y+5kyEVmgtpomnqlmGgG2Shw9Ru264XXBYUPboNBHOETaDSpIJdaGfNeqJ2jfViFsfYNY12rEDytm/vooKOUqwMt+Nenp9XKYudvEmXZ3f30A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CYYPR11MB8329.namprd11.prod.outlook.com (2603:10b6:930:c7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Mon, 12 Jun 2023 09:47:41 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718%7]) with mapi id 15.20.6455.030; Mon, 12 Jun 2023 09:47:41 +0000 Message-ID: Date: Mon, 12 Jun 2023 10:47:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.1 Subject: Re: [PATCH] bus/pci: fix return value check of device FD Content-Language: en-US To: Chenbo Xia , References: <20230612051127.44418-1-chenbo.xia@intel.com> From: "Burakov, Anatoly" In-Reply-To: <20230612051127.44418-1-chenbo.xia@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0448.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::28) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CYYPR11MB8329:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ca0d14e-54e8-4f2e-82da-08db6b2a1032 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qdXToU0GOfnHzP0xpiyIeOQtAxOzAhh62sMoNl13zklaLOmRbLssIGu5dN2tx5+ESm/4iSod1fpI5fuKnzO9ahExMO/8ManKb1wCMgysS7xfJ8q0YmKzsUgbAUvldQimGXQqMqGlFw8yeNVZF5394PXjrpzheid2JdF5qTUg5ku46wF9z1aMtVTeuaZe21HfNkyHggGer89LXS6aSNP225W66OmWOvAhjoEcxVz9qnnOymeLVVHocWxtPMLfCL25ChKvQfiFtgJT0EPELG196Zv4xm0mqkx8Ggp8aHVTBgkTemXMU+coEldaCJDqt8UwX+MaSTWnRUIT338QG8RRTNkQwgkNVdYsmW4NeM8URrn71EBQW1ivYOzzpLbPbSwNiIfiqHNXokjJQGUkLq5Xlq1PyC03G1fL6aEGeDWpNxI+kFFMxcvfjsfDgI0kS9/WJnylg9+IfcYh0MlhQK42yKIITNUtt87XPFoZeQmIskiEtHRRe5LxJFTkelKDPDFR0vXlaZ733n83cMK45hByrSw6sKPNFoBAWeKGqsvJ2i49Pu6et1GXQDOHv37gufFYMQxA3/u+AJ+NPJcDKnLKl157nLdMpz1wxFY4oHlMlnXBdacN8ZOyCR2ngvtrDSP5Tp2yt10/xivUvP6lgw6yag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(39860400002)(366004)(376002)(396003)(136003)(451199021)(86362001)(31696002)(6512007)(6506007)(53546011)(2616005)(26005)(38100700002)(82960400001)(186003)(478600001)(6666004)(36756003)(6486002)(2906002)(4744005)(41300700001)(316002)(8936002)(8676002)(66946007)(31686004)(5660300002)(66476007)(66556008)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2w0WUNQeFVnQWdmVE9qMkV0aExoRUYvZUdCeG9wL0w3N050Zm1wQnZyaWhP?= =?utf-8?B?QUdNTVgyYk9xVDRKdURtM21DdmMwRTVNUGNvZGt4TnRCcWFkYUQ4SVR3U2N5?= =?utf-8?B?dko5WnNsWFhUT2pFM3dXRjZySlFrUlRtdW5IZ0hHc2ZTVzY1Q0dJZmlxUy9x?= =?utf-8?B?NlRORFZYNkRnSFRoOFRXY3gvOU54OHZKWWhoL2VidElEcVBDYkxXb3NMVTN2?= =?utf-8?B?dWwrWURoMmliN2ZDT2pyc3ZDU0MzdW8vTnlYK2xYRVJlbm9GVVZ2TGRERTBX?= =?utf-8?B?ZnRVUERrakxPYi9GZ1djaDJ6ZWFoUzAvWnJ6UzFsa1JDS3lOZ3VNUjhUcURC?= =?utf-8?B?dzUzSlNBcVZrUkRhQXVBTy9mSHZKMS8yK0hYTjNMVUl4MmVDL3lJNE1GWUVS?= =?utf-8?B?MnM0ZktCejJqZ1Z0M0tWUHR3aXNZbDMwZjgvYy82Mm1Nb1IyRDBvWWNkcGF1?= =?utf-8?B?OUVUd01CaEZiNHZVWUUvRVdEVzZEc2NtN2x5WEhXamdBWWVyUVYxVzNsc0Y3?= =?utf-8?B?RStzVGlza0NXbFNGVzRIdEs3SGN3bVcrZ1J5Vzk5dzV6aDhlU3ZCbFJmd0Ex?= =?utf-8?B?OWtabHVRZ2lyOVd4emxrckdpVjJmS1hBMVRmc3hVVmxWRkpPZlM1TmZVS0Nm?= =?utf-8?B?WkFsWUNYbTZpam53YWRFa2JKMG1ieFkzRjlYWWZoRjBxa1NCM2pTUXcwREY5?= =?utf-8?B?cGcwbGVGSmQvTnJiZGdDOXlVSDRLM2x0TUtTVm5FajNKVzB0b2ZaSFBOZEp2?= =?utf-8?B?UEFGWi96L1l0ZzhraVRIb2RrR2g4Qjc1SWZnZFQ0VnJ0L3Y3eWEvay81T3Ny?= =?utf-8?B?dE9qNWdDYWZ1SE9qS1NsaEQxQjJod01jK21IclBEcWlrUGZmMGlOaG1DNkRO?= =?utf-8?B?U1JoWXFhMEpTalZZSkZ5bXhPWnI1NXR5K2lSNnJiRHc4eHJkeHZUZ3B6TkpD?= =?utf-8?B?c096ZUFtZHR6VGpLdDFDRm85YVNKaDVaU2x2amlnZktRNy9mY1lrckdqc1RO?= =?utf-8?B?Q3VsbEpnOGV1REl6MExFQlZ1VnRnOFVKTG1PQWliNnNYczk0RUJGMm9nUW10?= =?utf-8?B?bmgyV3dSZ1JSUTFoYlJiT1lwdWp1K2F1S2pmZHViam1OSDM3MjJlZW9kUG9s?= =?utf-8?B?aFFCK0VDNGI1cHBhQmswYzNqQ2xmS3VhRlZ2cDdrVk5qMkxvVUliSDJmaktr?= =?utf-8?B?aVhWQUE3Tlp5eTBXS3Vzd2MxOExMdWtvTVYwRUQ2aGNnYmlzMVYzVE9pc0N6?= =?utf-8?B?ckZVaXM2RUtEUTZyVWtBMnhwMmR6RzlxaHpZaXdWOE5TMnNGeWNpdkhIT20x?= =?utf-8?B?c2dIRWJJd1A1UUtpMFVkdEhJSzVFNUhsd1pYSTd1S2R5UWxRTkN1blltaFox?= =?utf-8?B?RllUbFBrOUNwZWVaNlBUNDRSNmJoeUM2eDByeGN5VnhiNDlhUk55TFh3RlFp?= =?utf-8?B?SkhCZ09rTktjdk15bGlXUitBMTVoYnY1YlZJVm5MRXA4WUI2VlczWXRTbEpt?= =?utf-8?B?OU81c1NzQjkvY3ZFbExiQ2IzZUF5ODlvd1pNT29DL3I1OUYrZGFNTW11QllD?= =?utf-8?B?YlNQNkJZT0x5SEpWMTNMbnB0Mk1KS2Z5TWJLSlU0L3RYQXJ5akRsRmNqekc0?= =?utf-8?B?M0Y0UjRnaEk1UEdIWFBiaDVMcXhyWmF5bndIMnBic3I3UENiNXZFcFc1NkY1?= =?utf-8?B?SzVHbnNveGM4Q0dpNEVWTWt6aHlINWNtQmhPR29wc0lObzhQaHZ2Y3BEVTVO?= =?utf-8?B?UG9kUm05QmNuVlNVT1JkWkpXZGo0U1RtY24zeWZiUXlZRGZjRkpNTFRPZjIz?= =?utf-8?B?V2JRQnNSZU10LytVUkt2TndlQUh5R0Q5eGkrdW9nSXFyQ1p6Sk5xaEhPc05r?= =?utf-8?B?SHo0WlFZcnBTVXFXZ1o5aEwzS1Fzc0lPcmRLS1M4eEViMmZtclRqOXIrVStU?= =?utf-8?B?V1JUK3N6V25UL2UwNVZaaU13ek9Ma0NIaGFOYUFWNmVpcXV0Q21ITUh0eFo0?= =?utf-8?B?MXJPWEtoOW5nSzltWnlJaTc2Z2dIQm1tZUNSbXFFM0tHamd4ZWMwNzdMeUhR?= =?utf-8?B?MFVWNWY1WFU2T3kvVHJDVXpOc0xHK29aanNhSHJPWU9XOGJBRm5QMlR0UGpW?= =?utf-8?B?WEhHanRYWWF0VU5LZ3pjdjVqSTJuV1k2K2x6VlFXTW9rTzVyeDVEc1dJb2RI?= =?utf-8?B?L3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5ca0d14e-54e8-4f2e-82da-08db6b2a1032 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 09:47:41.1532 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WJcbFaDkejhHoKaWmSr7jUPyM7sqXf/r68yhYCgIoUeqTceVV5o0JxN6m4LPB5tC7TsE8TsRiZGL3iRKYVoPBYOux4yixNB9tJKI6emErmA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8329 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/12/2023 6:11 AM, Chenbo Xia wrote: > Fixing return value check of rte_intr_dev_fd_get() to make sure > negative device FD will not be used later. > > Coverity issue: 385380, 385373 > Fixes: 095cf6e68b28 ("bus/pci: introduce MMIO read/write") > Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") > > Signed-off-by: Chenbo Xia > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly