From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 852F4A0C47; Mon, 25 Oct 2021 22:47:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5998B41141; Mon, 25 Oct 2021 22:47:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B7C3A4003E for ; Mon, 25 Oct 2021 22:47:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635194844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GtbZc+Wftsr5Ij3eeefCNVRoQxmrdLimlqcxlxza91o=; b=JkXiEDurAF2uQHAdrletlVhW9v2rUX+YxcP77uFzVnNqzFgZ6GFX4bd6tPkz4VaM9F1lIR HP+vszHxKPo+94v2l2f4h9FQmf0EFApIU7/pvihTbWhncFF6x4fP0P0v8s4qYloTygycpd M0Pf8eoH2MoqqLXmt0v0TEyjhJf1o7E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-MhmBrNNOO2KRCDQemOHrrQ-1; Mon, 25 Oct 2021 16:47:20 -0400 X-MC-Unique: MhmBrNNOO2KRCDQemOHrrQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EE5AF10A8E01; Mon, 25 Oct 2021 20:47:19 +0000 (UTC) Received: from [10.39.208.37] (unknown [10.39.208.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 797E119C79; Mon, 25 Oct 2021 20:47:16 +0000 (UTC) Message-ID: Date: Mon, 25 Oct 2021 22:47:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com, xuan.ding@intel.com References: <20211025203353.147346-1-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: <20211025203353.147346-1-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vhost: fix async DMA map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xuan, On 10/25/21 22:33, Maxime Coquelin wrote: > This patch fixes possible NULL-pointer dereferencing > reported by Coverity and also fixes NUMA reallocation > of the async DMA map. > > Fixes: 7c61fa08b716 ("vhost: enable IOMMU for async vhost") > > Coverity issue: 373655 > > Signed-off-by: Maxime Coquelin > --- > lib/vhost/vhost_user.c | 45 +++++++++++++++++++----------------------- > 1 file changed, 20 insertions(+), 25 deletions(-) > I posted this patch to fix the issue reported by Coverity and also other issue on NUMA realloc that I found at the same time. But I wonder whether all this async_map_status is needed. Indeed, if the only place where we DMA map is in vhost_user_mmap_region(). If it fails, the error is propagated, the mem table are freed and NACK is replied to the master. IOW, the device will be in an unusable state. Removing the async DMA map will simplify a lot the code, do you agree to remove it or there is something I missed? Thanks, Maxime