From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F6C841EB0; Thu, 16 Mar 2023 13:20:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED51840DF6; Thu, 16 Mar 2023 13:20:48 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2060.outbound.protection.outlook.com [40.107.212.60]) by mails.dpdk.org (Postfix) with ESMTP id 292F040A89 for ; Thu, 16 Mar 2023 13:20:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eaNvO7S6qCn+i2EFCSRHyTQ3q4qvQc/b0nRaU+QRDi+om9m5Gg6Ps1DUdyTnn+dk9I+8GpMKQOrW1V0Oef4/n569a6VqtN5fE6Ti/ydf9m1P+qf0WPRBkueyC3ZbfI/1ACjLvCNSJLuUFbZO0RWsgW/BsH+GOFbVIJR1jIYgx7UEPsNGNMUQp7RwS4Cq1CLWS9d4vfvbVer5aFr6zUH+6AxMNyljyTlPoOFq1KtfsFrqaLYF9rAc3af6Yfx+QqJ3j2RY7UfaP+WDgkstcMJv93pJ1xqNsJ3Y4vNsMIdOgqffFT1jhhhsb+6VmOQQusMuD9SmflVxp9909x5hMzPP1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AJZnAQuAEg2tiu5h+FuZb2mrx490DeZvFQWzzgAwJzg=; b=NjG5pnQbeaRVqFIFtkCcuARyS+crFo+ukvQx8rD+5rTX8Mm7uluWFK8QknEspEOLDS2xbq2QTbeQX10W0P3ZN1ecvuN2DdkXrFlkaOPtoPUvCumfLYg/Ocw9H73fMARYOguQ5g0bPLFx2U66yGEezIDoXtSl4h/meCgHTXNtZyZWPuaKIVDFcojC5FMEPFU+FLj74ymDU8xprCqg//INKMi+mAc2tSoxTX/+/eJ2I6Q5EL7Z0SmC9LBkvC7BYBUVp3HyJyrUHg53/YUQRqC9w+CxK2KrN/zZgRFj0XdwVgMgjY5QUkrXUwUCMGY/OkIcWxvDBIj43jwztKCBQ7Sxsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AJZnAQuAEg2tiu5h+FuZb2mrx490DeZvFQWzzgAwJzg=; b=3tLroVEE2+LYireTb+vvDVyw2Z62yswWrLW6nvbN5dCncUR/gVTV6GD/dRUFJkdpATVhwNXinnLMAPRcI7YzVJmYg8d4/8P21wydBxDzg8WZmugkeCIcOJSWMPYvT6LE0do0kbXZcWWuWeVaFvhVOUHa7NtouSikfrEpegztnMQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB6745.namprd12.prod.outlook.com (2603:10b6:510:1c0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Thu, 16 Mar 2023 12:20:46 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6178.026; Thu, 16 Mar 2023 12:20:46 +0000 Message-ID: Date: Thu, 16 Mar 2023 12:20:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 0/2] Fix testpmd interrupt regression Content-Language: en-US To: Stephen Hemminger , dev@dpdk.org, Thomas Monjalon , David Marchand References: <20230313171905.67720-1-stephen@networkplumber.org> <20230315173132.4044-1-stephen@networkplumber.org> Cc: Pier Damouny From: Ferruh Yigit In-Reply-To: <20230315173132.4044-1-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0030.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB6745:EE_ X-MS-Office365-Filtering-Correlation-Id: de66bc1a-574e-4f14-91b2-08db2618de7c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WXwWcdE5z+QkZNiq0b6NabQ+fk4jwC9K56ivcNEh6HZVy9UhNN9GyT0p41Dou9KaDVunMD+PiVGMy54/oaF9fRrEz09ymzzNRJO4rymdiLYPJ7ihA7LADPEveXFAQ67RxSnkCFJfrR0gyuyO1lz/B5dvrbEf2wL8Zb4DhzRSz8Eqe3SzFo/MNM728juO23Ryps+UT+Yo+8IF7EL/wwJVHAd1BoCoGMej4h326rLoIE2DHhxhGLSVeF8EVXUdWd/gH/URmJ9lCm5bl/d/BHBJylxGhNYV1HGF6pPZMZrq6gIFc+1uN/3kIOJDQ6QFKT05NAQuymiDgvEcL0OVZQhAzpdrEn6T9X4KwBv85WFNZ536J2LggZJ2NSSbgIJXEqmX7DRSYpjfvGdHjwTChevhHvOLk9Cczhs5rpab35QWeE3+pNIfYQ7hr9trTBvaDRG13WC9APslRAWR6mCLZp6DJEGjpixC9J6fuX/R4t7oZTexLk5RxAJIwzfUh8QsUZkYpszwj6iNAEpJxPgBSNaIpGn0lWZNPOrUm0Qo7r3wbMcaWV3zdnQdeDdE2WBbpXBf7MnmYynU5E3LvpABuFuudc/uaiVocEIoj3VVn6i0V6z0fq/O3kYRqo46TnT6prAf2h6aAZ5dZLkMd13IVYiLz4xA/aly3F2apA6YjMk+c6ZxQBQApnpUFBmsvLksxrUH0sotoY2BidbiJefv3nVHdD4bMQTCfF5OMizZDoJSZqI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(396003)(39860400002)(366004)(376002)(346002)(451199018)(31686004)(44832011)(4744005)(8936002)(2906002)(41300700001)(38100700002)(31696002)(86362001)(36756003)(5660300002)(6486002)(478600001)(6666004)(66476007)(8676002)(4326008)(66556008)(66946007)(2616005)(6512007)(53546011)(110136005)(316002)(83380400001)(6506007)(186003)(26005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUIrRjdLeTM1aDBHQVA0UnE4VDkvNHh4R2Z2Und4N3I2OURYWk5OVE9hVzE3?= =?utf-8?B?MjVsS2hzcEtmV0ppbnFIRjM4eTBDYkFQaUU2TFA2dGE3cmo0bEtYWHVEaG82?= =?utf-8?B?MGRIa25GRktNMGVZcFRDMExsNGFzUTBxS0hDRlcwaGwyRiszSUduakFyWTBU?= =?utf-8?B?ZENvdkpPVHFveHhxWm1ib0YxR0I4aVpOM1FLYnl0cWFIVStaS1hISk00RU94?= =?utf-8?B?WmxvZkRISVVaZGUvekpjd2UwVDZNbnFYcGZUWHdPUnZ2OUJLanplOGE3RVFR?= =?utf-8?B?N3hEdEpXWEFqanlDWXR5cXVlMDZRQlhtVzlRMFZqYWRJUitHSUJNY3Y0eVVF?= =?utf-8?B?dkpSQmR3eGFRdkFLQ2tWY0tZdEx5bFpvZmZDbGNSakNzWG4xL3o0cldqblk4?= =?utf-8?B?MlU4R1NwL1BaWEllRUR1M0RROUZLSWppT0FSakRXTiswVUxYWWZjcnRRWFQv?= =?utf-8?B?RVZVNnVITER1MTg2czFkNCtoaHBVN1FrdzA1UTNBellxMngrY2t0U0x5U3dz?= =?utf-8?B?TWhLL1ZkUjFBYVRpSnpSeUxTaUJyNlhydFp1TytCVDYwYmFMNGx4eEo2L2tj?= =?utf-8?B?WGQrWTMwSkJrVkNWVkM3Z0xYRXB0MFl3aFF3Ynd1VGM0WHl2anhvM1VIUmtG?= =?utf-8?B?MDV6MEJyQlNOTDcvbTVob2JrNGxoSGw2cnF3eW8rS2p1cExwN3FmVlgxai9i?= =?utf-8?B?YVZ0c0ZLSHlEQWtsQlBiOEFOd1h6WnBVbmZsUTZoaGh3b0d1WjYzMUl0MUJR?= =?utf-8?B?TDRyWW50WVJIYm5lbjFsRmcrclNDa0hzM0d2TkxZdGQrSEtXR1BqUk51YjdS?= =?utf-8?B?TGx4WDNacnBnZW9XYUp2UzlIdTJRVXM4a1d2UENGSnRiWkpwTXRFSVdFajZ3?= =?utf-8?B?bjErV2dTVGdpWWhhbkQrdGJORWg4Yk15SmhmTm9Xa2U5UHpQVDlsSWNURUkw?= =?utf-8?B?cDNacURHdm9XYVAzeFFNMTBQV2N6UjFBRyt0VmlkZEExR2ZaUlZJV05hd3dH?= =?utf-8?B?Y05XWnBiUUZUWmF3cG90RmRqRk1PLzU0MmxRRnNXZFJJNWtDRktFbEhJY1BN?= =?utf-8?B?L2RGT202VWNtY2RjVVpMRDFseGFadXpJOUZwYXJ4Sys1T0xkV1BHWGp4UHFN?= =?utf-8?B?UUExUUZGSlkyR0RxaXdiN0pMa0lnSmJoeDFuNkpyUDMzYmEybmZ2c2ZBRFRG?= =?utf-8?B?ZE5lb0MzeGVGVFBXdUZCWEV6bU5tcUJCMW1pRUYva0tGdG5DeXJrc2Q1ZUNV?= =?utf-8?B?VlJyOVpHRjluVVUwa09rbXpkUDlUaldEcDJTVVBSaXpqZjNMbjljQkJndWpr?= =?utf-8?B?S1c4RGNZUlFWajg5VmFmblFzc1RZSSt0ZCtDdEJiUjN0UVduWFJVM3BuMXVW?= =?utf-8?B?Y0xVZmFsbzgvRTZpL3E5ZS9MNkFGaERPVjIyUmdNa3BRdjlqTzZPTjdYYWoy?= =?utf-8?B?NEk5NjFJdlVobWJIclFwcExSOTBWUzR1dTBnT2hwR1pIZHlIMFQzcHVpb2lX?= =?utf-8?B?QTM5eDNiTW5Lck9HblhaRWJTZzhoMGhuTUJTSjJINGhPcWRMZ2RIUkd6d1Nl?= =?utf-8?B?NkhsR2VqRzdEUDUra3M3TzMvUEliVzlWMFcyYmhCbERsN2VUOU5HUUo2YnFN?= =?utf-8?B?ZTBFRjVOV21XSllmOEtNUVk3WGhXNVZwTndoOWpVT3d5d2VxdThncE5WVUlx?= =?utf-8?B?MmMrcVNaVEMwcE9GNE0yeHJobUp6Z3Bja2I1bDkwRTI4RStaTDB1VUNvOEdD?= =?utf-8?B?V1ZwNC9ObFZtVzI5eVQ3WnN3WUhibC9wM0NvYStyRVZhUDV1OUNkUng1Vy9s?= =?utf-8?B?MVdXTnkxdTRxcWpORVdpYXA2NkI4S0Rybmk2QTdScTEza09yaDlBSUozbG9q?= =?utf-8?B?SU0wRFBMUzBreVJBb05FbXlZTlhzRnVsdjdXR3V4UDMxQStsZUZTNjY1NDhx?= =?utf-8?B?Y01RdlB3Mi95U1J6TCtHR1BQVmcyV0xuOUxzbE9CVTBoNXB4NkRUaURDcGIr?= =?utf-8?B?QTBrczlaK1pnZ2VhOE52V05CRnp4bFJuYTNVRFBoMHA0bERHOGN0ckhwWU5o?= =?utf-8?B?aFpyY29lOFBoVWRsSWJJWXdDV05CYXVSK1JEWTRWTW8zWHFkLzVDUU1tRTNy?= =?utf-8?Q?9FnJEzF+9jy00XnbkospeKb0Q?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: de66bc1a-574e-4f14-91b2-08db2618de7c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 12:20:45.9644 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2jhWwIhB2eTpSVN7Tzn+/cmO+ioo45sd00j4myyx6V4jH4gGwV/37vV2HjC3Gihu X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6745 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/15/2023 5:31 PM, Stephen Hemminger wrote: > Resolve issues from using control-C in testpmd. > Fixes regression from recent change to use cmdline_poll(). > > v4 - drop sig_atomic_t. Not required requires changes on > some platforms. > > Stephen Hemminger (2): > testpmd: go back to using cmdline_interact > testpmd: enable interrupt in interactive mode > > app/test-pmd/cmdline.c | 27 ++++++++++++++------------- > app/test-pmd/testpmd.c | 11 +++++++++++ > lib/cmdline/cmdline.h | 10 ++++++++++ > lib/cmdline/cmdline_os_unix.c | 8 +++++++- > lib/cmdline/cmdline_os_windows.c | 18 ++++++++++++++++-- > lib/cmdline/cmdline_private.h | 2 +- > lib/cmdline/version.map | 3 +++ > 7 files changed, 62 insertions(+), 17 deletions(-) > This solution is adding new cmdline API for -rc3 and there are some testpmd changes, can it be possible to have a simple workaround specific to window for this release and get this set for next release?