From: "WanRenyong" <wanry@yunsilicon.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>
Subject: Re: [PATCH v2 05/19] net/xsc: add ioctl command interface
Date: Thu, 12 Sep 2024 12:07:15 +0800 [thread overview]
Message-ID: <fb70a79c-f339-44d7-9e55-80d79bf120f0@yunsilicon.com> (raw)
In-Reply-To: <20240910204842.6e965a48@hermes.local>
On 2024/9/11 11:48, Stephen Hemminger wrote:
> On Wed, 11 Sep 2024 10:07:26 +0800
> "WanRenyong" <wanry@yunsilicon.com> wrote:
>
>> + hdr = rte_zmalloc(NULL, alloc_len, RTE_CACHE_LINE_SIZE);
>> + if (hdr == NULL) {
>> + PMD_DRV_LOG(ERR, "Failed to allocate xsc ioctl cmd memory");
>> + return -ENOMEM;
>> + }
>> +
> This is local to function, use malloc() not rte_zmalloc().
> It doesn't need to come from hugepages.
Hello, Stephen,
Thanks for you review, will fix it in next version.
--
Thanks,
WanRenyong
next prev parent reply other threads:[~2024-09-12 4:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 2:07 WanRenyong
2024-09-11 3:48 ` Stephen Hemminger
2024-09-12 4:07 ` WanRenyong [this message]
2024-09-11 3:49 ` Stephen Hemminger
2024-09-12 4:07 ` WanRenyong
2024-09-11 3:50 ` Stephen Hemminger
2024-09-12 4:14 ` WanRenyong
2024-09-12 5:50 ` Stephen Hemminger
2024-09-12 8:19 ` WanRenyong
2024-09-12 9:18 ` fengchengwen
2024-09-13 2:55 ` WanRenyong
2024-09-14 2:54 ` Stephen Hemminger
2024-09-14 6:33 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb70a79c-f339-44d7-9e55-80d79bf120f0@yunsilicon.com \
--to=wanry@yunsilicon.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).