From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74FBBA0548; Tue, 31 May 2022 18:47:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3055E40689; Tue, 31 May 2022 18:47:12 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 914EE4067B for ; Tue, 31 May 2022 18:47:10 +0200 (CEST) Received: from [192.168.1.38] (unknown [188.170.81.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E37F886; Tue, 31 May 2022 19:47:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E37F886 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1654015630; bh=Au0fahU7E/uJ3KyoeHHFIiZFG3Yx1jwINt3ngOHbUzI=; h=Date:Subject:To:References:Cc:From:In-Reply-To:From; b=aa68d3S9Dg7IT+055evWaJ0+fOigZ+sqV2GCSX8HJ6GTClPBR53/hgCm9guN+09j3 Gxfy+2HSAZm7QHE5jWqDYiaDJxa7FQay9DAuOiYvx0c17V7l4gq7bb8Uaro7oewGPU ozhRkI+spc6ga2KjDXUndJEs0ikL4M2U2eIL2Qxk= Message-ID: Date: Tue, 31 May 2022 19:47:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] kni_net.c: use netif_rx() instead of netif_rx_ni() Content-Language: en-US To: mingli.yu@windriver.com, dev@dpdk.org References: <20220511112334.3233433-1-mingli.yu@windriver.com> Cc: Jiri Slaby , "Min Hu (Connor)" , Ferruh Yigit From: Andrew Rybchenko In-Reply-To: <20220511112334.3233433-1-mingli.yu@windriver.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/11/22 14:23, mingli.yu@windriver.com wrote: > From: Mingli Yu > > The netif_rx_ni is removed in below commit after kernel upgraded > to 5.18, so change accordingly to fix the gap. > 2655926aea9b net: Remove netif_rx_any_context() and netif_rx_ni(). > > Signed-off-by: Mingli Yu > --- > kernel/linux/kni/kni_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c > index 7fcfa106cb..58e8fe5af6 100644 > --- a/kernel/linux/kni/kni_net.c > +++ b/kernel/linux/kni/kni_net.c > @@ -368,7 +368,7 @@ kni_net_rx_normal(struct kni_dev *kni) > skb->ip_summed = CHECKSUM_UNNECESSARY; > > /* Call netif interface */ > - netif_rx_ni(skb); > + netif_rx(skb); > > /* Update statistics */ > kni->stats.rx_bytes += len; There are two more patches [1] and [2] in the patchwork on the topic and it looks like the latest is the best one. Do you have any comments on [2]? [1] https://patches.dpdk.org/project/dpdk/patch/20220521070642.35413-1-humin29@huawei.com/ [2]https://patches.dpdk.org/project/dpdk/patch/20220525102641.20982-1-jslaby@suse.cz/