Re: [dpdk-dev] [PATCH] net/vhost: enable promiscuous and multicast by default

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 2/26/20 2:45 PM, Xiaolong Ye wrote:
> With this patch, the promiscuous and multicast fields are initialized as
> enabled for vhost PMD by default, this allows the devices to be used when
> running applications that attempt to enable promiscuous or multicast mode.
> Similar things have done for other virtual PMDs by commit f165210321c4
> ("drivers/net: enable promiscuous and multicast by default")
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>  drivers/net/vhost/rte_eth_vhost.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index 458ed58f5..fcf317151 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1331,6 +1331,8 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,
>  	internal->disable_flags = disable_flags;
>  	data->dev_link = pmd_link;
>  	data->dev_flags = RTE_ETH_DEV_INTR_LSC | RTE_ETH_DEV_CLOSE_REMOVE;
> +	data->promiscuous = 1;
> +	data->all_multicast = 1;
>  
>  	eth_dev->dev_ops = &ops;
>  
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime