Re: [dpdk-dev] [PATCH v3 00/19] Add advanced features for Huawei hinic pmd

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 9/30/2019 3:00 PM, Xiaoyun wang wrote:
> This patch set adds advanced features for Huawei hinic pmd,
> such as VLAN filter and VLAN offload, SR-IOV, FW version get,
> set link down and up, Flow director for LACP, VRRP, BGP and so on.
> 
> --
> v2:
>   - Fix RSS bugs for vxlan packets inner type
>   - Add comments for new added func interface
>   - Fix code review comments from patch v1
>   - Fix code style problems
>   - Remove ceq interfaces and definitions that not used
>   - Fix aeq init bugs, firstly alloc aeq resource, then set aeq ctrl len
>   - Fix bar map bugs for VF Page size larger than PF
>   - Modify link state set, add enable or disable fiber in tx direction 
>   - Fix mbox and mgmt channel sync lock mechanism to reduce CPU usage
>   - Fix FDIR bugs for VRRP packets
>   - Fit ABI changes from dpdk lib
> 
> v3:
>   - Split hinic.ini and hinic.rst to related feature patches
>   - Add min_mtu & max_mtu initialization for hinic_dev_infos_get
>   - Fix fdir config patch with net/hinic/base
>   - Split link patch into link and fw version getting 2 patches
>   - Update pmd doc files to new next version 
>   - Add comments for cover letter patch
>   - Add rxq & txq info getting interfaces
>   - Fix load intrinsics for receiving packets
> 
> Xiaoyun wang (19):
>   net/hinic/base: add mbox command channel for SRIOV
>   net/hinic/base: add HW interfaces for SR-IOV
>   net/hinic: add VF PMD operation interfaces
>   net/hinic: add VLAN filter and offload
>   net/hinic: add allmulticast mode and MTU set
>   net/hinic: add unicast and multicast MAC set
>   net/hinic/base: add fdir config interface
>   net/hinic: add fdir validate flow operations
>   net/hinic: create and destroy ntuple filter
>   net/hinic: create and destroy fdir filter
>   net/hinic: flush fdir filter
>   net/hinic: set link down and up
>   net/hinic: get firmware version
>   net/hinic: support inner L3 checksum offload
>   net/hinic: support LRO offload
>   net/hinic: add hinic PMD doc files
>   net/hinic/base: optimize aeq interfaces
>   net/hinic: optimize RX performance
>   net/hinic: add support for getting rxq or txq info

There is following 32-bit build error because of the log formatting [1], can you
please check it?


[1]
.../drivers/net/hinic/base/hinic_pmd_mbox.c(659):
error #181: argument of type "unsigned long long" is incompatible with format
"%lx", expecting argument of type "unsigned long"
                        PMD_DRV_LOG(ERR, "Fail to send mbox seg, seq_id: 0x%lx,
err: %d",