From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id CB7BA2A58
 for <dev@dpdk.org>; Fri,  6 Jan 2017 16:55:10 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga105.fm.intel.com with ESMTP; 06 Jan 2017 07:55:08 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,325,1477983600"; d="scan'208";a="1108893812"
Received: from rhorton-mobl.ger.corp.intel.com (HELO [10.252.15.105])
 ([10.252.15.105])
 by fmsmga002.fm.intel.com with ESMTP; 06 Jan 2017 07:55:07 -0800
To: "Yang, Qiming" <qiming.yang@intel.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <1482841816-54143-1-git-send-email-qiming.yang@intel.com>
 <1483531428-14481-1-git-send-email-qiming.yang@intel.com>
 <1483531428-14481-6-git-send-email-qiming.yang@intel.com>
 <416747ed-2df3-10d9-5f01-39e77c84b66b@intel.com>
 <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDC9DDB@SHSMSX101.ccr.corp.intel.com>
Cc: "Zhang, Helin" <helin.zhang@intel.com>
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
Message-ID: <fbc2aa5c-5ccf-640b-bce6-89c744db1ad4@intel.com>
Date: Fri, 6 Jan 2017 15:55:06 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDC9DDB@SHSMSX101.ccr.corp.intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 5/5] ethtool: dispaly firmware version
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jan 2017 15:55:11 -0000


On 05/01/2017 01:31, Yang, Qiming wrote:
[..]
>> +	if (strcmp(drvinfo->driver, "net_ixgbe") == 0)
>
> Do you need this check. I think it is not good idea to add this kind
> of checks into ethtool app. Why not just print "%d.%d.%d %#X, major,
> minor, patch, etrack" for all cases ?
 > Qiming: because I want to keep the format same with kernel version 
ethtool.

My feeling is that if we're going to have driver-specific output, then 
the task of constructing the string should be pushed down into the PMDs. 
It would also solve the headache of trying to standardise, as Thomas has 
mentioned..

..Remy