From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3FCFA0503; Fri, 20 May 2022 08:59:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 737AD40156; Fri, 20 May 2022 08:59:28 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id CEA6240151 for ; Fri, 20 May 2022 08:59:26 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 2BBE58A; Fri, 20 May 2022 09:59:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 2BBE58A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1653029966; bh=5DGrmUKapECsn0DCzXdCZml+MutpXYxQyKpiHbcEL2g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cIazaG11EQVQ76teSG9q21j5CReU2wGaq55Gn499BYXb1SQdo0l829nVa3B3mXZUi XjSVeyg5ZCv4jE8w0DJvlPp4msBQHX0yxlQuRhPd/yFjyLWKK9e8gAh3og0ggYKsI2 /oWP7YWvOqyO5Zn7SeuQUH5Ayjgkvn/sgsY5KH28= Message-ID: Date: Fri, 20 May 2022 09:59:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [RFC PATCH 2/4] net/bonding: move testpmd commands Content-Language: en-US To: Thomas Monjalon , Konstantin Ananyev , David Marchand Cc: dev@dpdk.org, "Min Hu (Connor)" , Xiaoyun Li , Aman Singh , Yuying Zhang , Chas Williams , jerinj@marvell.com References: <20220513075718.18674-1-david.marchand@redhat.com> <581f038e-a50a-175e-8336-c82f617954f5@yandex.ru> <2187851.KTMopqUuYO@thomas> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <2187851.KTMopqUuYO@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/19/22 14:26, Thomas Monjalon wrote: > 19/05/2022 09:40, David Marchand: >> On Thu, May 19, 2022 at 1:25 AM Konstantin Ananyev >> wrote: >>> 18/05/2022 18:24, David Marchand пишет: >>>> On Fri, May 13, 2022 at 12:10 PM Min Hu (Connor) wrote: >>>>> >>>>> I think net/bonding offer 'API' for APP to use the bonding. >>>>> and use the specific PMD as slave device. >>>>> The software framwork is like: >>>>> APP >>>>> ethdev >>>>> bonding PMD >>>>> PMD >>>>> hardware >>>>> >>>>> so, I think cmdlines for testpmd should not put in net/bonding.be > > The bonding API is specific to drivers/net/bonding/, > so according to the techboard decision, > the testpmd code should go in the driver directory. +1 > >>> Actually, I feel the same. >>> I do understand the intention, and I do realize it is just location, >>> but still doesn't look right for me. >>> can't we have a special sub-folder in testpmd instead? >>> Something like app/testpmd/driver_specific/(ixgbe)|(i40e)|(bonding)... >> >> That should not pose a problem, indeed. >> And, on the plus side, it avoids putting some testpmd global variables >> in meson (which I was not entirely happy with). > > I like the global variables approach. +1 > >> But, on the other side, I have a concern about MAINTAINERS updates. >> >> (almost) everything in app/test-pmd has been under the testpmd >> maintainer responsibility. >> Separating the driver specific code from testpmd is a way to clearly >> shift this responsibility to the driver maintenance. > > I agree. +1 > >> One advantage of moving the code to the driver directory is that there >> is no MAINTAINERS update needed. > > Yes I think moving test code in the driver directory is smart. > We already have this approach for some self tests run with app/test. > And more important, the techboard has decided to move code in the driver > or lib directory: > https://mails.dpdk.org/archives/dev/2022-April/239191.html > >> If we keep those in app/test-pmd, it is still possible to mark the >> driver-specific sources in MAINTAINERS, but such updates are often >> missed. >> I can probably add something in devtools/ to catch those updates in >> the future... >> >> I'll try for RFC v3. > > >