From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED4BDA0613 for ; Fri, 27 Sep 2019 20:31:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C01501BEA3; Fri, 27 Sep 2019 20:31:07 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A8E8E4CA7 for ; Fri, 27 Sep 2019 20:31:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 11:31:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,556,1559545200"; d="scan'208";a="202112418" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by orsmga002.jf.intel.com with ESMTP; 27 Sep 2019 11:31:02 -0700 To: "Wei Hu (Xavier)" , dev@dpdk.org Cc: linuxarm@huawei.com, xavier_huwei@163.com, xavier.huwei@tom.com, forest.zhouchang@huawei.com References: <1569506528-60464-1-git-send-email-xavier.huwei@huawei.com> <1569506528-60464-19-git-send-email-xavier.huwei@huawei.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Fri, 27 Sep 2019 19:31:02 +0100 MIME-Version: 1.0 In-Reply-To: <1569506528-60464-19-git-send-email-xavier.huwei@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 18/22] net/hns3: add dump register ops for hns3 PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/26/2019 3:02 PM, Wei Hu (Xavier) wrote: > This patch adds get_reg related function codes for hns3 PMD driver. > > Signed-off-by: Wei Hu (Xavier) > Signed-off-by: Chunsong Feng > Signed-off-by: Min Hu (Connor) > Signed-off-by: Hao Chen > Signed-off-by: Huisong Li <...> > +static int > +hns3_get_32_bit_regs(struct hns3_hw *hw, uint32_t regs_num, void *data) > +{ > +#define HNS3_32_BIT_REG_RTN_DATANUM 8 > +#define HNS3_32_BIT_DESC_NODATA_LEN 2 > + struct hns3_cmd_desc *desc; > + uint32_t *reg_val = data; > + uint32_t *desc_data; > + int cmd_num; > + int i, k, n; > + int ret; > + > + if (regs_num == 0) > + return 0; > + > + cmd_num = DIV_ROUND_UP(regs_num + HNS3_32_BIT_DESC_NODATA_LEN, > + HNS3_32_BIT_REG_RTN_DATANUM); > + desc = rte_zmalloc("hns3-32bit-regs", > + sizeof(struct hns3_cmd_desc) * cmd_num, 0); > + if (desc == NULL) { > + hns3_err(hw, "Failed to allocate %" PRIx64 " bytes needed to " > + "store 32bit regs", > + sizeof(struct hns3_cmd_desc) * cmd_num); 'PRIx64' won't work with 'sizeof' because its return type changes with the arch, need to use %zx with 'sizeof' I am aware that driver doesn't support 32-bits, but build is only broken because of the format errors in the log formatting, I am for fixing them. Also using correct format type is good practice. There are following related errors [1], I am fixing them while merging [2] please let me know if you request any change in the updated code. [1] .../drivers/net/hns3/hns3_regs.c(167): error #181: argument of type "unsigned int" is incompatible with format "%llx", expecting argument of type "unsigned long long" hns3_err(hw, "Failed to allocate %" PRIx64 " bytes needed to " ^ .../drivers/net/hns3/hns3_regs.c(224): error #181: argument of type "unsigned int" is incompatible with format "%llx", expecting argument of type "unsigned long long" hns3_err(hw, "Failed to allocate %" PRIx64 " bytes needed to " ^ .../drivers/net/hns3/hns3_ethdev_vf.c(1625): error #181: argument of type "unsigned int" is incompatible with format "%llx", expecting argument of type "unsigned long long" PMD_INIT_LOG(ERR, "Failed to allocate %" PRIx64 " bytes needed " ^ .../drivers/net/hns3/hns3_rxtx.c(643): error #181: argument of type "uint64_t={__uint64_t={unsigned long long}}" is incompatible with format "%lx", expecting argument of type "unsigned long" hns3_dbg(hw, "No.%d rx descriptors iova 0x%lx", idx, ^ .../drivers/net/hns3/hns3_rxtx.c(1085): error #181: argument of type "uint64_t={__uint64_t={unsigned long long}}" is incompatible with format "%lx", expecting argument of type "unsigned long" hns3_dbg(hw, "No.%d tx descriptors iova 0x%lx", idx, ^ .../drivers/net/hns3/hns3_ethdev.c(4837): error #181: argument of type "unsigned int" is incompatible with format "%llx", expecting argument of type "unsigned long long" PMD_INIT_LOG(ERR, "Failed to allocate %" PRIx64 " bytes needed " ^ [2] diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 574eb9204..862a717fd 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -4834,7 +4834,7 @@ hns3_dev_init(struct rte_eth_dev *eth_dev) sizeof(struct rte_ether_addr) * HNS3_UC_MACADDR_NUM, 0); if (eth_dev->data->mac_addrs == NULL) { - PMD_INIT_LOG(ERR, "Failed to allocate %" PRIx64 " bytes needed " + PMD_INIT_LOG(ERR, "Failed to allocate %zx bytes needed " "to store MAC addresses", sizeof(struct rte_ether_addr) * HNS3_UC_MACADDR_NUM); diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c index 07a4b01d6..121beb58d 100644 --- a/drivers/net/hns3/hns3_ethdev_vf.c +++ b/drivers/net/hns3/hns3_ethdev_vf.c @@ -1622,7 +1622,7 @@ hns3vf_dev_init(struct rte_eth_dev *eth_dev) sizeof(struct rte_ether_addr) * HNS3_VF_UC_MACADDR_NUM, 0); if (eth_dev->data->mac_addrs == NULL) { - PMD_INIT_LOG(ERR, "Failed to allocate %" PRIx64 " bytes needed " + PMD_INIT_LOG(ERR, "Failed to allocate %zx bytes needed " "to store MAC addresses", sizeof(struct rte_ether_addr) * HNS3_VF_UC_MACADDR_NUM); diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c index d83eef339..23405030e 100644 --- a/drivers/net/hns3/hns3_regs.c +++ b/drivers/net/hns3/hns3_regs.c @@ -164,7 +164,7 @@ hns3_get_32_bit_regs(struct hns3_hw *hw, uint32_t regs_num, void *data) desc = rte_zmalloc("hns3-32bit-regs", sizeof(struct hns3_cmd_desc) * cmd_num, 0); if (desc == NULL) { - hns3_err(hw, "Failed to allocate %" PRIx64 " bytes needed to " + hns3_err(hw, "Failed to allocate %zx bytes needed to " "store 32bit regs", sizeof(struct hns3_cmd_desc) * cmd_num); return -ENOMEM; @@ -221,7 +221,7 @@ hns3_get_64_bit_regs(struct hns3_hw *hw, uint32_t regs_num, void *data) desc = rte_zmalloc("hns3-64bit-regs", sizeof(struct hns3_cmd_desc) * cmd_num, 0); if (desc == NULL) { - hns3_err(hw, "Failed to allocate %" PRIx64 " bytes needed to " + hns3_err(hw, "Failed to allocate %zx bytes needed to " "store 64bit regs", sizeof(struct hns3_cmd_desc) * cmd_num); return -ENOMEM; diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index b29d98a2f..184b8e4b6 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -640,7 +640,7 @@ hns3_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t nb_desc, rxq->rx_ring = (struct hns3_desc *)rx_mz->addr; rxq->rx_ring_phys_addr = rx_mz->iova; - hns3_dbg(hw, "No.%d rx descriptors iova 0x%lx", idx, + hns3_dbg(hw, "No.%d rx descriptors iova 0x%" PRIx64, idx, rxq->rx_ring_phys_addr); rxq->next_to_use = 0; @@ -1082,7 +1082,7 @@ hns3_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t nb_desc, txq->tx_ring = (struct hns3_desc *)tx_mz->addr; txq->tx_ring_phys_addr = tx_mz->iova; - hns3_dbg(hw, "No.%d tx descriptors iova 0x%lx", idx, + hns3_dbg(hw, "No.%d tx descriptors iova 0x%" PRIx64, idx, txq->tx_ring_phys_addr); /* Clear tx bd */