From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B47B2A00BE; Fri, 1 Nov 2019 12:35:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE0F31D41A; Fri, 1 Nov 2019 12:35:21 +0100 (CET) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by dpdk.org (Postfix) with ESMTP id 7696F1D413 for ; Fri, 1 Nov 2019 12:35:20 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id EB220B40056; Fri, 1 Nov 2019 11:35:17 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 Nov 2019 11:35:08 +0000 To: Thomas Monjalon CC: , Ori Kam , "pbhagavatula@marvell.com" , "ferruh.yigit@intel.com" , "jerinj@marvell.com" , "John McNamara" , Marko Kovacevic , Adrien Mazarguil , , References: <20191025152142.12887-1-pbhagavatula@marvell.com> <3078181.9TjvbByyqQ@xps> From: Andrew Rybchenko Openpgp: preference=signencrypt Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: Date: Fri, 1 Nov 2019 14:35:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <3078181.9TjvbByyqQ@xps> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25014.003 X-TM-AS-Result: No-13.304000-8.000000-10 X-TMASE-MatchedRID: CxmI61mtwh8eimh1YYHcKPZvT2zYoYOwt3aeg7g/usAutoY2UtFqGEid N4tJfaiReWGlWnB+Id8JjzL0wlyJ94pAMGiqcHEMSVHYMTQ1F1qpR2kMGcsw7djMMV3eZDNhHHB kYbWuUOqJkGn3E5qSPb4PXqiXD5cW8VU4DxKh+IC8coKUcaOOvS3ExqBs3388d6RFRE7vKfHzhh SlV42Ik/1kElCBVTgakJ/2H+NycvGWFjFUJMrS47E811R1QfVaf6iC0fNopZmOsn3xdINh6ijQS oDXfNBzyowii3wU8V8ESamgZBB8vt7Jizf4VVgFqg0gbtLVIa84eGohd7gjNqGmPY7vhWTEkYFS ppoYOfRKNUgU7kTjgCZ8k5L2PBALYrO1KENDMW5bUzvsaHW6Bi4LLRYXXCV6h2mzmMcgLKnsy7X Nyd8KQPD8Zlb8AK6tlBhsWAJ42VWv3BMAqDRn8lMsVuL5ry7dGIMg4+U4kbXLkl8e9W70ixxChM oIsTT1rep3cF5oylDUSReAPsBV6/UWuHlgOr4bKUnZzo2UQD0ZSo6PM4LsikE3/qvOjgFLHyhdz gpEN6MEBkK3KWwH3XutF4AfqV6ClmP4dSOrQfYjCTunWqncljyW+6AAWIU/CXjDiV/HPZyffgRi +5xRiCCVGpNI8RQd+CgQ9V90WthnMhlY0lmbf1quYTXbu6G2UbJBJIpagZLhWjjGhpcHL1DTKay i2ZF6oHc1SznvRR6/m+bccWVLkCFXb/D0c7S57T+j7/gPsPPJ5SXtoJPLyFAoBBK61BhcX5Cf1h G3zlo3Hfe43cC/Hy2gCAF6KmwH/6V3ZD7dFA+eAiCmPx4NwLTrdaH1ZWqC1B0Hk1Q1KyJHtBsf5 /UXJbVQu1GNZ+sie3/K3TeOMBiSwaOfQ5JqIRjmYJR4aPbWbdequMef/QvFyjmjhcaY9XZj28z9 eGZ+ X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--13.304000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25014.003 X-MDID: 1572608119-1LSInfl1blah Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/31/19 5:49 PM, Thomas Monjalon wrote: > 31/10/2019 10:49, Andrew Rybchenko: >> On 10/28/19 5:00 PM, Ori Kam wrote: >>>> -----Original Message----- >>> From: Andrew Rybchenko >>>> On 10/28/19 1:50 PM, Ori Kam wrote: >>>>> Hi Pavan, >>>>> >>>>> Sorry for jumping in late. >>>>> >>>>> I don't understand why we need this feature. If the user didn't set any flow >>>> with MARK >>>>> then the user doesn't need to check it. >>>> There is pretty long discussion on the topic already, please, read [1]. >>>> >>>> [1] >>>> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Finbox.dpdk >>>> .org%2Fdev%2F3251fc00-7598-1c4f-fc2a- >>>> 380065f0a435%40solarflare.com%2F&data=02%7C01%7Corika%40mellan >>>> ox.com%7Ce3f779d4b7c44b682d6508d75b9d8688%7Ca652971c7d2e4d9ba6a4 >>>> d149256f461b%7C0%7C0%7C637078604439019114&sdata=sYooc%2FQ3C >>>> kUZG3gRFPlZrm8xMfMB9gOWWex5YIkWhMc%3D&reserved=0 >>>> >>> Thanks for the link, it was an interesting reading. >>> >>>>> Also it breaks compatibility. >>>> Yes, there is a deprecation notice for it. >>>> >>>>> If my understanding is correct the MARK field is going to be moved to >>>> dynamic field, and this >>>>> will be way to control the use of MARK. >>>> Yes and I think the offload should used to request dynamic >>>> field register. Similar to timestamp in dynamic mbuf examples. >>>> Application requests Rx timestamp offload, PMD registers dynamic >>>> filed. >>>> >>> In general it was decided that there will be no capability for rte_flow API, due to the fact that >>> it is impossible to support all possible combinations. For example a PMD can allow mark on Rx >>> while not supporting it on e-switch (transfer) or on Tx. >>> The only way to validate it is validating a flow. If the flow is validated then the action is supported. >>> This is the exact approach we are implementing with the Meta feature. >>> So as I see it, the logic should be something like this: >>> 1. run devconfigure. >>> 2. allocate mempool >>> 3. setup queues. >>> 4. run rte_flow_validate with mark action. >>> If flow validated register mark in mbuf else don't register. >>> If the PMD needs some special setting for mark he can update the queue when he gets the flow to validate. >>> At this stage the device is not started so any change is allowed. >> I understand why there is capability reporting in rte_flow API when >> it is about rte_flow API itself. The problem appears when rte_flow >> API starts to interact with other functionality. >> Which pattern/actions should application try in order to decide >> if MARK is supported or not. > Why application should decide whether MARK is supported or not? > In my understanding it can be enabled dynamically per flow. Yes, it is per flow right now, but it is resource consuming to make a flow rule just to discard it and work without offload. The application already suffers and attempt to use hardware offload makes it suffer even more. Of course, hardware offload in application may be simply globall disabled, but presence of MARK offload allows to do it dynamically based on offload reported by PMD. Also I think that Qi has a good example for vPMD why MARK offload would be useful. >> The right answer is a pattern/action >> which will be really used, but what to do if there are many >> combinations or if these combinations are not know in advance. >> Minimal? But I easily imagine cases when minimal is not supported, >> but more complex real life patterns are supported. >> >> The main idea behind the offload is as much as you know in advance >> as much you can optimize without overcomplicating drivers and HW. >> >> In the case of OVS, absence MARK offload would mean that OVS >> should not even try to use partial offload even if it is enabled. >> So, no efforts are required to try to convert flow into pattern and >> validate the flow rule. > That's an interesting feedback. > I would like to understand why OVS cannot adapt its datapath on demand > per port, per queue and per flow? I guess there is a misunderstanding here. What I'm trying to say is that introduction of MARK offload would make code a bit more simple and efficient. Basically it would be possible to enable so-called hardware offload in OVS by default, but finally make a decision per port based on MARK offload availability (should it try to make rte_flow rule by flow and insert it?)