From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CB854318F; Tue, 17 Oct 2023 21:40:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23DE7406B4; Tue, 17 Oct 2023 21:40:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id ED15F40042 for ; Tue, 17 Oct 2023 21:40:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697571652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BW0M28GQooUygmlmeyrzurJ5Bv36TdjdFVkU3DrU5yI=; b=ezeoWOsVuYLXbOXiO1e7ExPz8cYMViDXI6tz+Ad00UZL7VsJI6lcVRWj856VE6PuYp/nPb 3Gt8gbqtWPJfO6OtCo1j/gdsNjfo1SBJUHoN2Z6J6n12XW28RVY7HqPUYiF2ZLRNl4oACv 7VxbHxL5aQHwo0vG4qNer1njpFaVD1k= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-587-13v2bGUHNguct2trIpi4Sg-1; Tue, 17 Oct 2023 15:40:48 -0400 X-MC-Unique: 13v2bGUHNguct2trIpi4Sg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F101B1C0BB4E; Tue, 17 Oct 2023 19:40:47 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 944E525C8; Tue, 17 Oct 2023 19:40:46 +0000 (UTC) Message-ID: Date: Tue, 17 Oct 2023 21:40:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 05/11] test/bbdev: improve test log messages To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20230929181328.104311-1-hernan.vargas@intel.com> <20230929181328.104311-6-hernan.vargas@intel.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= xsFNBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABzSxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPsLBeAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASrOwU0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAHC wV8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= In-Reply-To: <20230929181328.104311-6-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/29/23 20:13, Hernan Vargas wrote: > Add a print message for failure to retrieve stats on bbdev. > Add vector name in logs. > Remove unnecessary prints. > Update code comments and cosmetic changes. > No functional impact. > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/main.c | 3 ++- > app/test-bbdev/test_bbdev_perf.c | 26 ++++++++++++++------------ > 2 files changed, 16 insertions(+), 13 deletions(-) > > diff --git a/app/test-bbdev/main.c b/app/test-bbdev/main.c > index ec830eb32bc8..8f6852e2efdb 100644 > --- a/app/test-bbdev/main.c > +++ b/app/test-bbdev/main.c > @@ -107,7 +107,8 @@ unit_test_suite_runner(struct unit_test_suite *suite) > end = rte_rdtsc_precise(); > > printf(" + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +\n"); > - printf(" + Test Suite Summary : %s\n", suite->suite_name); > + printf(" + Test Suite Summary : %s - %s\n", > + suite->suite_name, get_vector_filename()); > printf(" + Tests Total : %2d\n", total); > printf(" + Tests Skipped : %2d\n", skipped); > printf(" + Tests Passed : %2d\n", succeeded); > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 54cb2090f988..4f8e226e587b 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -721,9 +721,9 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info, > conf.vf_dl_queues_number[i] = VF_DL_5G_QUEUE_VALUE; > } > > - /* UL bandwidth. Needed for schedule algorithm */ > + /* UL bandwidth. Needed only for Vista Creek 5GNR schedule algorithm */ We should find a way to get rid of this device specific code in the test application. Test-pmd now has device-specific extensions, we should consider doing the same here. > conf.ul_bandwidth = UL_5G_BANDWIDTH; > - /* DL bandwidth */ > + /* DL bandwidth. Needed only for Vista Creek 5GNR schedule algorithm */ > conf.dl_bandwidth = DL_5G_BANDWIDTH; > > /* UL & DL load Balance Factor to 64 */ > @@ -743,7 +743,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info, > struct rte_acc_conf conf; > unsigned int i; > > - printf("Configure ACC100/ACC101 FEC Driver %s with default values\n", > + printf("Configure ACC100 FEC device %s with default values\n", > info->drv.driver_name); > > /* clear default configuration before initialization */ > @@ -1047,13 +1047,15 @@ ut_setup(void) > static void > ut_teardown(void) > { > - uint8_t i, dev_id; > + uint8_t i, dev_id, ret; > struct rte_bbdev_stats stats; > > for (i = 0; i < nb_active_devs; i++) { > dev_id = active_devs[i].dev_id; > /* read stats and print */ > - rte_bbdev_stats_get(dev_id, &stats); > + ret = rte_bbdev_stats_get(dev_id, &stats); > + if (ret != 0) > + printf("Failed to get stats on bbdev %u\n", dev_id); > /* Stop the device */ > rte_bbdev_stop(dev_id); > } > @@ -2227,9 +2229,11 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, > if ((error > 8 && (abs_harq_origin < > (llr_max - 16))) || > (error > 16)) { > + /* > printf("HARQ mismatch %d: exp %d act %d => %d\n", > j, harq_orig[j], > harq_out[jj], error); > + */ > byte_error++; > cum_error += error; > } > @@ -5270,7 +5274,7 @@ offload_latency_test_fft(struct rte_mempool *mempool, struct test_buffers *bufs, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_fft_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > + TEST_ASSERT_SUCCESS(ret, "rte_bbdev_fft_op_alloc_bulk() failed"); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_fft_op(ops_enq, burst_sz, dequeued, > bufs->inputs, > @@ -5352,7 +5356,7 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > + TEST_ASSERT_SUCCESS(ret, "rte_bbdev_dec_op_alloc_bulk() failed"); > ref_op->turbo_dec.iter_max = get_iter_max(); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_dec_op(ops_enq, burst_sz, dequeued, > @@ -5439,7 +5443,7 @@ offload_latency_test_ldpc_dec(struct rte_mempool *mempool, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", burst_sz); > + TEST_ASSERT_SUCCESS(ret, "rte_bbdev_dec_op_alloc_bulk() failed"); > ref_op->ldpc_dec.iter_max = get_iter_max(); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_ldpc_dec_op(ops_enq, burst_sz, dequeued, > @@ -5534,8 +5538,7 @@ offload_latency_test_enc(struct rte_mempool *mempool, struct test_buffers *bufs, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_enc_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, > - "rte_bbdev_enc_op_alloc_bulk() failed"); > + TEST_ASSERT_SUCCESS(ret, "rte_bbdev_enc_op_alloc_bulk() failed"); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_enc_op(ops_enq, burst_sz, dequeued, > bufs->inputs, > @@ -5617,8 +5620,7 @@ offload_latency_test_ldpc_enc(struct rte_mempool *mempool, > burst_sz = num_to_process - dequeued; > > ret = rte_bbdev_enc_op_alloc_bulk(mempool, ops_enq, burst_sz); > - TEST_ASSERT_SUCCESS(ret, > - "rte_bbdev_enc_op_alloc_bulk() failed"); > + TEST_ASSERT_SUCCESS(ret, "rte_bbdev_enc_op_alloc_bulk() failed"); > if (test_vector.op_type != RTE_BBDEV_OP_NONE) > copy_reference_ldpc_enc_op(ops_enq, burst_sz, dequeued, > bufs->inputs, Reviewed-by: Maxime Coquelin Maxime