From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
John McNamara <john.mcnamara@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/pcap: convert license headers to SPDX tags
Date: Tue, 19 Dec 2017 10:32:51 +0530 [thread overview]
Message-ID: <fc012ed5-f173-e5ec-5aa5-6cc42cd31ffa@nxp.com> (raw)
In-Reply-To: <26b4b915-abf5-4eda-7187-827666f30167@intel.com>
HI Ferruh,
On 12/19/2017 2:48 AM, Ferruh Yigit wrote:
> On 12/18/2017 1:06 PM, Ferruh Yigit wrote:
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> <...>
>
>> + * SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
>> + * Copyright(c) 2014 6WIND S.A.
>> + * All rights reserved.
>> */
>
> Hi Hemant, Thomas,
>
> Can you please suggest about extra "All rights reserved." line.
>
> It is in the part of the BSD header, and I _assume_ that has been intended to
> cover all "Copyright" lines above it.
> But since some of the Copyright holders (at least Intel ones) already has that
> in same line with copyright and I _assume_ this is intentional because of legal
> requirements, can we remove that line.
>
> I guess we have two options while removing it, applying it to all previous
> Copyright lines (B) or just remove it (A):
>
> (A)
> SPDX-License-Identifier: BSD-3-Clause
> Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
> Copyright(c) 2014 6WIND S.A.
>
> (B)
> SPDX-License-Identifier: BSD-3-Clause
> Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
> Copyright(c) 2014 6WIND S.A. All rights reserved.
>
>
> Can we go with option (A)?
>
"All rights reserved" depend on legal counsel.
e.g Freescale preferred it, with NXP migration, we have stopped doing it.
w.r.t your query, I will suggest option (c)
SPDX-License-Identifier: BSD-3-Clause
Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
Copyright(c) 2014 6WIND S.A.
All rights reserved.
i.e no change in copyright.
However, as Bruce mentioned, we can remove *All rights reserved* for
the files having duplicate statement for a single copyright.
next prev parent reply other threads:[~2017-12-19 5:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 21:06 Ferruh Yigit
2017-12-18 21:18 ` Ferruh Yigit
2017-12-18 21:35 ` Thomas Monjalon
2017-12-19 5:02 ` Hemant Agrawal [this message]
2017-12-19 10:18 ` Bruce Richardson
2017-12-19 19:29 ` Ferruh Yigit
2017-12-19 19:41 ` Bruce Richardson
2017-12-19 19:48 ` Ferruh Yigit
2018-01-09 13:13 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-01-10 6:28 ` Hemant Agrawal
2018-01-11 17:56 ` Thomas Monjalon
2018-01-16 13:07 ` Olivier Matz
2018-01-16 16:15 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc012ed5-f173-e5ec-5aa5-6cc42cd31ffa@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).