From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E86A43C5F; Wed, 6 Mar 2024 17:14:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BA1842E62; Wed, 6 Mar 2024 17:14:58 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2059.outbound.protection.outlook.com [40.107.223.59]) by mails.dpdk.org (Postfix) with ESMTP id EB0B740276 for ; Wed, 6 Mar 2024 17:14:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gv8uCUQKlXsYRGjqTzAo0MJ0MLXbYe+ShKHQDqO9hVT/rz2Vd767hzgQiQLwhQZ5VKq06N4K7HlHbbeRJLz3SrZTi5KxERsDXNiFyLF8WFDsheBCmDDx/CvAcJYblo/H8+F6Ai5HLZcoz/QBPAUSMbTGvqFrIWsmCgeJBPud1z4/yXlRT6gxa6Vz5U2TKXYPwW3FnAtVvLBwKEqYVk0s6rl0iBUw/gjU1v+HwzIXZX2HBaeN1xd4ExZkRh8me84VABG+LZqAhthYgXjg86iRRJhq4q7SeYILywEPBd07FcMaidyghoOOdzQbl/1F92/KnwRSFxs/z6KB71wXUPDbRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sXSZpcsoh3rmRnzwo/zvo645rw2dBiVKgyRdy48hd50=; b=FbAFNYlp1V5mgYM3n8ANXccG7MLpQiy5E4gAwyGRNGmbhtAbjpLpgILiPLUVVUYsdvx0+d96wAdJ6jKRb3SN9sjC2bA847H8QpIFqDBkBpZ3jH8Gf8/ODlbh4jOCH+L7ZIJpp4VKs720Sj9avE2OM2xhYebwjj9ezZohmt2QIsqgoz8i9lxE3v12PMYJPHd1hRYcHEyBt+CZawn0+8dX4vNNURkMQr6TWJrUG+YleJc0QSXiqWGuGS7AFdpqZ71fZHp7R+Lggw3LYkBItPKbrFFcj0FwZzLI0EjB+gritxdSaLO5PisbkVMp3009xD0fLtiyWgRqZJwKKqvc6qnNSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sXSZpcsoh3rmRnzwo/zvo645rw2dBiVKgyRdy48hd50=; b=Vp4pVZBLf+x0kzd6aS/wFCo4tLS4SmSASft3FAPRiRBSlGdkOrioXmq+pcRbWrN5o7foAANOylzaJVCgbA//OvfIUXUKmG8BZdWRWDLhrlm98UOFjjJNizikT1rCu6O1LUu7KgsL5FyYxfigXY0U+JYLtqaX8ksd9VK34XD2xG0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN6PR12MB8568.namprd12.prod.outlook.com (2603:10b6:208:471::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Wed, 6 Mar 2024 16:14:54 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.019; Wed, 6 Mar 2024 16:14:54 +0000 Message-ID: Date: Wed, 6 Mar 2024 16:14:51 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/tap: allow more that 4 queues Content-Language: en-US To: Stephen Hemminger , dev@dpdk.org References: <20240229175620.122949-1-stephen@networkplumber.org> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240229175620.122949-1-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:338::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN6PR12MB8568:EE_ X-MS-Office365-Filtering-Correlation-Id: d8e54381-d7a4-4ca0-aa20-08dc3df88ee4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AwtrY8bdLjlobMHPTyieypZQM4OngDfUWRNitoqAhMSx6HcJh746ES4SLrM10tvhyneSTYwy627BUcI5SSHjaeys1vLEFLDFM1dOzVV8sjz/Y/CgfexWnXg0F0XmAHuNPjQ75Rn+dVMa7PTc4fZzo/gAnOA0Dcgqx+hPHKwoZ2aAMAVSLHh15tbVCFLeccAbuxvdAgdIB94TTStjSxjxgnfs2ftV8bKGs84KHI0+q4MhgnQcshJIZzZz9iPUT2p/eTCpxlbUfJdysaKpFTXDQlfnzlDqhyGmVtIqHVbAWFPOWBNVxn31NFSwSB+HPo8j185/3/iykjoCGP3UhmcVeCe8koWQ8y7Ik86uBTtiKEVYNYyXZywUKXjFYl0pG53H1xUoaxG7KdNXSieVr4T1CbYHT6CJDin/mtwmuii7cn4zr1clmZPOWh1KBhW/ueh7IsZ7pT0zg0zEOBQU/AvAGDdxFhwrJ9SqYFePrYvx7qGJabbl1ic34Pp5KM4nWz+BWk979B86hzZvxJjhA2TQjwKfqkPOKCQx7HW+yo7K5IuCKZGSE90u6+8Z6v7RLtf3aoDt/0tZBVlbXJZpIM+yCMa7aA0eXDJ3Wqt79yIehYmvOR9UbPxU2T1K0vxWHOqyPKD7whev66sdj5Iq83qPsOpl9rWXM3DJaVqsKHrEp1A= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWQvMERnSDJHalE5Y04vUTVPc21IYkh3STVvNGdwRitEbnhDOFYxd0cyVHI1?= =?utf-8?B?TVdIbkozUlJmTmcyeU9Od1N5QTZHMys3SSttbkl5VzBrQ054TlRWQ2tLTGFJ?= =?utf-8?B?VTZwS1RQckxTSnQzTk8xUmNuTXI1SFNCYnJjaldWR2NUbFlJOEhsQTYxdTZu?= =?utf-8?B?M2svdGFJZ3pHR0hYUXVsNC9tZDY0Y0NpaURNeWpRWUlnNVk0UW9xYXNCQmNn?= =?utf-8?B?TkFRYjcwU3dRRVNPRzlvb1B0MlZmL0RKaC9XK3A5QUI5VUcwa1Z5TmNOZmZ1?= =?utf-8?B?ZkxjNFVYT2JRcGFuRmhZalVqaU1rMUR1eUJVQjRRT2N0QkZKTHNoVjlNSlVJ?= =?utf-8?B?WU9reDBNSk96blVYbHR3enZ0K1VlajhyMkpKclM4WmFWZmE5TUVOMnB4U2pq?= =?utf-8?B?SGdtNWp3THlWMnNhRWw2eGJRYU9RSnl6cy9ieXJtcXA1eDd0YVJpVXZBbkxk?= =?utf-8?B?alY4QUVjVGlQWElRQ1VCK2oxVWlKeTI1NE1kZTE4QVZJKzRnWFlpcTJBV1Rz?= =?utf-8?B?QWpNcFRSbTVPaGU1cHBaZ3orcXZFaFVaaXBRMDY2MGtZZ3gyUCtpS2JTeHhG?= =?utf-8?B?NzVwZkF0UUZEbnArVFllSTlCVk9jdFBLYVhKWDJyZDMxSUdBT0d6UFZzQ3Iv?= =?utf-8?B?L25IQnNzbnQ4T1lEUlhoQkVjbjVrMFJLSUxzRTMvNkpQcmw3WjJjTFpVa2do?= =?utf-8?B?V2pVS05wcEVQdVRiNmE0MVBKcnFnWUR6SnAwTFRTa01LQjhPRWZSaDJBbFhY?= =?utf-8?B?elQzcVRWaXcwdDZKVHJjYVNxL04vMEFheU1tbk44Ty9XZHdObmV3cGRpWEM3?= =?utf-8?B?YzBKSXJBS1BDTVQ0b0JHb1RLVGNMT1lqa0l1MmJlakNEa1dPY2I2c0FqZ2Nn?= =?utf-8?B?S0dCaXJXbHlSWEQwS3htbHFkRi9Vb0hLNFFFOUY2NjdTbmZwOWRTTlRhUHN6?= =?utf-8?B?eUVmZ0h6Q1RJaGJ0MFZTK3BsNVBoSXlvLzZWblZSYzVTTGVYNncwMzYxbkdU?= =?utf-8?B?T29TdFBuWGRsQmc5eUdwcW5qalNwOVQ3WmNVSC9UNG9BclZVcmRLUGdlaEdS?= =?utf-8?B?ckVuOHRUSDQvTDd5L2RnY25uRDNqdUJvalVhbVoyckNidUo5VStRKzAvTnFm?= =?utf-8?B?M21XM3JqWkVtTWtSRENSeVhmWk1EZ1B1bzZ4RE1WQ3JyKzFjMm5SaUh1cnpw?= =?utf-8?B?NDRmOXdUeEVNUDZ4d09Edk5xY042blV6K2dDd0JZV3U1ZS9kNElPTVdUY1hJ?= =?utf-8?B?UWp5aWQ1ZjNTbnIwY01pNG9zNVlDenZrREpCVzR5ckJoQldhQ0dEalg0U3RS?= =?utf-8?B?aDE3ZXZwbG4vT29TbnNlK1U0bk02OE03anJMUHBXR1IrMmExblBLdHRoZHNv?= =?utf-8?B?SnlMU0l1b1JRNS9pVnVlU3E2eHkwRFg3S2xFR2pXcnlXRjkyblhXTnNncTVv?= =?utf-8?B?ZlFOcFpCTGtOaGJONVIyaTk1dXNpOHdkL0ZNcDhsNldIN0thQXFnM1pnMUZX?= =?utf-8?B?TENPbVZCVldYb1QwWmZtcmo3UjdaTStSZ2FtWTgyd0MvY1k4T2NhYWlUQmlo?= =?utf-8?B?T1JUaUwvbVh6bkhjT3oxY0s4WmtzY21wYVZVcUNGOUdHNzg5bTRSRGZMSTFm?= =?utf-8?B?bUZJUEVtSGpkZEZBYzdoc28zUUE1ZWJTRmJNUjdpckIrUU85cEh4OEpsTzg5?= =?utf-8?B?VHVVeGZFdXEzenJjOVJBSnF5UVpYWUpQNUwrQzU2SHV4MlJJUkcxRHVyMG85?= =?utf-8?B?VUZ3UzVOV2FTOUY4eVptdlk2SDhNK1l6VmEyaUZtZzIvMUVKdnRNY3d1OFAr?= =?utf-8?B?ZnZjZS93WkNLTGNKcnY4aXMwUkJHOFFzSFdSelNBN2hiV0dYYUFodmtXQ3hQ?= =?utf-8?B?czZYd2w3NVFodVlJSUQrSTFLMHZNS2Q0aGdQbEFPek9PcWc4RTk4bWlsc0NS?= =?utf-8?B?ZFNmVllyQStRRXlVV2xKOTRvU29WNk04dFBHUmova2dadlA2elBkMzR4bXZv?= =?utf-8?B?cGd5Vk1mRGNLY2xIdHdZc2Q2WjJuZ0RtdXF0a2dEdG5xRjNvZHJ3K1FIWEc1?= =?utf-8?B?ZXJWZ0tHOFpBeDJxSWZ6NmwwVkE2cGMrcHRiM2lVandtalJKMm1wd20zd21X?= =?utf-8?Q?RPAqEjhn2jnotnukxdTQa+hgn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8e54381-d7a4-4ca0-aa20-08dc3df88ee4 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 16:14:54.0536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9owb86oBL4vgdpzd/Qg3UjjvuIKhATxXy+IcvoYUi25W7CnBfwKfkkmB9Fekhd9z X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8568 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/29/2024 5:56 PM, Stephen Hemminger wrote: > The tap device needs to exchange file descriptors for tx and rx. > But the EAL MP layer has limit of 8 file descriptors per message. > The ideal resolution would be to increase the number of file > descriptors allowed for rte_mp_sendmsg(), but this would break > the ABI. Workaround the constraint by breaking into multiple messages. > > Do not hide errors about MP message failures. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/rte_eth_tap.c | 40 +++++++++++++++++++++++++++++------ > 1 file changed, 33 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index 69d9da695bed..df18c328f498 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -863,21 +863,44 @@ tap_mp_req_on_rxtx(struct rte_eth_dev *dev) > msg.fds[fd_iterator++] = process_private->txq_fds[i]; > msg.num_fds++; > request_param->txq_count++; > + > + /* Need to break request into chunks */ > + if (fd_iterator >= RTE_MP_MAX_FD_NUM) { > + err = rte_mp_sendmsg(&msg); > + if (err < 0) > + goto fail; > + > + fd_iterator = 0; > + msg.num_fds = 0; > + request_param->txq_count = 0; > + } > } > for (i = 0; i < dev->data->nb_rx_queues; i++) { > msg.fds[fd_iterator++] = process_private->rxq_fds[i]; > msg.num_fds++; > request_param->rxq_count++; > + > + if (fd_iterator >= RTE_MP_MAX_FD_NUM) { > + err = rte_mp_sendmsg(&msg); > + if (err < 0) > + goto fail; > + > + fd_iterator = 0; > + msg.num_fds = 0; > + request_param->rxq_count = 0; > + } > } Hi Stephen, Did you able to verify with more than 4 queues? As far as I can see, in the secondary counterpart of the 'rte_mp_sendmsg()', each time secondary index starts from 0, and subsequent calls overwrites the fds in secondary. So practically still only 4 queues works.