From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A755A0C41; Wed, 12 May 2021 20:44:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CDC14003F; Wed, 12 May 2021 20:44:10 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 4B13F4003E for ; Wed, 12 May 2021 20:44:09 +0200 (CEST) IronPort-SDR: 1jAcjTuaCixUJgTslYr8NSb5X4CS1a3HI0BXll3Skb1G/RwSR6hrrqm0Qv6aMWLfQAgew6AMuq 2joS+btfH2mQ== X-IronPort-AV: E=McAfee;i="6200,9189,9982"; a="220759366" X-IronPort-AV: E=Sophos;i="5.82,295,1613462400"; d="scan'208";a="220759366" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 11:44:08 -0700 IronPort-SDR: UsE3IZLs2sevGKMTNlvyJxdt+7sKgf+OYzwfeE4uhWX5GNXVdYvK4wWwO96jzMYAscNDmO8vNi jueHgzGREVMw== X-IronPort-AV: E=Sophos;i="5.82,295,1613462400"; d="scan'208";a="400433627" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.215.243.179]) ([10.215.243.179]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 11:44:03 -0700 To: Bruce Richardson , Heinrich Kuhn Cc: dev@dpdk.org, "Chaoyong.He" , Simon Horman , konstantin.ananyev@intel.com References: <20210510165319.9153-1-heinrich.kuhn@netronome.com> From: "Medvedkin, Vladimir" Message-ID: Date: Wed, 12 May 2021 21:43:57 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: change mq-mode on single queue devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, On 12/05/2021 19:32, Bruce Richardson wrote: > On Mon, May 10, 2021 at 06:53:19PM +0200, Heinrich Kuhn wrote: >> From: "Chaoyong.He" >> >> Set the Rx multi-queue mode to NONE when configuring a port that is >> associated with hardware that only supports a single Rx queue. >> >> Signed-off-by: Chaoyong He >> Signed-off-by: Heinrich Kuhn >> Signed-off-by: Simon Horman >> --- >> examples/l3fwd/main.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c >> index bb49e5faf..87b638ac0 100644 >> --- a/examples/l3fwd/main.c >> +++ b/examples/l3fwd/main.c >> @@ -953,6 +953,10 @@ l3fwd_poll_resource_setup(void) >> >> local_port_conf.rx_adv_conf.rss_conf.rss_hf &= >> dev_info.flow_type_rss_offloads; >> + >> + if (dev_info.max_rx_queues == 1) >> + local_port_conf.rxmode.mq_mode = ETH_MQ_RX_NONE; >> + > > While it makes sense to do this when the port only supports a single queue, > would it not also make sense to do this when the requested queues are 1 > too? > > Adding some lookup library maintainers on CC - I assume that the RSS value > is not actually used for lookup anywhere in l3fwd. > As far as I can see the rss hash value is not used anywhere in l3fwd. In LPM/FIB this is not required at all, in EM CRC or Jenkins hash is used. > /Bruce > -- Regards, Vladimir