DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Keiichi Watanabe <keiichiw@chromium.org>, dev@dpdk.org
Cc: dgreid@chromium.org, chirantan@chromium.org,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Chenbo Xia <chenbo.xia@intel.com>, Ray Kinsella <mdr@ashroe.eu>,
	Neil Horman <nhorman@tuxdriver.com>,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features
Date: Wed, 31 Mar 2021 17:45:50 +0100	[thread overview]
Message-ID: <fc19ce20-18b1-2ee6-75b3-1e0feb951c1e@intel.com> (raw)
In-Reply-To: <20210322072257.2017227-2-keiichiw@chromium.org>

On 3/22/2021 7:22 AM, Keiichi Watanabe wrote:
> Add rte_vhost_get_negotiated_protocol_features, which returns a set of
> enabled protocol features.
> 
> Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>

<...>

> diff --git a/lib/librte_vhost/version.map b/lib/librte_vhost/version.map
> index 9183d6f2f..95c4c0990 100644
> --- a/lib/librte_vhost/version.map
> +++ b/lib/librte_vhost/version.map
> @@ -63,6 +63,7 @@ EXPERIMENTAL {
>   	rte_vhost_va_from_guest_pa;
>   	rte_vhost_extern_callback_register;
>   	rte_vhost_driver_set_protocol_features;
> +	rte_vhost_get_negotiated_protocol_features;
>   	rte_vhost_set_inflight_desc_split;
>   	rte_vhost_set_inflight_desc_packed;
>   	rte_vhost_set_last_inflight_io_split;

Added the release version that experimental API is added as comment in next-net, 
like following:

  +++ b/lib/librte_vhost/version.map
  @@ -76,4 +76,7 @@ EXPERIMENTAL {
          rte_vhost_async_channel_unregister;
          rte_vhost_submit_enqueue_burst;
          rte_vhost_poll_enqueue_completed;
  +
  +       # added in 21.05
  +       rte_vhost_get_negotiated_protocol_features;
   };


We are doing this already in many libraries [1], this helps us easily observe 
how long an API is staying as experimental in a library.

[1]: https://git.dpdk.org/dpdk/tree/lib/librte_eal/version.map?h=v21.02#n407

  parent reply	other threads:[~2021-03-31 16:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22  7:22 [dpdk-dev] [PATCH v2 0/2] " Keiichi Watanabe
2021-03-22  7:22 ` [dpdk-dev] [PATCH v2 1/2] " Keiichi Watanabe
2021-03-25 14:16   ` Maxime Coquelin
2021-03-31 16:45   ` Ferruh Yigit [this message]
2021-04-01  8:42     ` Kinsella, Ray
2021-04-01 16:05       ` Keiichi Watanabe
2021-04-01 16:28         ` Ferruh Yigit
2021-04-01 16:38           ` Keiichi Watanabe
2021-03-22  7:22 ` [dpdk-dev] [PATCH v2 2/2] examples/vhost_blk: Check protocol features before getting inflight info Keiichi Watanabe
2021-03-25 14:18   ` Maxime Coquelin
2021-03-31  6:45 ` [dpdk-dev] [PATCH v2 0/2] vhost: Add API to get negotiated protocol features Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc19ce20-18b1-2ee6-75b3-1e0feb951c1e@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=chirantan@chromium.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dgreid@chromium.org \
    --cc=keiichiw@chromium.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=mdr@ashroe.eu \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).