From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: Marat Khalili <marat.khalili@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v2 2/2] bpf: dump additional instructions
Date: Fri, 19 Dec 2025 13:04:51 +0000 [thread overview]
Message-ID: <fc41314e2dc6481d95b557d83ad4f390@huawei.com> (raw)
In-Reply-To: <20251218170914.7737-3-marat.khalili@huawei.com>
> Fix issues with rte_bpf_dump not supporting or printing incorrectly some
> instructions that lib/bpf supports, and add warnings when it doesn't:
>
> * Conditional jump with condition between two registers was incorrectly
> printed by rte_bpf_dump as one with condition between register and
> immediate. Add missing handling of BPF_X flag.
>
> * Call instruction was printed by rte_bpf_dump as conditional jump. Add
> explicit handling for it.
>
> * We only support stx and ldx instructions in BPF_MEM mode, but were not
> checking the mode in rte_bpf_dump. Check for mode and only print
> mnemonic if the mode is BPF_MEM, otherwise print an error.
>
> * Atomic instructions were not previously supported by rte_bpf_dump. Add
> necessary handling.
>
> * Some instructions have variations with previously unused src_reg or
> offset fields set to non-zero value. We do not support any of these
> variations yet, and were printing them as a standard instruction.
> Print small note after such instructions warning the user that this is
> a variation.
>
> Signed-off-by: Marat Khalili <marat.khalili@huawei.com>
> ---
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> --
> 2.43.0
prev parent reply other threads:[~2025-12-19 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 17:20 [PATCH 0/2] bpf: add xchg and fix rte_bpf_dump Marat Khalili
2025-12-17 17:20 ` [PATCH 1/2] bpf: add atomic xchg support Marat Khalili
2025-12-17 17:20 ` [PATCH 2/2] bpf: dump additional instructions Marat Khalili
2025-12-18 17:09 ` [PATCH v2 0/2] bpf: add xchg and fix rte_bpf_dump Marat Khalili
2025-12-18 17:09 ` [PATCH v2 1/2] bpf: add atomic xchg support Marat Khalili
2025-12-19 13:03 ` Konstantin Ananyev
2025-12-18 17:09 ` [PATCH v2 2/2] bpf: dump additional instructions Marat Khalili
2025-12-19 13:04 ` Konstantin Ananyev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc41314e2dc6481d95b557d83ad4f390@huawei.com \
--to=konstantin.ananyev@huawei.com \
--cc=dev@dpdk.org \
--cc=marat.khalili@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).