From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82FD8A04FF; Tue, 14 Jan 2020 17:35:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AEEB91C0CE; Tue, 14 Jan 2020 17:35:12 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 5C0F21C0B9 for ; Tue, 14 Jan 2020 17:35:11 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id p9so14596469wmc.2 for ; Tue, 14 Jan 2020 08:35:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=U0sy3eBXM0G8yqBoO9bSdVlfHXoZPxIjNpGHk/KJdOk=; b=nd/eiXyS7FIDnAICjy3tURPLg45Ms0E0PmrHB0JrfKf9LGr0se28jPRvjovwdcMH9B D7yf8e6St+a9rdXxk8ffXTqxGKy8rDlxu8uNzYSh3004f9ARDESgqQhehLWn7EpodL0E cpNhPnjfHnXpDW9RoSXum1jhgpbPxbVwEn5EwbhmaVBaEuawp3xJrcK9o8hfj+FQzgme PLGhgOFk78eLvGaUpd8/MpDlj0akfqOm5CWU5OV6nWDX/Er7peKwBUhXd2NAz+Gs/mHa TsPFGe1IaK16Hx+/86krY52s/pE83IXKi/K9iMieeNdd6UvUAJvktn7F7k5Uae9jYbCm ji8w== X-Gm-Message-State: APjAAAX9LvMySw6N6Es5M36ONvk6l/dYaXyKKmzuf9lajKf+Uhf9TNqi sl6uvMBuieNV/scsGn6IZ0Hig59t6Ik= X-Google-Smtp-Source: APXvYqxwdz12QPl7QmJouMihl0vT4/fPgcSblXbvg3A+nr83OseuEbLmRJbZkMtGHnwsEKqdGH+CUw== X-Received: by 2002:a7b:cbc8:: with SMTP id n8mr28282217wmi.35.1579019711090; Tue, 14 Jan 2020 08:35:11 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id 4sm18387653wmg.22.2020.01.14.08.35.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2020 08:35:10 -0800 (PST) Message-ID: From: Luca Boccassi To: Bruce Richardson , David Marchand Cc: "Mcnamara, John" , dev , Aaron Conole , Thomas Monjalon Date: Tue, 14 Jan 2020 16:35:09 +0000 In-Reply-To: <20200114161923.GB1660@bricha3-MOBL.ger.corp.intel.com> References: <20200109115631.500056-1-bruce.richardson@intel.com> <20200110215205.513185-1-bruce.richardson@intel.com> <20200114161923.GB1660@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 0/6] meson build improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 2020-01-14 at 16:19 +0000, Bruce Richardson wrote: > On Tue, Jan 14, 2020 at 05:00:17PM +0100, David Marchand wrote: > > On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson > > < > > bruce.richardson@intel.com > > > wrote: > > > These patches make some improvements to the meson build, > > > particularly > > > for documentation. They also remove many, but not all warnings > > > issued > > > by meson e.g. warnings about newer features unsupported in > > > baseline. > > >=20 > > > The biggest change is to improve the handling of the guide html > > > docs. > > > The change here is more significant, and the doc build now uses a > > > wrapper script around sphinx. This wrapper script allows us to > > > output > > > correct dependency information for the sphinx build in a .d file. > > > This > > > .d file is processed by ninja (not meson) on build, so that any > > > changes > > > to doc files trigger a rebuild to the guides using sphinx. > > >=20 > > > For now, the two patches which remove the meson version warnings > > > are > > > CC'ed to stable for backport, theoretically this who set could be > > > backported if so desired, as all changes could be considered > > > fixes to > > > some degree or other, and nothing introduces a whole new feature. > > >=20 > > > Note: for completeness and simplicity, previously submitted patch > > > http://patches.dpdk.org/patch/64189/ > > > is included in this set, and will > > > be marked superceded in patchwork. > > >=20 > > > V4: fix build with older sphinx > > >=20 > > > V3: Shorten the python code in patch 5, and ensure style > > > compliance as > > > flagged by Aaron. > > >=20 > > > V2: resend to correct email addresses > >=20 > > Tried this series in Travis. It went fine through my own checks > > too. > >=20 > > But OBS is not happy with Debian 10, Debian Next and Ubuntu >=3D > > 18.04. > > The packaging fails when ninja can't find the 'doc' target. > >=20 >=20 > Can you send on a link to the failure logs? >=20 > I suspect this may be due to returning early from the doc folder if > the > document building is disabled (but need to see logs to confirm). > However, > I'm not sure it makes sense to have a doc target defined if doc > building is > disabled in build config. Sorry, should have thought about this when reviewing: the usefulness of having the target work without the option set is that the docs will only be built when called explicitly, without having to change the configuration. Given the doc build is very slow and it's arch-independent, in Debian/Ubuntu we only do it once, in the arch-independent target (arch: all). --=20 Kind regards, Luca Boccassi