From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44A9DA046B for ; Fri, 26 Jul 2019 15:37:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 053731C45A; Fri, 26 Jul 2019 15:37:43 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E1B7B1C458; Fri, 26 Jul 2019 15:37:40 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 06:37:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,311,1559545200"; d="scan'208";a="369531606" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.25.220]) ([10.252.25.220]) by fmsmga005.fm.intel.com with ESMTP; 26 Jul 2019 06:37:36 -0700 To: hgovindh , Marko Kovacevic , Ori Kam , Bruce Richardson , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki Cc: dev@dpdk.org, drc@linux.vnet.ibm.com, ruifeng.wang@arm.com, maciej.czekaj@caviumnetworks.com, stable@dpdk.org References: <20190725162903.106262-1-hariprasad.govindharajan@intel.com> <20190726132758.55217-1-hariprasad.govindharajan@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Fri, 26 Jul 2019 14:37:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190726132758.55217-1-hariprasad.govindharajan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] examples/l3fwd: fix unaligned memory access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 26-Jul-19 2:27 PM, hgovindh wrote: > Fix unaligned memory access when reading IPv6 header which > leads to segmentation fault by changing aligned memory read > to unaligned memory read. > > Bugzilla ID: 279 > Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") > Cc: maciej.czekaj@caviumnetworks.com > Cc: stable@dpdk.org > Signed-off-by: hgovindh > --- > V2: Added functions which will do unaligned load based on the > underlying architecture > > V3: Removed functions added in V2 and replaced them with if macros > which will branch based on the underlying architecture. As per my > understanding since the unaligned load affects only Intel arch, > I added that function branch and left the original code for other arc. > Can someone with ARM and PowerPC arch, could you please validate this > patch and let me know? > --- > examples/l3fwd/l3fwd_em.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c > index 5f499e005..ea9ca9491 100644 > --- a/examples/l3fwd/l3fwd_em.c > +++ b/examples/l3fwd/l3fwd_em.c > @@ -244,6 +244,7 @@ em_mask_key(void *key, xmm_t mask) > #error No vector engine (SSE, NEON, ALTIVEC) available, check your toolchain > #endif > > + > static inline uint16_t Unintended whitespace change? -- Thanks, Anatoly