From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD5E6456BD; Fri, 26 Jul 2024 18:05:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B884410F6; Fri, 26 Jul 2024 18:05:31 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 7E89A40E22 for ; Fri, 26 Jul 2024 18:05:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722009929; x=1753545929; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=yW229ar3PbMOcfTvKx4kibhpgjHtLDt8CxuIt/5wACY=; b=VhECzkq23pProLT5iqtoUxvNrKoWtBw8zVH8QCjanmiUHQYJWXj2SOJu d0xYmMfYVkIR0r/58iy9UriqFcME3M1JhntsAWDCQy3HUT7D9o++JKvNW hSD0QezlyJ94aQgVMtwPnQWRy7T8nmAw3UtNU/3J3CmWsNE/rSzggcQFh usEMA9QN+vYCjcqVR/YU3NOWA253KaZjI5TESq0JDXtYSn8Dn38V9UYTg q1nKwNLIlCCv83+8kel3J0UsMsyFo/kTZq/2/YFgaKOPi8f6mv6Kluv96 /L/Y6L/X0koBDH6zHC3N1gzOXA+BFAi6jCicFu5PvExPAa3fwts3xqK85 Q==; X-CSE-ConnectionGUID: K4UwEli9R0mT3G610cU9Iw== X-CSE-MsgGUID: 1SqUcDPbT8+VP/f36I1isw== X-IronPort-AV: E=McAfee;i="6700,10204,11145"; a="22722688" X-IronPort-AV: E=Sophos;i="6.09,239,1716274800"; d="scan'208";a="22722688" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2024 09:05:28 -0700 X-CSE-ConnectionGUID: DLyo2UncQ3yM4Sm7nGG95g== X-CSE-MsgGUID: o3pIxnEvTuSynOB7YV7yJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,239,1716274800"; d="scan'208";a="53230939" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Jul 2024 09:05:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 26 Jul 2024 09:05:27 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 26 Jul 2024 09:05:27 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 26 Jul 2024 09:05:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Zeo+J92o1JEgWrcijqou5Mpxyr8AE9qeY97cVsuMLZvoEjJcqXwIla7eM/nJFUIBc9Pq7ebptP/D8Dr9coLejgJYf0uRIbZJl3Y9XYfudI6H0OcV5tygAKfMoiAmLvbSK2hAYdDnx9mB0IFKJUR/txyluQUZc6AZ6DOQd4gSijoKux18x7mMf2qQXlSnM2p35I6iGhxam2qPQmlAOkmlflXOAKHIxYbuWIvYLMGoCA1xYLCdpzoGNBkjt6SuqylptPh9QNm3neXaIHUB37K4UtFqXAZEWL9jZSyExhC1MRUxyLXD40ZUZgxJrxpOkjF6v2WkAF62dW/OHZpl/hXw9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U7Bgl95LQIY1rtsNfRJDS9hEJi6rAPpqkTPe+xI5ilg=; b=aVtrowQHiNXwm3rRNIqG+dAAhS2Vz68P/SQXNShYJAqDKjutmbCo+339fXG8lcnAZuxnH4XK4P8Y06CkVL/keqyP6TtgYOImztb9abznpSLH5v1nwJU+QabrCYg2E3EVPA7b6PXAl/X0NkJXrbVb3wKYAf4Az4iDvcw3FhninE/BdIQn6nMujs9VbV9lhZFeNkofwHAInCZnsfRJJOIqg6R3tOHLzxVTS3fOIMHkvfaDyoQ14qXSQ8e++flcs59C+zBqsrybs46RSvkuhIm09ZGGfkohh5tcI3pwsNJdFSTmhH56EO/aOMhcR6zCCbJZDOn/khugaLyhHbK2nIfJyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by MN2PR11MB4709.namprd11.prod.outlook.com (2603:10b6:208:267::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.29; Fri, 26 Jul 2024 16:05:18 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%7]) with mapi id 15.20.7784.020; Fri, 26 Jul 2024 16:05:16 +0000 Message-ID: Date: Fri, 26 Jul 2024 18:05:08 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 1/1] devtools: add vscode configuration generator To: Stephen Hemminger CC: , References: <6a6b20c037cffcc5f68a341c4b4e4f21990ae991.1721997016.git.anatoly.burakov@intel.com> <20240726083658.14abf478@hermes.local> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <20240726083658.14abf478@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR09CA0028.eurprd09.prod.outlook.com (2603:10a6:10:a0::41) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|MN2PR11MB4709:EE_ X-MS-Office365-Filtering-Correlation-Id: 6440cdbd-68b3-40d5-c242-08dcad8cbcfc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WTRySis5K3NBSy9leWtqUDVlU2Q5WjdoTmZTeHRXSG1PZkF6dVNNeC8rYlJT?= =?utf-8?B?ZENjS0hjQWorU0xUVUZQcytKNjFHN2JuTzVNeFBvc0NGYVFCeU1RL0wvb3dN?= =?utf-8?B?bTgrUGhjRm03OGhqSDh4MXV6NzhhYk94Z3M4Nks4TFQ4SXBQRDVhRFJvK2Zz?= =?utf-8?B?US9nS2JYRy9hVStESHZnSjJwcVVBK2RLZDlYaTJKQnB2TnpjOE9IS0s1SXZZ?= =?utf-8?B?MkJiTlFHUWt5bXhwK251L24rL1dKVUlBU1pSZ2ZIbSswTjh6R05ZYjFiVGEz?= =?utf-8?B?WStTSGxuVzhaZ0xIc2VKeVNuc1g1QUNzU3dBUmdBY1lkWFVtcHgrT1dzaHpv?= =?utf-8?B?WG1jRnJ4TXpCV3FzVXpVRUlrdERQSHptMVozZ2dZWHFldUZhRVVUVWxRU1dm?= =?utf-8?B?d0MwVSs5TmFIRm91RzY2RklHOXdTQW0zdnVTbEl3cm9LODBBVk01aFRuUUUw?= =?utf-8?B?YXRpN2xzY3ZnbDlYb2JDSEtJOThhOEJpdkxjQmhydm5iSk1yU2lCQmx4VzVJ?= =?utf-8?B?eWNkRVIzWjFGOXBCMngvOXdTZS9vNWVnRHZhQi84djlyaVFOSmUzUys2M2tL?= =?utf-8?B?VTNtVm9yVzlGME82UVZXcGRQNTNFeW5xN0EzQUQzZC9zSUFBSU9WQVFBMldk?= =?utf-8?B?Z0hIRkJDZ1VzUFNDeFhlZ0hKTzlpTXc4SHZ3UUJqcDVDb1J3ZFhEdnhmRENI?= =?utf-8?B?ZWJrK0dvM282cXplTktKOXlFVG90R0IrNTlBRGZXdVAvYkl3cFJ5d3F1NkNL?= =?utf-8?B?TUpJejdneE9lRm50aUhxMEhhdExJWTdOaWliYllIM3RQb3MvS0w2VHdzQjRh?= =?utf-8?B?TTM3VDhZN20zWU9xQ1R3N2Z4amxqU0VPWmNJUHI1eUgvbnpWaGJ0YUhpUDBE?= =?utf-8?B?Rkp1WldHQmljdmswVEtyOHhzazl3K09UUjYybWNPaVR2eUplOXNCUU1hYnUv?= =?utf-8?B?NlNFVVp2MGlaNmVZakdlKzJ0VmE0dEhBUUtpY2FENXgreDlTcXYreFhPUUxr?= =?utf-8?B?dW9SSEpiSThlZXdRbnUyOFNWanQ4YkJNRWRiVWlmQlB0QlNySHlnRkMxaTVG?= =?utf-8?B?YmE0d1JmZGJWSnpldmFIbWpDeDZaSllNSC9JSkx3ZkE2OFhLRjFxbThTOTc2?= =?utf-8?B?M1BwZkg3dk9rUVhiOWZXNXpFNTFVWmFTWHNIT3RUQWR6THlVTk1sT0hQWU9L?= =?utf-8?B?cE5vUjNuMU5SQy9rM0Z4ZC8rbGRKVGtYMlRTNVl0QkNYMUhmS3dsQVlMa0lV?= =?utf-8?B?dS9jSVRoSUM5RmZOM3RuaGlkNHNpSkNhRUFSakh4eWc4ZTNITk9lUGJiZElP?= =?utf-8?B?a3BpbGxMWXQ1ZnJTMUVIUzV0RTdnbDRaZ2lXbXJOUXdwQ0IrbXpvRDF5WjlF?= =?utf-8?B?S3R5bkt6UktXN3pSUHFrOTkybHNGK250N2ViZVFhbUJ0NkM1dlNMRE43b29H?= =?utf-8?B?c1NyMXdYMDNNU0xGd2xGVDN5SUVYOXJ5VkFGVUlLTEkvWjc5bHdFSXlhckdV?= =?utf-8?B?eGV5Mm12RGp1QkUrVnF6bDE2SVZvMVY1dU1XOFdrVGRhRzFwcDFLYnFOLzc3?= =?utf-8?B?a2FGYUZJZ0x5a3dQWHNnaXp0elBmS3NyTGZlbTQydmhlSU1oQ1RVSEpKSC9O?= =?utf-8?B?eS9SOEVoenF4RFcrckNWMGUxdi9JWmwzdnl5aTZxMGN5dHJCS2ZUR0ZaN1Iv?= =?utf-8?B?elRmandOQlBDamVQRzVRY2xnWUFNaVR2M2JsYnFadE9JTkZpMHlyQTF4R2Z1?= =?utf-8?B?RndsZ1lHWHdrYVg2b24zdzRreFY1SlRhWFZ6aWh1SmtRaW5FU24zM2UxdFJD?= =?utf-8?B?Q3ZiZlpValA5NzJnSmQxUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QklTTXhsTmp6NitiSTVwSEJKc05mMWNwTkhPRFh0Yk9ZM0xlNCt0RENJZkpC?= =?utf-8?B?VER5d0lUUHg4Q2FGV0V5WUYrZzR2T0g1K2FDR0JJa0hJakdyaVlHMzBMQm9G?= =?utf-8?B?N00vRXR0VDRWcXNLQjFobHZ0K3QxbTk3ZzhrUGRSMEI4NFVheTZsZWR3enly?= =?utf-8?B?VW8yMy85WmpRZjJyTUtIMGF6eUpod3I1WG5VWmx4M2xoUzVKVStnRXNIQ2Vv?= =?utf-8?B?RC9yOU1ScjdaWGZ2NUozYmp1Qm5mTW9FVndMUWNjcFRwVjZIK1QrQkUyQ0Nn?= =?utf-8?B?T1Rrb0x1RHZsQmxkd3h6eklBeFR0ajBvTXdtdzFwTTU4cFQyUmlYNHBKUjJI?= =?utf-8?B?b29xVHFzYzNqcXBlNzN6Njl2NWlDc3ZtSVNOUGRtcWJtemNCOC9pOXZTMnVS?= =?utf-8?B?M3BiNEYwa2Q4ZGlZQ3VFVkVSeU9iM3d6eVJRczg0UWJUREZRalN1NUJXNnRY?= =?utf-8?B?NjVSbk1TVDcrYTNETG9TQ1FCSkpuVy8vUEdVQzJ0MXQvVkFiSWt0NVhxa1ZD?= =?utf-8?B?R043T0ZETWt6VVZKeHpHZ0JkdzdzM0hTT0tISUk1QVpySkRicGhKU2h0VFVv?= =?utf-8?B?UjhnZWRSajZJVmxsMFpxNGpIU1pkRGZTVkZxNUdySm5MbHVzam02TUFTWmtE?= =?utf-8?B?RVcyUlM2cGJoRjRZK1VvMEovSkdLamxVWkJhK0l5S044bjdsZ0JmZWNLcGVP?= =?utf-8?B?WG9LdlJMWjEyS2g1OEZwU1lQbDJWVE83R1R6cG4wOWlYUmE2dkpzS1RyUFdt?= =?utf-8?B?dlkySTVtZU56blplTTltL1dLT1VEK1hkVCsrWGZHYi9lNXc4T1FPNVcwZHNt?= =?utf-8?B?Z2FwclIrUG9iMGt5MXh3anZaWDV2VE1jREJNZ2IyZFU0QUFyZUZ2TGtyVjNs?= =?utf-8?B?T213MU52RUIrMVFOTkw3ejV6d2lFZ2RmZTdEMTdtejd2WmdIRjJyMTZTUTNV?= =?utf-8?B?YWthb3JXVU5pT0lvQ0haV21adCt6SW11SGxtUVZoLzE5b2JOTWZmSnFqSUhT?= =?utf-8?B?VVJpOER0clZlSFRzM3R0QVlpZXZiTjEyVTR6S1ZEVkk4YkZSR2RBT05sbnJi?= =?utf-8?B?S0FuNEJRRTBjcEcrNTk3Y1pKTUpuMVZCNEtUNWRSdnk4VzRocjJDSEYxdURD?= =?utf-8?B?Y2pqSS9LYUpWTlhxQlNwUnlPMk1DT2x5U3UrNTZha1prNEkvRTFWdTZFT29Z?= =?utf-8?B?YjA0bW9BdDlGR0VlQjNlanFDVWM2TENULytCUmplSWNlWGM2TUllbi9HVEtx?= =?utf-8?B?MGtTSzV5RHF4REh2cFdKN3JjTkplMkU4d0x3eEtCK0QyQkt1OGZxWHAvNjJJ?= =?utf-8?B?bGVlMUpXTWhhVStJNlQ2RzAzcVN6T0V1ZEpCVklDSVVGWDkydVlITFN5NWNK?= =?utf-8?B?b3BRanRwQ0hPVnZwNVNvM2VTb0x6M2FIZ240K0hHQTR4cHE2MVU2SlUwMU1U?= =?utf-8?B?M2tucFBGbEVWTHFmaWlMRnV2eWFIOWE2N1RHTU0yMjh2L2tIQ1lVSjd4ZVNt?= =?utf-8?B?bm8vbjFQWlZiNVByL0pwaHpHRGltRHlEQlR2ZExkNWRpSE9UZE43V3BrckNY?= =?utf-8?B?bUROZStsY2dCNFBXNnJvZjlSTy84RTJSWEpHK01oQzNMU2Evb29meE5vOWsr?= =?utf-8?B?dFhPakVVSC9lQ2lDaGZtaVYvMmw2SmJhSkI1U09uU3Jkczc3Z1Q5Y0YveTh0?= =?utf-8?B?cEVtWjRVT2I4U3h4YzFwV0xpTzRZcnhaQ2dTa1VYR0djUDgrczhCMEx4Vmly?= =?utf-8?B?d01NblEyL2w0QnhFMk13S1RZOVZXUXVMcERIVVAvVDRWSngwWlluK1pWQ1BF?= =?utf-8?B?ZFdYK0VKeStZVE9NYlNjUEVuanBjVHpVaXJDVUFTVkdvbUM2TUlxSkNwVW5X?= =?utf-8?B?SHZWU29rd2JNcDJsTzJ3Ui83Nk9wTi85ay91cFRaSVF5dFJGT0lyNE54RXhM?= =?utf-8?B?RU5qbHV5QzF4VDlleUlwZUVNcUJQSzkxd1dEak5TaEZ3TVN4RjB6UGZ6Qm5t?= =?utf-8?B?aElpTW4zUGoxMzFwalQwK3B3NWhackN3UmxpZ3pGWWxXclY0U3NEa09BNkNq?= =?utf-8?B?SjBYcmhKb0pmeGgzREVpWHFTaWNTQnphclpzRmtUMy9TUXExTk1vcWhiU0Fu?= =?utf-8?B?RGxJTWdZMWR3VWs1elFUMUNxeXNRcUJaUk9ILzZpVi9sbndualpRbWdWZTJa?= =?utf-8?B?VWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6440cdbd-68b3-40d5-c242-08dcad8cbcfc X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2024 16:05:15.9889 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NHNqp+SiAFWWYePEp1epkycwLS2YpZ7NTVUbaZPwITE5nM4R3d7XRBQmaPL+YHRYeqmpGlvO0HiQ05KkLjKr4q1ZTr43zMR13dksoksCeHg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4709 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/26/2024 5:36 PM, Stephen Hemminger wrote: > On Fri, 26 Jul 2024 13:42:56 +0100 > Anatoly Burakov wrote: > >> A lot of developers use Visual Studio Code as their primary IDE. This >> script generates a configuration file for VSCode that sets up basic build >> tasks, launch tasks, as well as C/C++ code analysis settings that will >> take into account compile_commands.json that is automatically generated >> by meson. >> >> Files generated by script: >> - .vscode/settings.json: stores variables needed by other files >> - .vscode/tasks.json: defines build tasks >> - .vscode/launch.json: defines launch tasks >> - .vscode/c_cpp_properties.json: defines code analysis settings >> >> The script uses a combination of globbing and meson file parsing to >> discover available apps, examples, and drivers, and generates a >> project-wide settings file, so that the user can later switch between >> debug/release/etc. configurations while keeping their desired apps, >> examples, and drivers, built by meson, and ensuring launch configurations >> still work correctly whatever the configuration selected. >> >> This script uses whiptail as TUI, which is expected to be universally >> available as it is shipped by default on most major distributions. >> However, the script is also designed to be scriptable and can be run >> without user interaction, and have its configuration supplied from >> command-line arguments. >> >> Signed-off-by: Anatoly Burakov > > The TUI doesn't matter much since I would expect this gets run > 100% on Windows. I run it on Linux using Remote SSH, and that's the primary target audience as far as I'm concerned (a lot of people do the same at our office). Just in case it wasn't clear, this is not for *Visual Studio* the Windows IDE, this is for *Visual Studio Code* the cross-platform code editor. I didn't actually think of testing this on Windows. I assume Windows doesn't have whiptail, so this will most likely refuse to run in TUI mode (unless run under WSL - I assume WSL ships whiptail). > > In general looks good, you might want to address > $ flake8 ./devtools/gen-vscode-config.py --max-line 100 > ./devtools/gen-vscode-config.py:352:47: E741 ambiguous variable name 'l' > ./devtools/gen-vscode-config.py:499:16: E713 test for membership should be 'not in' > ./devtools/gen-vscode-config.py:546:101: E501 line too long (120 > 100 characters) Thanks, I had Pylance linter but not flake8. -- Thanks, Anatoly