Re: [Patch v7 01/18] net/mana: add basic driver, build environment and doc

DPDK patches and discussions
 help / color / mirror / Atom feed

From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Long Li <longli@microsoft.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Ajay Sharma <sharmaajay@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [Patch v7 01/18] net/mana: add basic driver, build environment and doc
Date: Wed, 7 Sep 2022 10:12:33 +0100	[thread overview]
Message-ID: <fc6bdf8f-a3ea-f3f9-496d-f879e924ff2c@xilinx.com> (raw)
In-Reply-To: <PH7PR21MB3263EFBA6B4D014F0FF2231BCE419@PH7PR21MB3263.namprd21.prod.outlook.com>

On 9/7/2022 3:41 AM, Long Li wrote:

> 
>> Subject: RE: [Patch v7 01/18] net/mana: add basic driver, build environment
>> and doc
>>
>>> Subject: Re: [Patch v7 01/18] net/mana: add basic driver, build
>>> environment and doc
>>>
>>> On 9/3/2022 2:40 AM, longli@linuxonhyperv.com wrote:
>>>
>>>>
>>>> From: Long Li <longli@microsoft.com>
>>>>
>>>> MANA is a PCI device. It uses IB verbs to access hardware through
>>>> the kernel RDMA layer. This patch introduces build environment and
>>>> basic device probe functions.
>>>>
>>>> Signed-off-by: Long Li <longli@microsoft.com>
>>>> ---
>>>> Change log:
>>>> v2:
>>>> Fix typos.
>>>> Make the driver build only on x86-64 and Linux.
>>>> Remove unused header files.
>>>> Change port definition to uint16_t or uint8_t (for IB).
>>>> Use getline() in place of fgets() to read and truncate a line.
>>>> v3:
>>>> Add meson build check for required functions from RDMA direct verb
>>>> header file
>>>> v4:
>>>> Remove extra "\n" in logging code.
>>>> Use "r" in place of "rb" in fopen() to read text files.
>>>> v7:
>>>> Remove RTE_ETH_TX_OFFLOAD_TCP_TSO from offload cap.
>>>>
>>>
>>> Can you please check review comments on v4 [1], they seem still valid
>>> in this version.
>>> I didn't go through other patches, but can you please double check
>>> comments on all v4 patches?
>>
>> Sorry it was an oversight. Will remove all the "\n" and double check.
> 
> Are you referring to " Remove extra "\n" in logging code." In the comment?
> 
> There are two places "\n" are used, DRV_LOG() and PMD_INIT_LOG() in mana.h. I think they are okay as there is a single "\n" on each output line.
> 
> Please let me know if I missed anything.
> 

Not referring specific to '\n', there are multiple comments there.
Can you please double check the email or archive link, comments are all 
inline?

https://inbox.dpdk.org/dev/859e95d9-2483-b017-6daa-0852317b4a72@xilinx.com/

>>
>>>
>>>
>>> [1]
>>>
>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Finbo
>>> x.dpdk.org%2Fdev%2F859e95d9-2483-b017-6daa-
>>>
>> 0852317b4a72%40xilinx.com%2F&amp;data=05%7C01%7Clongli%40microsoft
>>> .com%7C85fe7680325e402d210408da9008036c%7C72f988bf86f141af91ab2d
>> 7c
>>>
>> d011db47%7C1%7C0%7C637980661342767895%7CUnknown%7CTWFpbGZsb3
>>>
>> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
>>> %3D%7C3000%7C%7C%7C&amp;sdata=4CHI9uw%2B0MwJtVjamECVZWvU
>> Yq
>>> BCitq7STstFNPNIN8%3D&amp;reserved=0
>

next prev parent reply	other threads:[~2022-09-07  9:12 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-03  1:40 [Patch v7 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD longli
2022-09-03  1:40 ` [Patch v7 01/18] net/mana: add basic driver, build environment and doc longli
2022-09-06 13:01   ` Ferruh Yigit
2022-09-07  1:43     ` Long Li
2022-09-07  2:41       ` Long Li
2022-09-07  9:12         ` Ferruh Yigit [this message]
2022-09-07 22:24           ` Long Li
2022-09-06 15:00   ` Stephen Hemminger
2022-09-07  1:48     ` Long Li
2022-09-07  9:14       ` Ferruh Yigit
2022-09-08 21:56   ` [Patch v8 01/18] net/mana: add basic driver with " longli
2022-09-21 17:55     ` Ferruh Yigit
2022-09-23 18:28       ` Long Li
2022-09-21 17:55     ` Ferruh Yigit
2022-09-23 18:31       ` Long Li
2022-09-24  2:45     ` [Patch v9 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD longli
2022-09-24  2:45       ` [Patch v9 01/18] net/mana: add basic driver with build environment and doc longli
2022-10-04 17:47         ` Ferruh Yigit
2022-09-24  2:45       ` [Patch v9 02/18] net/mana: device configuration and stop longli
2022-09-24  2:45       ` [Patch v9 03/18] net/mana: report supported ptypes longli
2022-09-24  2:45       ` [Patch v9 04/18] net/mana: support link update longli
2022-09-24  2:45       ` [Patch v9 05/18] net/mana: support device removal interrupts longli
2022-09-24  2:45       ` [Patch v9 06/18] net/mana: report device info longli
2022-09-24  2:45       ` [Patch v9 07/18] net/mana: configure RSS longli
2022-10-04 17:48         ` Ferruh Yigit
2022-09-24  2:45       ` [Patch v9 08/18] net/mana: configure Rx queues longli
2022-09-24  2:45       ` [Patch v9 09/18] net/mana: configure Tx queues longli
2022-09-24  2:45       ` [Patch v9 10/18] net/mana: implement memory registration longli
2022-09-24  2:45       ` [Patch v9 11/18] net/mana: implement the hardware layer operations longli
2022-10-04 17:48         ` Ferruh Yigit
2022-09-24  2:45       ` [Patch v9 12/18] net/mana: start/stop Tx queues longli
2022-09-24  2:45       ` [Patch v9 13/18] net/mana: start/stop Rx queues longli
2022-09-24  2:45       ` [Patch v9 14/18] net/mana: receive packets longli
2022-10-04 17:50         ` Ferruh Yigit
2022-09-24  2:45       ` [Patch v9 15/18] net/mana: send packets longli
2022-10-04 17:49         ` Ferruh Yigit
2022-09-24  2:45       ` [Patch v9 16/18] net/mana: start/stop device longli
2022-09-24  2:45       ` [Patch v9 17/18] net/mana: report queue stats longli
2022-09-24  2:45       ` [Patch v9 18/18] net/mana: support Rx interrupts longli
2022-10-04 17:51       ` [Patch v9 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD Ferruh Yigit
2022-10-04 19:37         ` Long Li
2022-10-05 23:21       ` [Patch v10 " longli
2022-10-05 23:21         ` [Patch v10 01/18] net/mana: add basic driver with build environment and doc longli
2023-03-21 20:19           ` Ferruh Yigit
2023-03-21 21:37             ` Long Li
2022-10-05 23:21         ` [Patch v10 02/18] net/mana: device configuration and stop longli
2022-10-05 23:21         ` [Patch v10 03/18] net/mana: report supported ptypes longli
2022-10-05 23:21         ` [Patch v10 04/18] net/mana: support link update longli
2022-10-05 23:21         ` [Patch v10 05/18] net/mana: support device removal interrupts longli
2022-10-05 23:21         ` [Patch v10 06/18] net/mana: report device info longli
2022-10-05 23:21         ` [Patch v10 07/18] net/mana: configure RSS longli
2022-10-05 23:21         ` [Patch v10 08/18] net/mana: configure Rx queues longli
2022-10-05 23:21         ` [Patch v10 09/18] net/mana: configure Tx queues longli
2022-10-05 23:22         ` [Patch v10 10/18] net/mana: implement memory registration longli
2022-10-05 23:22         ` [Patch v10 11/18] net/mana: implement the hardware layer operations longli
2022-10-05 23:22         ` [Patch v10 12/18] net/mana: start/stop Tx queues longli
2022-10-05 23:22         ` [Patch v10 13/18] net/mana: start/stop Rx queues longli
2022-10-05 23:22         ` [Patch v10 14/18] net/mana: receive packets longli
2022-10-05 23:22         ` [Patch v10 15/18] net/mana: send packets longli
2022-10-05 23:22         ` [Patch v10 16/18] net/mana: start/stop device longli
2022-10-05 23:22         ` [Patch v10 17/18] net/mana: report queue stats longli
2022-10-05 23:22         ` [Patch v10 18/18] net/mana: support Rx interrupts longli
2022-10-06  8:54         ` [Patch v10 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD Ferruh Yigit
2022-10-06 16:54           ` Ferruh Yigit
2022-10-06 18:07             ` Long Li
2022-09-03  1:40 ` [Patch v7 02/18] net/mana: add device configuration and stop longli
2022-09-08 21:57   ` [Patch v8 " longli
2022-09-03  1:40 ` [Patch v7 03/18] net/mana: add function to report support ptypes longli
2022-09-08 21:57   ` [Patch v8 " longli
2022-09-03  1:40 ` [Patch v7 04/18] net/mana: add link update longli
2022-09-08 21:57   ` [Patch v8 " longli
2022-09-03  1:40 ` [Patch v7 05/18] net/mana: add function for device removal interrupts longli
2022-09-08 21:58   ` [Patch v8 " longli
2022-09-03  1:40 ` [Patch v7 06/18] net/mana: add device info longli
2022-09-08 21:58   ` [Patch v8 " longli
2022-09-03  1:40 ` [Patch v7 07/18] net/mana: add function to configure RSS longli
2022-09-08 21:58   ` [Patch v8 " longli
2022-09-03  1:40 ` [Patch v7 08/18] net/mana: add function to configure RX queues longli
2022-09-08 21:58   ` [Patch v8 08/18] net/mana: add function to configure Rx queues longli
2022-09-03  1:40 ` [Patch v7 09/18] net/mana: add function to configure TX queues longli
2022-09-08 21:58   ` [Patch v8 09/18] net/mana: add function to configure Tx queues longli
2022-09-03  1:40 ` [Patch v7 10/18] net/mana: implement memory registration longli
2022-09-08 21:58   ` [Patch v8 " longli
2022-09-21 17:55     ` Ferruh Yigit
2022-09-03  1:40 ` [Patch v7 11/18] net/mana: implement the hardware layer operations longli
2022-09-08 21:59   ` [Patch v8 " longli
2022-09-21 17:55   ` [Patch v7 " Ferruh Yigit
2022-09-23 18:26     ` Long Li
2022-09-03  1:40 ` [Patch v7 12/18] net/mana: add function to start/stop TX queues longli
2022-09-08 21:59   ` [Patch v8 12/18] net/mana: add function to start/stop Tx queues longli
2022-09-03  1:40 ` [Patch v7 13/18] net/mana: add function to start/stop RX queues longli
2022-09-08 21:59   ` [Patch v8 13/18] net/mana: add function to start/stop Rx queues longli
2022-09-03  1:40 ` [Patch v7 14/18] net/mana: add function to receive packets longli
2022-09-08 21:59   ` [Patch v8 " longli
2022-09-03  1:40 ` [Patch v7 15/18] net/mana: add function to send packets longli
2022-09-08 21:59   ` [Patch v8 " longli
2022-09-03  1:40 ` [Patch v7 16/18] net/mana: add function to start/stop device longli
2022-09-08 21:59   ` [Patch v8 " longli
2022-09-03  1:40 ` [Patch v7 17/18] net/mana: add function to report queue stats longli
2022-09-08 22:00   ` [Patch v8 " longli
2022-09-03  1:41 ` [Patch v7 18/18] net/mana: add function to support RX interrupts longli
2022-09-08 22:00   ` [Patch v8 18/18] net/mana: add function to support Rx interrupts longli
2022-09-21 17:55   ` [Patch v7 18/18] net/mana: add function to support RX interrupts Ferruh Yigit
2022-09-23 18:26     ` Long Li
2022-09-06 13:03 ` [Patch v7 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD Ferruh Yigit
2022-09-06 14:38   ` Ferruh Yigit
2022-09-07  1:41     ` Long Li
2022-09-07  1:40   ` Long Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc6bdf8f-a3ea-f3f9-496d-f879e924ff2c@xilinx.com \
    --to=ferruh.yigit@xilinx.com \
    --cc=dev@dpdk.org \
    --cc=longli@microsoft.com \
    --cc=sharmaajay@microsoft.com \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).