From: Adrian Schollmeyer <a.schollmeyer@syseleven.de>
To: Shani Peretz <shperetz@nvidia.com>, dev@dpdk.org
Cc: rasland@nvidia.com, Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Subject: Re: [PATCH] net/mlx5: update stored Rx queue MTU when port MTU changes
Date: Tue, 18 Nov 2025 10:52:18 +0100 [thread overview]
Message-ID: <fc77013fe328b69749cab274ad89c7f1d15f47c0.camel@syseleven.de> (raw)
In-Reply-To: <20251117073937.1514124-1-shperetz@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]
Hi,
Am Montag, dem 17.11.2025 um 09:39 +0200 schrieb Shani Peretz:
> Offending commit added rxq_ctrl->mtu to track MTU at queue
> allocation time for validating shared RX queue compatibility.
>
> When MTU changes via rte_eth_dev_set_mtu(), only priv->mtu was
> updated, leaving rxq_ctrl->mtu with the old value.
If you read the commit message of the offending patch, this was in fact
intentional. The MTU at allocation time is relevant when joining a Rx
share group, as it is (to the best of my knowledge) the only MTU
setting that actually has an influence on the size of the packet
buffers. Therefore, it is the value which is relevant for sharing
packet buffers.
I've tested your patch again with the prototype I used to discover the
original bug and unfortunately it reappears.
Best regards,
Adrian
--
Adrian Schollmeyer
SysEleven GmbH
Boxhagener Straße 80
10245 Berlin
T +49 30 / 23 32 012-0
F +49 30 / 61 67 55 5-0
https://www.syseleven.de
https://www.linkedin.com/company/syseleven-gmbh
Current system status always at:
https://www.syseleven-status.net/
Company headquarters: Berlin
Registered court: AG Berlin Charlottenburg, HRB 108571 Berlin
Managing directors: Andreas Hermann, Jens Ihlenfeld, Jens Plogsties,
Andreas Rückriegel
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-11-18 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 7:39 Shani Peretz
2025-11-18 9:52 ` Adrian Schollmeyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc77013fe328b69749cab274ad89c7f1d15f47c0.camel@syseleven.de \
--to=a.schollmeyer@syseleven.de \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=shperetz@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).