From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2217A034F; Wed, 6 May 2020 16:14:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 419A01D8DA; Wed, 6 May 2020 16:14:54 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id BF9CA1D8CE for ; Wed, 6 May 2020 16:14:51 +0200 (CEST) IronPort-SDR: h4xF+T7D/CPuAd+GTESBRPNi6gGX7uvWwc/FGHTZjPFyod5aR6cQNLhmY9xXvO62clOMFXuUlY WT7yTNsl1qkQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 07:14:50 -0700 IronPort-SDR: M0w3hRE1EL3nzO+ueJQSDI2oYiAQkUNmkxbWdghoEuG2St7k3ljvL4TbyLncUvE7OOmEwl/kOq AxsMjyPFgZxQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,359,1583222400"; d="scan'208";a="461450627" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.197.179]) ([10.213.197.179]) by fmsmga005.fm.intel.com with ESMTP; 06 May 2020 07:14:48 -0700 To: Ruifeng Wang , "wenzhuo.lu@intel.com" , "konstantin.ananyev@intel.com" , "jerinj@marvell.com" , "viktorin@rehivetech.com" Cc: "dev@dpdk.org" , Gavin Hu , Honnappa Nagarahalli , "juraj.linkes@pantheon.tech" , nd References: <20200424065053.119885-1-ruifeng.wang@arm.com> <5f7e7a0b-a6d1-d905-9e6a-616112057e6d@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Wed, 6 May 2020 15:14:47 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/6/2020 2:54 PM, Ruifeng Wang wrote: > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, May 6, 2020 6:14 PM >> To: Ruifeng Wang ; wenzhuo.lu@intel.com; >> konstantin.ananyev@intel.com; jerinj@marvell.com; >> viktorin@rehivetech.com >> Cc: dev@dpdk.org; Gavin Hu ; Honnappa Nagarahalli >> ; juraj.linkes@pantheon.tech; nd >> >> Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilation >> >> On 5/6/2020 9:09 AM, Ruifeng Wang wrote: >>> >>>> -----Original Message----- >>>> From: Ferruh Yigit >>>> Sent: Friday, May 1, 2020 11:07 PM >>>> To: Ruifeng Wang ; wenzhuo.lu@intel.com; >>>> konstantin.ananyev@intel.com; jerinj@marvell.com; >>>> viktorin@rehivetech.com >>>> Cc: dev@dpdk.org; Gavin Hu ; Honnappa >> Nagarahalli >>>> ; juraj.linkes@pantheon.tech; nd >>>> >>>> Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilation >>>> >>>> On 4/24/2020 7:50 AM, Ruifeng Wang wrote: >>>>> Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] >>>>> and ixgbe PMD [2]. This patch set is to fix these. >>>>> >>>>> When building with make, please refer to guide: >>>>> http://patches.dpdk.org/patch/62820/ >>>>> >>>>> When building with meson, requires series: >>>>> http://patches.dpdk.org/cover/68534/ >>>>> >>>>> [1] https://mails.dpdk.org/archives/dev/2020-April/162673.html >>>>> [2] https://mails.dpdk.org/archives/dev/2020-April/163846.html >>>>> >>>>> >>>>> Ruifeng Wang (3): >>>>> arch/arm: add vcopyq intrinsic for aarch32 >>>>> net/ixgbe: add support for aarch32 >>>>> net/ixgbe: fix include of vector header file >>>>> >>>> >>>> Not directly related to this patch but since you are fixing aarch32 >>>> compilation, I am getting following -Wcast-align warnings [1] while cross >> building with: >>>> arm-linux-gcc.br_real (Buildroot 2020.02-00011-g7ea8a52) 9.3.0 >>>> >>> I got the same warnings with arm-linux-gnueabihf-gcc. The warnings >> spread in many different files. >>> It is because armv7a/aarch32 puts strict align requirement. >>> We can first make it compile. And clean up such warnings in next step? >> >> Sure. >> >> I thought it would break the build, aren't we using -Werror for the target? > Currently, "RTE_DEVEL_BUILD=n" is needed for armv7 build. > http://patches.dpdk.org/patch/62820/ May be not. I did able to build without "RTE_DEVEL_BUILD=n", while checking how :), found that "CONFIG_RTE_ARCH_STRICT_ALIGN=y" set in the armv7a config (defconfig_arm-armv7a-linux-gcc), seems explicitly added for these '-Wcast-align' warnings. Overall to the point of the discussion, since this way or that, build is not broken with cast-align warnings, I am OK to fix them later gradually. A side note is, I wonder if these 'RTE_DEVEL_BUILD' or 'CONFIG_RTE_ARCH_STRICT_ALIGN' reflected to the meson build, taking into account that make build is going away on 20.11, will we able to keep these functionalities in meson. > >> >>> >>>> >>>> [1] >>>> .../lib/librte_eal/linux/eal_vfio_mp_sync.c: In function ‘vfio_mp_primary’: >>>> .../lib/librte_eal/linux/eal_vfio_mp_sync.c:31:28: warning: cast >>>> increases required alignment of target type [-Wcast-align] >>>> 31 | struct vfio_mp_param *r = (struct vfio_mp_param *)reply.param; >>>> | ^ >>>> .../lib/librte_eal/linux/eal_vfio_mp_sync.c:33:3: warning: cast >>>> increases required alignment of target type [-Wcast-align] >>>> 33 | (const struct vfio_mp_param *)msg->param; >>>> | ^ >>>> .../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_open_group_fd’: >>>> .../lib/librte_eal/linux/eal_vfio.c:269:28: warning: cast increases >>>> required alignment of target type [-Wcast-align] >>>> 269 | struct vfio_mp_param *p = (struct vfio_mp_param >> *)mp_req.param; >>>> | ^ >>>> .../lib/librte_eal/linux/eal_vfio.c:316:7: warning: cast increases >>>> required alignment of target type [-Wcast-align] >>>> 316 | p = (struct vfio_mp_param *)mp_rep->param; >>>> | ^ >>>> CC eal_common_class.o >>>> .../lib/librte_eal/linux/eal_vfio.c: In function >> ‘vfio_sync_default_container’: >>>> .../lib/librte_eal/linux/eal_vfio.c:627:28: warning: cast increases >>>> required alignment of target type [-Wcast-align] >>>> 627 | struct vfio_mp_param *p = (struct vfio_mp_param >> *)mp_req.param; >>>> | ^ >>>> .../lib/librte_eal/linux/eal_vfio.c:652:7: warning: cast increases >>>> required alignment of target type [-Wcast-align] >>>> 652 | p = (struct vfio_mp_param *)mp_rep->param; >>>> | ^ >>>> .../lib/librte_eal/linux/eal_vfio.c: In function >> ‘vfio_get_default_container_fd’: >>>> .../lib/librte_eal/linux/eal_vfio.c:1094:28: warning: cast increases >>>> required alignment of target type [-Wcast-align] >>>> 1094 | struct vfio_mp_param *p = (struct vfio_mp_param >> *)mp_req.param; >>>> | ^ >>>> .../lib/librte_eal/linux/eal_vfio.c:1116:7: warning: cast increases >>>> required alignment of target type [-Wcast-align] >>>> 1116 | p = (struct vfio_mp_param *)mp_rep->param; >>>> | ^ >>>> CC eal_common_bus.o >>>> .../lib/librte_eal/linux/eal_vfio.c: In function ‘rte_vfio_get_container_fd’: >>>> .../lib/librte_eal/linux/eal_vfio.c:1202:28: warning: cast increases >>>> required alignment of target type [-Wcast-align] >>>> 1202 | struct vfio_mp_param *p = (struct vfio_mp_param >> *)mp_req.param; >>>> | ^ >>>> .../lib/librte_eal/linux/eal_vfio.c:1248:7: warning: cast increases >>>> required alignment of target type [-Wcast-align] >>>> 1248 | p = (struct vfio_mp_param *)mp_rep->param; >>>> | ^ >