From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C497A42DD8; Wed, 5 Jul 2023 13:29:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9927D4021F; Wed, 5 Jul 2023 13:29:23 +0200 (CEST) Received: from forward500b.mail.yandex.net (forward500b.mail.yandex.net [178.154.239.144]) by mails.dpdk.org (Postfix) with ESMTP id BCA8640150; Wed, 5 Jul 2023 13:29:22 +0200 (CEST) Received: from mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:6e01:0:640:627f:0]) by forward500b.mail.yandex.net (Yandex) with ESMTP id EFFE05F26D; Wed, 5 Jul 2023 14:29:21 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id ITRe5l1De0U0-TJi617wU; Wed, 05 Jul 2023 14:29:21 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1688556561; bh=u04fVquM/uOqOETXcL6KT1ReM2Pk1ZLm+roHHPEq+Mc=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=CPInSJlgGegLvGabD3+/Iu79d1yGjbc0rqQUJHOVWBYrIwHJfuvf8wbmNXpclFbmK tCaw2ioLnWVK8BKcsV3r7uxENJkoZYNbnOyNLnG5ddRgBLTo6tW8P5V6wCP2tNiifL 7lJZwV936vrYwzZqe5peMtYJOql6xIuO56s0Anr0= Authentication-Results: mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: Date: Wed, 5 Jul 2023 12:29:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] cryptodev: fix device socket ID type Content-Language: en-US To: Ciara Power , dev@dpdk.org Cc: gakhil@marvell.com, olivier.matz@6wind.com, stable@dpdk.org, =?UTF-8?Q?Morten_Br=c3=b8rup?= , Kai Ji , Fan Zhang References: <20230629132155.75075-1-ciara.power@intel.com> <20230705103630.1131136-1-ciara.power@intel.com> From: Konstantin Ananyev In-Reply-To: <20230705103630.1131136-1-ciara.power@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/07/2023 11:36, Ciara Power пишет: > The socket ID field for a cryptodev device data was unsigned int. > Due to recent changes to the default device socket ID, > this caused an issue when the socket ID was unknown and set to -1. > The device socket ID wrapped around to 255, > and caused errors when allocating memory. > > Changing this field type to int fixes the issue, as it now takes the > correct -1 value. > > Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default") > Cc: olivier.matz@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Ciara Power > Acked-by: Morten Brørup > Acked-by: Kai Ji > > --- > v2: Added cc for stable mailing list > --- > lib/cryptodev/cryptodev_pmd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h > index 8710ed7558..4c98cedca6 100644 > --- a/lib/cryptodev/cryptodev_pmd.h > +++ b/lib/cryptodev/cryptodev_pmd.h > @@ -65,7 +65,7 @@ struct rte_cryptodev_data { > /** Device ID for this instance */ > uint8_t dev_id; > /** Socket ID where memory is allocated */ > - uint8_t socket_id; > + int socket_id; > /** Unique identifier name */ > char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > Acked-by: Konstantin Ananyev