From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 67F515398 for ; Wed, 14 Nov 2018 12:24:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2018 03:24:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,232,1539673200"; d="scan'208";a="104281577" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.124]) ([10.237.220.124]) by fmsmga002.fm.intel.com with ESMTP; 14 Nov 2018 03:24:06 -0800 To: Kevin Laatz , dev@dpdk.org Cc: thomas@monjalon.net References: <20181114112005.16378-1-kevin.laatz@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Wed, 14 Nov 2018 11:24:06 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181114112005.16378-1-kevin.laatz@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: fix duplicate function declaration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 11:24:08 -0000 On 14-Nov-18 11:20 AM, Kevin Laatz wrote: > The rte_eal_get_runtime_dir() function is currently being declared in two > header files. > > This API was made public in commit 6911c9fd8fbe ("eal: export function to > get runtime directory"), adding it to rte_eal.h. To make it public, the > 'rte' prefix was added to the function so it needed to be modified in the > original location of the declaration, eal_filesystem.h. By only modifying, > and not removing the decalration, it is now a duplicate. > > This patch removes the declaration from eal_filesystem.h. > > Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory") > > Reported-by: Anatoly Burakov > Signed-off-by: Kevin Laatz > > --- > v2: > - Fix commit message (checkpatch warning) > --- I was too late to ack the first one... Acked-by: Anatoly Burakov -- Thanks, Anatoly