From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E5FB41D93; Mon, 27 Feb 2023 22:50:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4320040A84; Mon, 27 Feb 2023 22:50:30 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 86CEA41181 for ; Mon, 27 Feb 2023 22:50:28 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kWmjelAXvVdDZ1njWSXi0eoLrC4WyYIrQhtSb83CkmutNhW7DMWydV1fmx70gMLmtfRg+UDq3y4ZZAHOhSmRvUo09ESAuOZUG9fxf/LuNLnwqg+nP+bxm1SbSyZJNH9S4iQ9GYqOt7Z2ceejEu01ipjHp2KflC0gM5nUZTePWBsVV0sNTO1WCimHIV1u9ryp8/N4Cv8EUrLPgijwE7e0YHVcNNIq/+I4k7dtLY2b3+bowiVVexo92jB3RjAbJ3nTTwcJP30LyUedifsCPip7m+cH4RQ96H2S2hxtSvkJG1D1ZKw5x46H0/YmQ1eeRWEUge0v9/FB3HO975UIUqDQNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gymbV5j9kBtOgYh9vFYyLCUfkUlL1Mqvu+jUGoL7xxI=; b=Ldg6EZ648028h3SrmeXC0ahl/QbiItPYD5UD8TAChVHa96Dcm0DkkNXzi/5rbSpNcEehj0v0nNAmrqXBRe5vEsTAQ+iywm1MMYVc8KawMoLqn2OyJcH4qwWAvM1Gu8w6lnKwb42de6atWgrABy0IAUufVaCTdtuAc8iR1z65bMf/hY3Ug077w9PoKx8KAbc+LgfWbjEV1l2/KktCcSwDeVI9QpFb9+qR03rUb8I1HoRrfD85/5D2/HaCGibGTCamWWAlSOW3iy+8RIIRLk2xqgFZXTB1YGyHckE9kkmA5Sqd+v0jJcgik31vLPL9jGBu80RSBGMSTPsmUuf41+ob3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gymbV5j9kBtOgYh9vFYyLCUfkUlL1Mqvu+jUGoL7xxI=; b=wGnmtvF3wLMi2TGsPXDE2bcYk8RMwq/r6Iy46ujYCcxN4dl1pFuPenXPPBPBCC1w1Cbvv6PLWYzMfBGU8MY41Ow8nryyZJLf5+musK2H3XylP8jqviO9uiP3GO2Be1WNmbfjtNi2ZDnu/YPAhDzRRZE3ALEw/GC6JW4pNrKveDk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM8PR12MB5448.namprd12.prod.outlook.com (2603:10b6:8:27::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 21:50:27 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 21:50:27 +0000 Message-ID: Date: Mon, 27 Feb 2023 21:50:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Mingxia Liu , dev@dpdk.org, beilei.xing@intel.com, yuying.zhang@intel.com References: <20230213021956.2953088-1-mingxia.liu@intel.com> <20230216003010.3439881-1-mingxia.liu@intel.com> <20230216003010.3439881-14-mingxia.liu@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v7 13/21] net/cpfl: support Rx offloading In-Reply-To: <20230216003010.3439881-14-mingxia.liu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM8PR12MB5448:EE_ X-MS-Office365-Filtering-Correlation-Id: 51049674-6168-4c78-5701-08db190ca309 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mkz2P0Vb7OaiK2GzCi2hDl3I3j0vePm01r3HRQraOX81geNz6p6GwRXW01sP01v2V+9IlXc/JVBDp/slnI6AJfCqNxPCkeVYCEx3zvuBdZgQYipA8tDMdaZ7g7RWs3U5G0s2ItmNuC4pmZnaMdSPmlgf9x2qwQ7lML8AEcFM2yElSH8fasSdJWWb963FmHng54T13jHtxWXYbRUteL2yAtyJUx6frESrKCLeeYQr1+XZMXhdBW/zW67IL6+JK3gdu5udScIfymzeO5uCmbqyxjmpeNeCRBsVXVj0uEMSwq8ohIfFMWkpJeGlIFjBXU+BXjTVnAPytQuB23mmHy3lNgeqDEm82yM/QQExLR+6V+UpLYscBmUd/c/jgEBX6NPHyv4AEXvKSRLv2m+CBm+EZZAbOoxTfgU5uJwiNfey7dJtiuxBG6njptiLGNN0XbOEIWUnBONX5aebzA3kdBF4KLUtNsHjAynZvMd5fxMJ2Wlr0t7+PxuSKFn+pDwTvtDmdZOakxMObGUQjEA7Iw4T9ShNNpsweiSUTy3WJ2qAkwdlmOVgoVvF4awHyFYvkxdHooXCoHR/cNTQO1nHwdurmgvra/udkDuYEc4KYk6eCQ9WKk/15TNY+LG8Zj79Mq6esybhXslP82jow9lnNvEtr1bR6UdNMUjR+VL2oXVgz9acCrV0jscgh4qgfiYMf0MXH/Vf8eGTHB5q06krdwtUUfsfKjHo8pV9h3EjGLltWZE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(136003)(396003)(366004)(39860400002)(376002)(451199018)(36756003)(83380400001)(478600001)(6486002)(6666004)(2616005)(6506007)(26005)(186003)(6512007)(86362001)(8936002)(41300700001)(2906002)(31696002)(5660300002)(66556008)(44832011)(66946007)(316002)(66476007)(8676002)(38100700002)(53546011)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0RpckFLUnZGaWVQZlE5UU5ud1VqeEhqdGJvNXZLUHROVFVBQk9IWFo4cUN5?= =?utf-8?B?d3ZYSW11REJqZ2svVXduVlhmV0R6dXJGTjBjSlB0eC9BTU1Yd1pLa1puZ0Jo?= =?utf-8?B?MXVKWHBtSVE1VE5WZ0t0bEZXUWs3OE03RFBXWjNKZWpJckQxYmd2ZXh2czlP?= =?utf-8?B?a2kremFZRmFHWDhyUHV6Y21zK1NVRXdZaGIxYjA5ZEZrVG94cjRUV2YvZkpU?= =?utf-8?B?Q2YwbXRjMFRoYzVDWGtvbUtVSGVTSkNxaW1rSEk1N2tuamFubEZaeWx0Ykxz?= =?utf-8?B?NWh5UG5GbE9Ba0E4TEdiaElMeDBPVkw4THhWc0xjQlVpam9mMnNmajF0Ri9G?= =?utf-8?B?NFc3SVc2QytjeFR4eWV3QkcvREJEd0FyaFFXMDN0YXJqSDcvVHVEcytPdFN2?= =?utf-8?B?SXlwdHlVelRGbkJ4akROeWlMTXI1bVk2TTRMQTlLbGxSR2dKWTlzUUh6dU5w?= =?utf-8?B?aHBDYmtpRkp3WUhpMmFMdlh1NkRKcmg5cUhNeXAvdEkwY09TTHZMZ3UrYms3?= =?utf-8?B?cVB1ZTZ3czZ6TkgzUVF5VkM5d0Rqa1VhQkpKMlNEaTEzdFBKdU1hU0IyZE5X?= =?utf-8?B?bWNIMmxkSDg0NFNsQ2oraHBkUlNPQ3J0cWE3RXFQdWtOSmRoR25ZSlFhaUx4?= =?utf-8?B?S0ZoMXNUUmJXcGpsMThJQ0JZY2F4bnVxV0p4Q3E4djZBOGZFTWxPSXlBcTVh?= =?utf-8?B?UjVBTFJwV21BSlovSDgvT3Y2aTZzR0luaFVkczFHQWN1TVNqUDBSN0dpNEZU?= =?utf-8?B?REhLRWE2dXNuTlk5M3Fsd1g1NUhldW9mUzhzSzZzMDJBNVpLMWNpWm54a2Zr?= =?utf-8?B?dzZWclRZOU9wNEkwUHB2dEtVYWZqL0xTbVhMd1JDUytqajVvT2l6UFVJWEZN?= =?utf-8?B?MlZUOUllcWQvOE0vaWRURDJhaGZYSnhYWlNldklodm1BaXcxT3NHV0NUM3JZ?= =?utf-8?B?Nm9DZzlXTlBMTk9VY3RmRlpEZ0E2c3JjZkZZWEp2U0xuR3lTS1JvVi9vSVJF?= =?utf-8?B?MWpwQSt1eExxUzVOM0lpOVloWmQzOGplL0FiTW04NTJSUjM5YWx0aWNVUkE1?= =?utf-8?B?QlpGSnpNVDBjQmRUcVJWaTAvT0s3UktudUxlNmJhT20zNU5GY1NkKyt1MGh3?= =?utf-8?B?UVVUSlpVWlZMck9kWEZ5YnBxakVzRXF1bDJsQjQvTjJYSVh5WkhUemNYYXln?= =?utf-8?B?Sm82Tnlmbzd6OUpkcEtnZkxNTUxVZnJtMUxiUkZ1QndtNysydFZrQ3l0VjRT?= =?utf-8?B?cCsyN2N0Zmt6T0JzaUpGdGgwb2Nhc3lEeUIxaGZWVTIyUmZZU0I1bGUwUW9w?= =?utf-8?B?ZW0xUHMzTG9LL3FSblRlTGY5Vk9uT1g4SGlhbWxOWlVnRzA5MzBvWUJJV256?= =?utf-8?B?K3kxcVUzZUkwN25iaFJHMms4TUh5Z21IV3YxbW9TOFRsdzJkS1FvOGNqd1pv?= =?utf-8?B?NzM1a1AzQ204elA1M3BBcFdZOHJXSmNHZW1HbVk3aVFreEhldkhKNEhmRStH?= =?utf-8?B?YWE5R29kRDNWdXVJWHlSTlM3S1dtalYvMUpicVFOeHRHVmY5T3FHcENuc3h5?= =?utf-8?B?YTJmRnUzRkZTamhtMUNDcmNPb1lHcmlJS3JzT1ozOCtxR3JGRzB1VCt6akNK?= =?utf-8?B?Q2ZDMmZpUjhOVkhLSGRQQUgyNFhNMk1LNWhPNlhvMFEzOFNhS2JUUnhtN05h?= =?utf-8?B?bm14d2xhNmZlajdjSjU3TDVIb0dKL0tOMGVyTHhoYldDMkRKS3J4Y0dGbHNi?= =?utf-8?B?dURYUnVsTUUzNHNqRFFZTXlXblVwVFNGQXk3Y0tZUUluQ2U1Q0JUTnJZVjk4?= =?utf-8?B?c0RDZm5LdEVaSWp4a3E1Q0loVU9RaG1sYW1vSURIdVFGNXlsV0xxNU54MTVO?= =?utf-8?B?cnJIYUh5RGxaRW9kb3FIRmlzMktuS0hZckdGbldNOVloRTRFc29YRDY3eTdJ?= =?utf-8?B?WTROU1ZzYlpIQkMzVzNJUXV1eEdOaDEyRVZTMm5qTkVOZHg0bEw0ZmxCNG1s?= =?utf-8?B?aFRNM3lFL05XVDBlOFNFaDIyUTVJdWY3UHVhU04xYkJlUDhzdFVreVJCN2hv?= =?utf-8?B?TzBLWENhLzVrRG4wWXRwRm41ZkVpTEhia25UaGMwa2ZUQmJzK0laUFFHck5E?= =?utf-8?Q?hm6l01wCqDGYU/T7xIaJdmUU4?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51049674-6168-4c78-5701-08db190ca309 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 21:50:27.1156 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yMY0WbhcHsy3zc/t+1bj2TvxkkDwsLq5lck8jXUQk2qxTWfshB0e1V4e6puUbJ97 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5448 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2023 12:30 AM, Mingxia Liu wrote: > Add Rx offloading support: > - support CHKSUM and RSS offload for split queue model > - support CHKSUM offload for single queue model > > Signed-off-by: Mingxia Liu > --- > doc/guides/nics/features/cpfl.ini | 2 ++ > drivers/net/cpfl/cpfl_ethdev.c | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/doc/guides/nics/features/cpfl.ini b/doc/guides/nics/features/cpfl.ini > index 470ba81579..ee5948f444 100644 > --- a/doc/guides/nics/features/cpfl.ini > +++ b/doc/guides/nics/features/cpfl.ini > @@ -8,6 +8,8 @@ > ; > [Features] > MTU update = Y > +L3 checksum offload = P > +L4 checksum offload = P > Linux = Y > x86-32 = Y > x86-64 = Y > diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c > index fb15004e48..d0f90b7d2c 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.c > +++ b/drivers/net/cpfl/cpfl_ethdev.c > @@ -99,6 +99,12 @@ cpfl_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > > dev_info->flow_type_rss_offloads = CPFL_RSS_OFFLOAD_ALL; > > + dev_info->rx_offload_capa = > + RTE_ETH_RX_OFFLOAD_IPV4_CKSUM | > + RTE_ETH_RX_OFFLOAD_UDP_CKSUM | > + RTE_ETH_RX_OFFLOAD_TCP_CKSUM | > + RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM; > + Just to confirm, are these capabilities are already supported in the data path functions? Same for Tx ones in next patch.