From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B33ACA04B5; Thu, 24 Sep 2020 16:47:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D3B11DED1; Thu, 24 Sep 2020 16:47:44 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 14D8C1DECD for ; Thu, 24 Sep 2020 16:47:42 +0200 (CEST) IronPort-SDR: peJ7dLdLnB55LOCkKi/dhwoUykxd3wGheKgJNkit2fpeb/hBDrQLdQ3bMabPBr1/DQwmDSdiua nIgj8x6Kr+hQ== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="140669095" X-IronPort-AV: E=Sophos;i="5.77,298,1596524400"; d="scan'208";a="140669095" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 07:47:38 -0700 IronPort-SDR: C4cUH2JFC2KX2nkza4e7ttWfJbaIMhyla+i6jpBWXz4p2mms4jeqa7ttCGrnJnkXDcFKcpZPU9 sCtuLrpxDmMQ== X-IronPort-AV: E=Sophos;i="5.77,298,1596524400"; d="scan'208";a="512186709" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.85.112]) ([10.251.85.112]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 07:47:37 -0700 To: Somnath Kotur , dev@dpdk.org Cc: Venkat Duvvuru References: <20200922070632.17706-1-somnath.kotur@broadcom.com> <20200922070632.17706-6-somnath.kotur@broadcom.com> From: Ferruh Yigit Message-ID: Date: Thu, 24 Sep 2020 15:47:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200922070632.17706-6-somnath.kotur@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 5/8] net/bnxt: add a null ptr check in bnxt PCI probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/22/2020 8:06 AM, Somnath Kotur wrote: > Check for devargs before invoking rep port probe. > > Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") > > Signed-off-by: Somnath Kotur > Reviewed-by: Venkat Duvvuru > --- > drivers/net/bnxt/bnxt_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index db2f0dd..84eba0b 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -6147,6 +6147,10 @@ static int bnxt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > } > PMD_DRV_LOG(DEBUG, "BNXT Port:%d pci probe\n", > backing_eth_dev->data->port_id); > + > + if (!pci_dev->device.devargs) > + return ret; > + There is already a null check at the beginning of the function because of the same thing (port representors), should they be combined? And devargs being not NULL does not really mean it has arguments related to the port representors, it may have other device devargs. Perhaps 'eth_da' can be used to check?