From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: eric zhang <eric.zhang@windriver.com>, tiwei.bie@intel.com
Cc: zhihong.wang@intel.com, dev@dpdk.org,
Allain.Legacy@windriver.com, Matt.Peters@windriver.com
Subject: Re: [dpdk-dev] [PATCH v3] net/virtio-user: check negotiated features before set
Date: Mon, 10 Sep 2018 15:42:47 +0200 [thread overview]
Message-ID: <fcfa2432-9793-f03a-2f64-d176bddf8327@redhat.com> (raw)
In-Reply-To: <1535558121-10034-1-git-send-email-eric.zhang@windriver.com>
On 08/29/2018 05:55 PM, eric zhang wrote:
> This patch checks negotiated features to see if necessary to offload
> before set the tap device offload capabilities. It also checks if kernel
> support the TUNSETOFFLOAD operation.
>
> Signed-off-by: eric zhang <eric.zhang@windriver.com>
>
> ---
> v3:
> * make other offloading features depend on CSUM
> * check IFF_VNET_HDR support when handling VHOST_GET_FEATURES
>
> ---
> v2:
> * don't return failure when failed to set offload to tap
> * check if offloads available when handling VHOST_GET_FEATURES
> ---
> drivers/net/virtio/virtio_user/vhost_kernel.c | 18 +++++---
> drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 56 +++++++++++++++++------
> drivers/net/virtio/virtio_user/vhost_kernel_tap.h | 2 +-
> 3 files changed, 54 insertions(+), 22 deletions(-)
>
Applied to dpdk-next-virtio/master, adding Fixes: line
as suggested by Tiwei.
Thanks,
Maxime
prev parent reply other threads:[~2018-09-10 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 15:55 eric zhang
2018-08-30 5:20 ` Tiwei Bie
2018-09-10 13:42 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcfa2432-9793-f03a-2f64-d176bddf8327@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=Allain.Legacy@windriver.com \
--cc=Matt.Peters@windriver.com \
--cc=dev@dpdk.org \
--cc=eric.zhang@windriver.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).