From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 2167511A4 for ; Mon, 10 Sep 2018 15:42:52 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A831C83207; Mon, 10 Sep 2018 13:42:51 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC22F112D197; Mon, 10 Sep 2018 13:42:49 +0000 (UTC) To: eric zhang , tiwei.bie@intel.com Cc: zhihong.wang@intel.com, dev@dpdk.org, Allain.Legacy@windriver.com, Matt.Peters@windriver.com References: <1535558121-10034-1-git-send-email-eric.zhang@windriver.com> From: Maxime Coquelin Message-ID: Date: Mon, 10 Sep 2018 15:42:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535558121-10034-1-git-send-email-eric.zhang@windriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 10 Sep 2018 13:42:51 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 10 Sep 2018 13:42:51 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3] net/virtio-user: check negotiated features before set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2018 13:42:52 -0000 On 08/29/2018 05:55 PM, eric zhang wrote: > This patch checks negotiated features to see if necessary to offload > before set the tap device offload capabilities. It also checks if kernel > support the TUNSETOFFLOAD operation. > > Signed-off-by: eric zhang > > --- > v3: > * make other offloading features depend on CSUM > * check IFF_VNET_HDR support when handling VHOST_GET_FEATURES > > --- > v2: > * don't return failure when failed to set offload to tap > * check if offloads available when handling VHOST_GET_FEATURES > --- > drivers/net/virtio/virtio_user/vhost_kernel.c | 18 +++++--- > drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 56 +++++++++++++++++------ > drivers/net/virtio/virtio_user/vhost_kernel_tap.h | 2 +- > 3 files changed, 54 insertions(+), 22 deletions(-) > Applied to dpdk-next-virtio/master, adding Fixes: line as suggested by Tiwei. Thanks, Maxime