From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4C5E61B09A for ; Mon, 17 Sep 2018 16:53:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2018 07:53:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,385,1531810800"; d="scan'208";a="233612157" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by orsmga004.jf.intel.com with ESMTP; 17 Sep 2018 07:53:41 -0700 To: Bruce Richardson , Jingjing Wu , Wenzhuo Lu Cc: dev@dpdk.org References: <20180913144405.72772-1-bruce.richardson@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Mon, 17 Sep 2018 15:53:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180913144405.72772-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/avf: remove unused variables and label X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 14:53:45 -0000 On 9/13/2018 3:44 PM, Bruce Richardson wrote: > Compiling with all warnings turned on causes errors about unused variables > and an unused label. Remove these to allow building without having to > disable those warnings. If this is fixing some build errors should it be backported? And why we didn't get those warnings until now, aren't we already compiling with all warnings turned on? > > Signed-off-by: Bruce Richardson <...>