From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/4] net/txgbe: fix RSS in double VALN
Date: Tue, 27 Apr 2021 17:42:26 +0100 [thread overview]
Message-ID: <fd6590ac-b033-1a94-f11b-bd216dc21e8b@intel.com> (raw)
In-Reply-To: <20210425080347.20376-2-jiawenwu@trustnetic.com>
On 4/25/2021 9:03 AM, Jiawen Wu wrote:
> Regard QINQ as one case of extend VLAN, and always enable QINQ mode when
> double VLAN is set, to avoid RSS does not work for QINQ packets.
>
It is hard to understand above paragraph, can you please reword it?
Also in the patch title s/VALN/VLAN
VLAN_EXTEND mainly comes from ixgbe, it is different than QinQ, which one does
your device supports?
> Fixes: 220b0e49bc47 ("net/txgbe: support VLAN")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
> drivers/net/txgbe/txgbe_ethdev.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
> index 97796f040b..87c041c2ec 100644
> --- a/drivers/net/txgbe/txgbe_ethdev.c
> +++ b/drivers/net/txgbe/txgbe_ethdev.c
> @@ -1217,17 +1217,12 @@ static void
> txgbe_vlan_hw_extend_enable(struct rte_eth_dev *dev)
> {
> struct txgbe_hw *hw = TXGBE_DEV_HW(dev);
> - struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
> - struct rte_eth_txmode *txmode = &dev->data->dev_conf.txmode;
> uint32_t ctrl;
>
> PMD_INIT_FUNC_TRACE();
>
> ctrl = rd32(hw, TXGBE_PORTCTL);
> - ctrl |= TXGBE_PORTCTL_VLANEXT;
> - if (rxmode->offloads & DEV_RX_OFFLOAD_QINQ_STRIP ||
> - txmode->offloads & DEV_TX_OFFLOAD_QINQ_INSERT)
> - ctrl |= TXGBE_PORTCTL_QINQ;
> + ctrl |= TXGBE_PORTCTL_VLANEXT | TXGBE_PORTCTL_QINQ;
> wr32(hw, TXGBE_PORTCTL, ctrl);
> }
>
> @@ -1287,8 +1282,9 @@ txgbe_vlan_offload_config(struct rte_eth_dev *dev, int mask)
> txgbe_vlan_hw_filter_disable(dev);
> }
>
> - if (mask & ETH_VLAN_EXTEND_MASK) {
> - if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND)
> + if (mask & (ETH_VLAN_EXTEND_MASK | ETH_QINQ_STRIP_MASK)) {
> + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND ||
> + rxmode->offloads & DEV_RX_OFFLOAD_QINQ_STRIP)
> txgbe_vlan_hw_extend_enable(dev);
> else
> txgbe_vlan_hw_extend_disable(dev);
>
next prev parent reply other threads:[~2021-04-27 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 8:03 [dpdk-dev] [PATCH 0/4] Fixes for txgbe Jiawen Wu
2021-04-25 8:03 ` [dpdk-dev] [PATCH 1/4] net/txgbe: fix RSS in double VALN Jiawen Wu
2021-04-27 16:42 ` Ferruh Yigit [this message]
2021-04-25 8:03 ` [dpdk-dev] [PATCH 2/4] net/txgbe: fix VF MTU limit setting Jiawen Wu
2021-04-27 16:44 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-25 8:03 ` [dpdk-dev] [PATCH 3/4] net/txgbe: remove port representor Jiawen Wu
2021-04-27 16:46 ` Ferruh Yigit
2021-04-25 8:03 ` [dpdk-dev] [PATCH 4/4] net/txgbe: add copyright owner Jiawen Wu
2021-04-27 16:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd6590ac-b033-1a94-f11b-bd216dc21e8b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).