From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 297E2A0547; Wed, 29 Sep 2021 09:27:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3847410D7; Wed, 29 Sep 2021 09:27:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0C3B540E3C for ; Wed, 29 Sep 2021 09:27:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632900441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aBw2R0DgM45JLE2eBXI6vTCOtVBXe7TrNw3mGLsZrWo=; b=as6yMuTT47bW3q/k3V+eBD2Vz+RTk6KywY5uX2jBrZ+SX5FSKfo0cP4Dzh/Jhjujkks87g GAeVLYMKXle+V3LYc4bSVaq6c0aiZ2er/HLTjVVvdN9/6S7/nIYupa6hM2gsikDBeCcUJ2 OkJsRinxGSj13OoWOdTve017pF9/cFc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-HAv9Uk__Ouak9aFzkZZUFw-1; Wed, 29 Sep 2021 03:27:20 -0400 X-MC-Unique: HAv9Uk__Ouak9aFzkZZUFw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F016584A5E7; Wed, 29 Sep 2021 07:27:18 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BFAB5D9C6; Wed, 29 Sep 2021 07:27:07 +0000 (UTC) Message-ID: Date: Wed, 29 Sep 2021 09:27:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: "Li, Xiaoyun" , "dev@dpdk.org" , "Xia, Chenbo" , "amorenoz@redhat.com" , "david.marchand@redhat.com" , "andrew.rybchenko@oktetlabs.ru" , "Yigit, Ferruh" , "michaelba@nvidia.com" , "viacheslavo@nvidia.com" Cc: "stable@dpdk.org" , "nelio.laranjeiro@6wind.com" , "yvugenfi@redhat.com" , "ybendito@redhat.com" References: <20210922095742.229262-1-maxime.coquelin@redhat.com> <20210922095742.229262-6-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: add missing flow types in port info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/22/21 13:31, Li, Xiaoyun wrote: > Hi > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Wednesday, September 22, 2021 17:58 >> To: dev@dpdk.org; Xia, Chenbo ; >> amorenoz@redhat.com; david.marchand@redhat.com; >> andrew.rybchenko@oktetlabs.ru; Yigit, Ferruh ; >> michaelba@nvidia.com; viacheslavo@nvidia.com; Li, Xiaoyun >> >> Cc: stable@dpdk.org; nelio.laranjeiro@6wind.com; yvugenfi@redhat.com; >> ybendito@redhat.com; Maxime Coquelin >> Subject: [PATCH v2 5/5] app/testpmd: add missing flow types in port info >> >> This patch adds missing IPv6-Ex flow types to port info command. >> >> Signed-off-by: Maxime Coquelin >> --- >> app/test-pmd/config.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index >> 9a4a0c232b..3550e0a18f 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -4528,6 +4528,9 @@ flowtype_to_str(uint16_t flow_type) >> {"ipv6-sctp", RTE_ETH_FLOW_NONFRAG_IPV6_SCTP}, >> {"ipv6-other", RTE_ETH_FLOW_NONFRAG_IPV6_OTHER}, >> {"l2_payload", RTE_ETH_FLOW_L2_PAYLOAD}, >> + {"ipv6-ex", RTE_ETH_FLOW_IPV6_EX}, >> + {"ipv6-tcp-ex", RTE_ETH_FLOW_IPV6_TCP_EX}, >> + {"ipv6-udp-ex", RTE_ETH_FLOW_IPV6_UDP_EX}, >> {"port", RTE_ETH_FLOW_PORT}, >> {"vxlan", RTE_ETH_FLOW_VXLAN}, >> {"geneve", RTE_ETH_FLOW_GENEVE}, > > You add missing ipv6 ex why not adding RTE_ETH_FLOW_GTPU too. It's also missing. > > Also, flowtype_to_str is added but what about str2flowtype() in cmdline.c? Both suggestions are added to the next revision. Thanks, Maxime >> -- >> 2.31.1 >